Re: [Nasm-devel] %error & %warning inside %if is broken since 215186fe82c461bc1ccef7bed5c1a1a0253bfcc9

[Knut S. O. <bir...@an...>]

Hi!

Found the problem.  You dropped a '!' when merging error and error_preproc.

Kind Regards,
  bird.

Signed-off-by: Knut St. Osmundsen<bir...@an...>

---
  preproc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/preproc.c b/preproc.c
index 343a77d..255ccae 100644
--- a/preproc.c
+++ b/preproc.c
@@ -4795,7 +4795,7 @@ static void pp_verror(int severity, const char 
*fmt, va_list arg)
      istk && istk->conds &&
      ((severity & ERR_PP_PRECOND) ?
       istk->conds->state == COND_NEVER :
-     emitting(istk->conds->state)))
+     !emitting(istk->conds->state)))
      return;

      /* get %macro name */
-- 
2.6.2.windows.1


On 2016-03-31 11:44 PM, H. Peter Anvin wrote:
> On 03/31/16 07:18, Knut St. Osmundsen wrote:
>> Hi!
>>
>> Just built current git and found that an annoying regression had crept
>> in since 2.12. The following code does not yield any warnings or errors:
>>
>> %ifndef NO_SUCH_DEFINE
>>    %warning "Warnings work!"
>>    %error "Errors works!"
>> %endif
>>
>> Bisecting indicates that 215186fe82c461bc1ccef7bed5c1a1a0253bfcc9 is the
>> first bad commit.
> Thanks for the alert!!
>
>> PS. Visual C++ 2010 still isn't happy with output/codeview.c, there are
>> two for loops in register_reloc() that declare variables inside the for
>> statement.
> Thanks.  This should be easy to fix.  I'm surprised that the new warning
> options don't trigger.
>
> 	-hpa
>
>
>
> ------------------------------------------------------------------------------
> Transform Data into Opportunity.
> Accelerate data analysis in your applications with
> Intel Data Analytics Acceleration Library.
> Click to learn more.
> http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140
> _______________________________________________
> Nasm-devel mailing list
> Nas...@li...
> https://lists.sourceforge.net/lists/listinfo/nasm-devel
>