Re: [Nasm-devel] Add Codeview 8 Support

[H. P. A. <hp...@zy...>]

On January 24, 2016 12:23:14 AM PST, Cyrill Gorcunov <gor...@gm...> wrote:
>On Sat, Jan 23, 2016 at 11:32:48PM -0800, Jim Kukunas wrote:
>> 
>> Hi Folks,
>> 
>> This patchset adds support for the Codeview 8 debug format for
>PE/COFF files.
>> 
>> The first two patches in this set lay the groundwork for the third.
>The first
>> patch adds a utility function for converting a relative path to an
>absolute
>> path, because Codeview wants absolute paths.  Codeview stores an MD5
>hash of
>> the source file, so the second patch adds an implementation that's in
>the
>> public domain.
>> 
>> All of the interesting bits in the third patch are in codeview.c.
>Prior to this
>> patch, COFF hadn't supported a debug format, so the debugs hooks
>weren't hooked
>> up, nor were the necessary bits exposed external to outcoff.c.
>> As a result, there's an ugly part of the diff for outcoff.c/pecoff.h
>that hooks
>> up the debug calls, exports some definitions and variables, and
>renames the
>> exported stuff to avoid collisions, e. g., Symbol -> coff_Symbol. I
>can roll
>> the ugly part into its own patch if it really bothers people.
>> 
>> So far, I've tested this in WinDbg for both 32- and 64-bit code. 
>> 
>> For more information on the Codeview 8 format, see
>https://github.com/yasm/yasm/blob/master/modules/dbgfmts/codeview/cv8.txt
>> 
>> Let me know what you think. 
>
>Wow! Thanks a huge! I believe it's very important feature.
>If hpa@ agreed I would merge it asap for testing.

Unequivocally:

Acked-by: H. Peter Anvin <hp...@zy...>
-- 
Sent from my Android device with K-9 Mail. Please excuse brevity and formatting.