Re: [Nasm-devel] [nasm:master] output: outmac64 -- Fix the case when first hit matches the symbol

[H. P. A. <hp...@zy...>]

On 06/03/2015 12:29 AM, Cyrill Gorcunov wrote:
> On Tue, Jun 02, 2015 at 02:49:20PM -0700, H. Peter Anvin wrote:
>>>
>>> diff --git a/output/outmac64.c b/output/outmac64.c
>>> index c07dcbc..1d30e64 100644
>>> --- a/output/outmac64.c
>>> +++ b/output/outmac64.c
>>> @@ -304,7 +304,7 @@ static struct symbol *get_closest_section_symbol_by_offset(uint8_t fileindex, in
>>>  
>>>      for (sym = syms; sym; sym = sym->next) {
>>>          if ((sym->sect != NO_SECT) && (sym->sect == fileindex)) {
>>> -            if ((int64_t)sym->value >= offset)
>>> +            if ((int64_t)sym->value > offset)
>>>                  break;
>>>              nearest = sym;
>>>          }
>>>
>>
>> For performance scaling reasons it would be good if we could use a LLRB
>> tree for this, like we do in ELF.
> 
> Sounds good, will do (in next release then).
> 

Yes, not a point release kind of thing.

	-hpa