Re: [Nasm-devel] [PATCH] Fix bug: AR2 treated as AR3

[Cyrill G. <gor...@gm...>]

On Fri, Feb 28, 2014 at 10:20:21PM -0800, Ben Rudiak-Gould wrote:
>    The iflags overhaul assigned AR0..AR4 to consecutive bits, but they
>    were still interpreted as consecutive integer values starting with 1.
>    As a result AR2..AR4 actually applied to arguments 3, 7, and 15
>    respectively. AR3 and AR4 are never used, so the practical upshot
>    was only that instructions like SHLD eax, ecx, byte 17 were
>    incorrectly rejected.
>    This patch fixes AR2 (in a slightly hacky way) and removes AR3 and AR4.
>    I threw AR3 and AR4 under the bus because I would rather replace all of
>    these flags with something simpler (I am working on a patch for that).
>    Signed-off-by: Ben Rudiak-Gould <ben...@gm...>

Thanks, Ben! I saw all your patches in the mailing list, they are not
missed. Will review once time permit.