Re: [Nasm-devel] Instruction flags engine is merged upstream

[Cyrill G. <gor...@gm...>]

On Sun, Nov 24, 2013 at 10:59:18AM -0800, H. Peter Anvin wrote:
> On 11/24/2013 01:29 AM, Cyrill Gorcunov wrote:
> > Hi guys, I've just merged up the reworked instruction flags engine.
> > Please review. I mostly worried about dissassembler part, which I
> > supposed I've converted well but more eyes needed here.
> > 
> > 	Cyrill
> 
> Oh, nevermind... I see you did it as a rebase rather than as a merge.
> Generally a merge is better since it preserves more of the history.
> 
> Jin, do you think this will slow down the AVX512 support, or is it fine
> as-is?
> 
> I'm not sure to what extent the SSE,MMX and SSE,FPU flags combinations
> ever made any sense... I don't think they ever made all that much sense
> it was more of "what do we do with this?"

Hi Peter, sorry for delay, was out. Look, I can rollback my commits
restoring former master and move flags patches out of mainline to
a separate tree (just one revert for all commits, it'll be easy).
The reason I merged it into master was that -- without rebase I've
got a number of merge problems because of new IF_ flags introduced
into master, so the longer I stay out of mainline the harder it will
be to port back. But again, Peter, it's not a problem to revert, just
say a word ;)

Also merge here make no much sence because the commits are almost unsplittable,
I tried to make them as simple as I can, but the change of @flags is too much
fundamental.

As to SSE,MMX, SSE,FPU flags -- the only purpose I've had initially is to
restore flags 1:1 as they were before avx512 changes. In future I think
we may provide a user options to select more flags from command line
and allow to filter instructions.