Re: [Nasm-devel] [PATCH 0/6] AVX-512: Bug fixes and additional features

[Cyrill G. <gor...@gm...>]

On Wed, Aug 21, 2013 at 07:29:07PM -0700, Jin Kyu Song wrote:
> Please review these patches and pull if they look good.
> git://repo.or.cz/nasm/avx512.git
> 
> After running a test case, various issues were found. One major thing is
> curly brace already used for grouping multi-line macro parameters.
> An escape backward slash character '\' is added when braces are passed
> as a part of enclosed parameter. The test asm file used here is also included.
> 
> Patch "AVX-512: Add a test case for EVEX encoded instructions" is
> relatively huge. So I did not attch that patch in this email. Please refer to
> http://repo.or.cz/w/nasm/avx512.git/commitdiff/a4a573c47f3d9ddfd5c2521804454327765f367e

Hi Jin, I've picked up all patches and pushed them on avx512 branch, thanks a lot,
good job!

One question -- you use TOK_BRACE for both { and } terms, won't it be better to
introduce two terms instead TOK_OPEN_BRACE and TOK_CLOSE_BRACE? How tokenizer
will handle statements like

	term \{ term \{

it will be treated as non-error case? (I must admit I didn't yet review
the whole avx code :(