[Nasm-devel] [PATCH] parse_line: Shrink code with memset helper

[Cyrill G. <gor...@gm...>]

We know that P_none = 0 thus instead of using
for() statement assign them all in one memset
call.

Signed-off-by: Cyrill Gorcunov <gor...@gm...>
---

Peter, was there some reason for not using memset here before?
I'm working on a bug atm and found this code snipped meanwhile
which I think worth to simplify.

 parser.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/parser.c b/parser.c
index 99bbc25..a71dd33 100644
--- a/parser.c
+++ b/parser.c
@@ -201,7 +201,6 @@ insn *parse_line(int pass, char *buffer, insn *result, ldfunc ldef)
     int critical;
     bool first;
     bool recover;
-    int j;
 
 restart_parse:
     first               = true;
@@ -261,8 +260,8 @@ restart_parse:
         return result;
     }
 
-    for (j = 0; j < MAXPREFIX; j++)
-        result->prefixes[j] = P_none;
+    nasm_build_assert(P_none != 0);
+    memset(result->prefixes, P_none, sizeof(result->prefixes));
     result->times = 1L;
 
     while (i == TOKEN_PREFIX ||
-- 
1.8.1.4