Re: [Nasm-devel] [nasm:master] BR3392231: Fix get_closest_section_symbol_by_offset

[Cyrill G. <gor...@op...>]

On Tue, Nov 13, 2012 at 07:58:29PM -0800, H. Peter Anvin wrote:
> On 11/05/2012 12:48 PM, nasm-bot for Cyrill Gorcunov wrote:
> >Commit-ID:  7ce86b500c792b782b7b076f50b220fc62234954
> >Gitweb:     http://repo.or.cz/w/nasm.git?a=commitdiff;h=7ce86b500c792b782b7b076f50b220fc62234954
> >Author:     Cyrill Gorcunov <gor...@gm...>
> >AuthorDate: Tue, 6 Nov 2012 00:47:20 +0400
> >Committer:  Cyrill Gorcunov <gor...@gm...>
> >CommitDate: Tue, 6 Nov 2012 00:47:20 +0400
> >
> >BR3392231: Fix get_closest_section_symbol_by_offset
> >
> >This patch changes get_closest_section_symbol_by_offset
> >logic to lookup only the closest symbols which are at
> >or before the supplied offset.
> 
> We could use an rbtree for this.  That's actually exactly what we
> have the rbtree code in NASM for.

Sure. But this would require more code. I'll take a look
once time permits, at moment fast fix should be enough.