#192 Make insns.dat more readable (fix attached)

closed-accepted
nobody
None
5
2011-07-20
2011-07-18
Anonymous
No

I converted almost all instructions in insns.dat (version 7a6f97869840fc0b1b8677bd77c74754c5f024aa) to the more readable format that insns.pl has supported for years. I also made some changes to insns.pl. You can verify that the new insns.dat and insns.pl produce byte-identical output to the old insns.dat and insns.pl, so I think that this change is safe to check in, even though it is a large change to insns.dat.

The changes to insns.pl are:
* fixed a bug: ib,u was not recognized
* added support for a second immediate argument called "j" for instructions like ENTER imm,imm
* added a "+r" syntax for \10..\13

Discussion

  • Cyrill Gorcunov

    Cyrill Gorcunov - 2011-07-18

    Will take a look as time permits (at moment i'm bringing in some new avx2 insns, and gonna cover tbm,bmi's as well), so probably until Peter approve this patches I won't pick them up yet.

    Still -- thanks a *huge* for contribution! (actually we would like to have a name -- to give credits if the changes will be merged).

     
  • H. Peter Anvin

    H. Peter Anvin - 2011-07-20

    That is awesome... and if the output is identical, I don't see any reason *not* to merge it, since that's the ultimate test anyway.

     
  • Cyrill Gorcunov

    Cyrill Gorcunov - 2011-07-20

    Great job! I merged the patch. Thanks a huge.

     
  • Cyrill Gorcunov

    Cyrill Gorcunov - 2011-07-20
    • status: open --> closed-accepted
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks