#60 Patch for Mono 4.0 profile

Current CVS
closed-fixed
Core (11)
5
2011-10-19
2011-03-11
No

Here is a patch in order to build NAnt for the Mono-4.0 profile. It was generated against the trunk at today's date.

I have identified two issues:
- Assembly.LoadFrom(String, Evidence) is deprecated in .NET 4.0. I have decorated the calls with an #ifdef.
- Mono reports a CS0419 error in a comment because of overlads of Path.Combine. I have remove the cref tag and decorate the comment with an #ifdef.

Discussion

  • Ryan Boggs

    Ryan Boggs - 2011-03-11

    Thanks for this Laurent but do you think you can recreate the diff using -uNR please. It makes it easier for me to review.

     
  • Laurent Etiemble

    Mono 4.0 profile diff (-uNR)

     
  • Laurent Etiemble

    I have attached the patch made with the -uNR options. Indeed, it is easier to review.

     
  • Ryan Boggs

    Ryan Boggs - 2011-03-13

    Much better, thank you. It looks straight forward and I have merged it into my local checkout. However, while reviewing this, I started seeing other areas with similar situations like this that could affect building NAnt on .NET 4.0. So it may be a bit before it is committed to my branch while I address those areas, but I am working on it.

     
  • Ryan Boggs

    Ryan Boggs - 2011-03-13
    • assigned_to: nobody --> rmboggs
     
  • Ryan Boggs

    Ryan Boggs - 2011-03-14

    I committed this to my branch for further review.

     
  • Ryan Boggs

    Ryan Boggs - 2011-03-14
    • status: open --> open-accepted
     
  • Ryan Boggs

    Ryan Boggs - 2011-05-04

    This should now be in head. The only problem I had was with the #ifdef around the comment. I rec'd errors when compiling on .NET. I might have to either restructure it some more or remove the <see> tag from the comment entirely.

     
  • Laurent Etiemble

    I vote to remove the see tag as it is the simpliest solution and avoids an #ifdef lost in the comments.

     
  • Ryan Boggs

    Ryan Boggs - 2011-10-19
    • status: open-accepted --> closed-fixed
     
  • Ryan Boggs

    Ryan Boggs - 2011-10-19

    I know this went in awhile ago (probably 0.91 Beta1). Just forgot to resolve this patch request.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks