nagios-db-devel Mailing List for Nagios-DB (Page 5)
Status: Beta
Brought to you by:
bench23
Menu
▾
▴
nagios-db-devel — An easy way for Nagios-DB developers to contact each other.
You can subscribe to this list here.
| 2004 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(1) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2005 |
Jan
(62) |
Feb
(9) |
Mar
(27) |
Apr
(9) |
May
(17) |
Jun
|
Jul
(7) |
Aug
(11) |
Sep
(5) |
Oct
|
Nov
(7) |
Dec
|
| 2006 |
Jan
|
Feb
(2) |
Mar
|
Apr
(2) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2007 |
Jan
|
Feb
(1) |
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: Ben <be...@si...> - 2005-01-27 21:47:07
|
It was on purpose, and it was the same purpose that made me not update the plugin output, which means that I don't recall why I did it that way. I'll change it to be inline with the updating plugin output. On Wed, 26 Jan 2005, Matthew Kent wrote: > Noticed it's defined in the postgres schema but not updated by the > stored proc, not sure if that's on purpose. > > Work continues.. :) > -- > Matthew Kent <mk...@ma...> > http://magoazul.com > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting > Tool for open source databases. Create drag-&-drop reports. Save time > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. > Download a FREE copy at http://www.intelliview.com/go/osdn_nl > _______________________________________________ > Nagios-db-devel mailing list > Nag...@li... > https://lists.sourceforge.net/lists/listinfo/nagios-db-devel > |
|
From: Ben <be...@si...> - 2005-01-27 21:46:13
|
On Thu, 27 Jan 2005, Matthew Kent wrote: > > Frankly, I think it makes a lot more sense to label everything as pending > > until it's been checked. Weren't you the one that convinced me of that? :) > > > > My apologies, I wasn't thinking clearly as to what the effect would be > on the tac display. The current implementation is the most accurate. Eh, no worries. I'm just glad somebody agrees with me. :) > > I think a better idea would be to change configure_host() and > > configure_service() to take in all the data we have on the host/service > > before it gets checked, so that we can make our placeholder records more > > accurate. > > > > Sounds good. Is passing everything to configure_host/configure_service > instead of just throwing it at processStatus to save processing time or > just a logical seperation? Logical seperation. Basically, processStatus expects to see a nebstruct_host_status_data, which is currently just a wrapper for a host struct, but in the future may have additional data in it. Or maybe data in the host struct will be moved out of the host struct and into the message.... it would make sense to me for that to happen. Anyway, I think the seperation makes sense. It keeps is clearer, in my head at least. > Was thinking about that too, if you removed a host (and maybe went to > add it back later) you might be annoyed to find all the history had > disappeared. I'll remove this from the mysql module and put a note about > adding a db_cleanup.php down the line so users can do it themselves. Yeah, it wouldn't be a bad idea to give a way to remove historical data for unconfigured hosts and services. I expect it would fit nicely into the UI you're making. :) |
|
From: Matthew K. <mk...@ma...> - 2005-01-27 21:19:47
|
On Thu, 2005-27-01 at 09:55 -0800, Ben wrote: > On Wed, 26 Jan 2005, Matthew Kent wrote: > > > In restart.sql (during nagios startup) I'm not quite clear on why an > > existing host and service should be reset back to a pending state by > > setting has_been_checked = FALSE. If you look at nagios and the standard > > cgis during startup, the data is read in from the retention file and the > > previous states for hosts/services is assumed to be correct. > > Well, technically, the check *is* pending. I understand that the retention > file says the host or service has a certain state, but that hasn't been > verified. If nagios was simply restarted, then the retention data is > likely accurate. But after a restart, it's entirely possible that nagios > might have been down for days, and in that case the retention data is much > more questionable. > > Frankly, I think it makes a lot more sense to label everything as pending > until it's been checked. Weren't you the one that convinced me of that? :) > My apologies, I wasn't thinking clearly as to what the effect would be on the tac display. The current implementation is the most accurate. > > Also in restart.sql, I'm not sure about inserting the empty host/service > > when one isn't found in the database. For example if you clear out the > > database and start nagios up the tac display will show X hosts with flap > > detection/notifications etc disabled which will slowly count backwards > > as all the checks complete. Kinda funky :) > > Yeah, that's a serious hack. However, I'm not sure how else to record > services for a new host that has yet to be checked, because if there isn't > a placeholder record, then the service cannot be entered into the > database. Perhaps I should set the host options to null, or some other > "unknown" state. > > > As I see it the solution for both issues would be to > > > > - set configured = false for all hosts/services > > - do the 'select into thisHostID id FROM host WHERE name = hostName;' > > > > if > > the host/service is NOT found, send the object to processStatus like > > > > /* update this host */ > > nebstruct_host_status_data ds; > > ds.object_ptr=(void *)hl; > > > > processStatus(NEBCALLBACK_HOST_STATUS_DATA, (void*)&ds); > > > > which will set configured = TRUE, update the has_been_checked field etc. > > else > > we set host/service configured = true and assume the rest of the data in > > the db is correct and leave it alone (save the extra resources of > > running the stored proc) > > I think a better idea would be to change configure_host() and > configure_service() to take in all the data we have on the host/service > before it gets checked, so that we can make our placeholder records more > accurate. > Sounds good. Is passing everything to configure_host/configure_service instead of just throwing it at processStatus to save processing time or just a logical seperation? > > Come to think of it at this point you could actually > > delete from host,service where configured = false > > to prune any hosts that have been removed from the config. > > I can't support deleting unconfigured hosts, because one of the > requirements my company has is to be able report on historical > availablity, even if the host isn't used anymore. > Was thinking about that too, if you removed a host (and maybe went to add it back later) you might be annoyed to find all the history had disappeared. I'll remove this from the mysql module and put a note about adding a db_cleanup.php down the line so users can do it themselves. > > This should give a more immediate overview of nagios's status right > > after startup. > > Like I said, I think showing most things in a pending state shows the most > accurate status. Well, actually, I suppose marking things as "Pending > (assumed up)" or "Pending (assumed down)" and such would be the most > accurate, but that could get messy. > Yeah, hardly worth the effort. Oh and did you get that other email about use of current_notification_number (it being defined in the schema but not referenced by the stored procs)? I'm not getting anything from the mailing list today. Thanks, -- Matthew Kent \ SA \ bravenet.com |
|
From: Ben <be...@si...> - 2005-01-27 17:55:25
|
On Wed, 26 Jan 2005, Matthew Kent wrote: > In restart.sql (during nagios startup) I'm not quite clear on why an > existing host and service should be reset back to a pending state by > setting has_been_checked = FALSE. If you look at nagios and the standard > cgis during startup, the data is read in from the retention file and the > previous states for hosts/services is assumed to be correct. Well, technically, the check *is* pending. I understand that the retention file says the host or service has a certain state, but that hasn't been verified. If nagios was simply restarted, then the retention data is likely accurate. But after a restart, it's entirely possible that nagios might have been down for days, and in that case the retention data is much more questionable. Frankly, I think it makes a lot more sense to label everything as pending until it's been checked. Weren't you the one that convinced me of that? :) > Also in restart.sql, I'm not sure about inserting the empty host/service > when one isn't found in the database. For example if you clear out the > database and start nagios up the tac display will show X hosts with flap > detection/notifications etc disabled which will slowly count backwards > as all the checks complete. Kinda funky :) Yeah, that's a serious hack. However, I'm not sure how else to record services for a new host that has yet to be checked, because if there isn't a placeholder record, then the service cannot be entered into the database. Perhaps I should set the host options to null, or some other "unknown" state. > As I see it the solution for both issues would be to > > - set configured = false for all hosts/services > - do the 'select into thisHostID id FROM host WHERE name = hostName;' > > if > the host/service is NOT found, send the object to processStatus like > > /* update this host */ > nebstruct_host_status_data ds; > ds.object_ptr=(void *)hl; > > processStatus(NEBCALLBACK_HOST_STATUS_DATA, (void*)&ds); > > which will set configured = TRUE, update the has_been_checked field etc. > else > we set host/service configured = true and assume the rest of the data in > the db is correct and leave it alone (save the extra resources of > running the stored proc) I think a better idea would be to change configure_host() and configure_service() to take in all the data we have on the host/service before it gets checked, so that we can make our placeholder records more accurate. > Come to think of it at this point you could actually > delete from host,service where configured = false > to prune any hosts that have been removed from the config. I can't support deleting unconfigured hosts, because one of the requirements my company has is to be able report on historical availablity, even if the host isn't used anymore. > This should give a more immediate overview of nagios's status right > after startup. Like I said, I think showing most things in a pending state shows the most accurate status. Well, actually, I suppose marking things as "Pending (assumed up)" or "Pending (assumed down)" and such would be the most accurate, but that could get messy. |
|
From: Matthew K. <ma...@br...> - 2005-01-27 15:25:47
|
Didn't get a copy of the last couple messages I sent... -- Matthew Kent \ SA \ bravenet.com |
|
From: Matthew K. <mk...@ma...> - 2005-01-27 06:04:35
|
Going over the changes for pending hosts and I've noticed a few things in the postgres module. In restart.sql (during nagios startup) I'm not quite clear on why an existing host and service should be reset back to a pending state by setting has_been_checked = FALSE. If you look at nagios and the standard cgis during startup, the data is read in from the retention file and the previous states for hosts/services is assumed to be correct. Also in restart.sql, I'm not sure about inserting the empty host/service when one isn't found in the database. For example if you clear out the database and start nagios up the tac display will show X hosts with flap detection/notifications etc disabled which will slowly count backwards as all the checks complete. Kinda funky :) As I see it the solution for both issues would be to - set configured = false for all hosts/services - do the 'select into thisHostID id FROM host WHERE name = hostName;' if the host/service is NOT found, send the object to processStatus like /* update this host */ nebstruct_host_status_data ds; ds.object_ptr=(void *)hl; processStatus(NEBCALLBACK_HOST_STATUS_DATA, (void*)&ds); which will set configured = TRUE, update the has_been_checked field etc. else we set host/service configured = true and assume the rest of the data in the db is correct and leave it alone (save the extra resources of running the stored proc) Come to think of it at this point you could actually delete from host,service where configured = false to prune any hosts that have been removed from the config. This should give a more immediate overview of nagios's status right after startup. Apologies for the long email. -- Matthew Kent <mk...@ma...> http://magoazul.com |
|
From: Matthew K. <mk...@ma...> - 2005-01-27 03:02:24
|
Noticed it's defined in the postgres schema but not updated by the stored proc, not sure if that's on purpose. Work continues.. :) -- Matthew Kent <mk...@ma...> http://magoazul.com |
|
From: Ben <be...@si...> - 2005-01-26 15:56:58
|
On Wed, 26 Jan 2005, Matthew Kent wrote: > future logic changes. One thing that would make this easier would be > getting sourceforge to send out unified diffs to nagios-db-checkins. I > can look at setting this up if you don't have the time and grant me > whatever permission this entails. Yeah, I've been lame and haven't set up nagios-db-checkins. I'll do that today. > Just for reference what permissions did the cache directory lack? I'll > add a note in the config.php Well, my cache directory wasn't owned by the the web server user, so no write permissions.... > And dos newlines eh. Strange since I'm working with Eclipse on Debian, > must be a setting for that. Bleh, the dos newlines were entirely my fault. |
|
From: Matthew K. <mk...@ma...> - 2005-01-26 15:45:16
|
On Wed, 2005-01-26 at 02:59, Ben wrote: > So, here's where I fall on my face and be lame - I simply don't have time > to port these database changes back to mysql. I altered mysql_control.php > to add in -1 for the pending_hosts column where I altered the views, so at > least it shouldn't actually *break*. But the logic is not correct. > Hopefully, somebody (like Matthew?) will look at the changes in > database/postgres/ and copy them over to database/mysql/. > I'll take a stab at it this evening, and will gladly duplicate any future logic changes. One thing that would make this easier would be getting sourceforge to send out unified diffs to nagios-db-checkins. I can look at setting this up if you don't have the time and grant me whatever permission this entails. > And speaking of more unfinished code, am I just dumb, or are templates not > yet working? After I figured out that the cache directory needs the proper > permissions, I got a really nice-looking menu system.... but nothing I > selected seemed to work. No you're not! It's quite unfinished - which is why I left the original index.html in place. The only item that should work is the Overview > Tac link, but even that's not done :) Once I get a bit more completed I was planning on asking for comments. Just for reference what permissions did the cache directory lack? I'll add a note in the config.php And dos newlines eh. Strange since I'm working with Eclipse on Debian, must be a setting for that. -- Matthew Kent <mk...@ma...> http://magoazul.com |
|
From: Ben <be...@si...> - 2005-01-26 03:00:00
|
OK, so I think I'm done with modifications that make nagios-db's handling of the transient pendings on startup much better. Here's what I did: As the NEB module initializes, I reset the has_been_checked flag on all hosts and services. I've also changed the postgres NEB module to behave like the mysql one in that it registers for an event, and kicks into steady state once nagios processes that event. This hides the NEB from the status calls as the previous values are read in. (I also fixed a cast in the mysql NEB, FWIW.) The NEB also now registers for host and service check callbacks. When it gets these, it calls new stored proces that set the has_been_checked flag. I'm not sure this is strictly necessary, as the flag also gets set in the status callback.... but it seems more proper. The UI has been changed on the tac and hostgroup tac pages, in that services on hosts that are still pending are listed as such, instead of as being on good hosts or bad hosts. This change meant changing the views around, and not just because I needed to display service status totals with a new "pending_hosts" column. Many of the views were using last_checked = 0 as a test for if the service had been checked; now, they use the (I hope) more correct has_been_checked flag. I also decided it didn't make sense to count pending-but-previously-checked services and hosts in the execution times. Finally, the host details view went through a major bloating process in order to properly union in pending services and services not associated with any hostgroup. Oh, yes, and I modified the status stored procs to update the host/service check output to be the most recent output, as opposed to first output when the host/service entered the current state. So, here's where I fall on my face and be lame - I simply don't have time to port these database changes back to mysql. I altered mysql_control.php to add in -1 for the pending_hosts column where I altered the views, so at least it shouldn't actually *break*. But the logic is not correct. Hopefully, somebody (like Matthew?) will look at the changes in database/postgres/ and copy them over to database/mysql/. And speaking of more unfinished code, am I just dumb, or are templates not yet working? After I figured out that the cache directory needs the proper permissions, I got a really nice-looking menu system.... but nothing I selected seemed to work. |
|
From: Ben <be...@si...> - 2005-01-25 19:20:51
|
On Mon, 24 Jan 2005, Matthew Kent wrote: > I'll be sending up some big changes to the UI soon (taking a bit longer > than expected) and will be sure to include the path option. Damn, I'd better get my UI fixes in soon, then. :) |
|
From: Ben <be...@si...> - 2005-01-25 19:20:15
|
On Mon, 24 Jan 2005, Tim Verhoeven wrote:
> Gents,
>
> I've finaly got my NEB module working, so I had a chance to play with the
> UI. It looks very nice and seems to be a good base to add things I need
> for our environment. So once again thanks for great work you already have
> done.
Well, I'm glad to hear that it's useful to more than just me.
> Critical error follows:
> select coalesce(hostgroup.alias,'[no group]') as
> hostgroup,shgs.hostname,soft_state,round((duration::float/totaltime)::numeric,5)
> as percent from hostgroup,summarize_grouped_host_states_by_hostgroup(
> null,null,'{18}') shgs where shgs.groupid = hostgroup.id and
> shgs.configured = TRUE order by name,hostname [nativecode=ERROR: missing
> .. at end of SQL expression]
So, I tried to run this in psql and had no problem. I haven't had a
problem with the page generation, either. I assume you get the same error
if you copy that SQL and run it in psql?
> The second issue are the paths used by the html code. They seems to start
> with /neb/. Since I just made a alias in my httpd.conf to what comes out
> of CVS this doesn't really work. So my I offer 2 suggestions to fix this ?
Yeah, this was an ugly hack because I'm lazy. It sounds like Matthew
already has a fix up his sleeve.
|
|
From: Matthew K. <mk...@ma...> - 2005-01-25 19:04:20
|
On Tue, 2005-01-25 at 18:08, Ben wrote: > On further research, it turns out that this is becuase nagios explicitly > does not do regular host checks when you set the host checking mode to > smart. So now I'm torn: while I like seeing that nagios has checked the > hosts explicitly, this is not how nagios works by default. It seems that > the web interface should reflect what nagios thinks... that is, if it > beileves the host is up, regardless of if it's been checked, we should > display it as being up. > > On Fri, 21 Jan 2005, Ben wrote: > > > On Tue, 18 Jan 2005, Ben wrote: > > > > > > The issue I see with how it currently works is that if you clear out the > > > > db and wipe the nagios retention.dat, when you go to start nagios up > > > > from this 'fresh' state the module doesn't insert all the host/services > > > > on startup. So instead of seeing '800 pending checks' after refreshing > > > > the mat view you see 5 hosts up/20 service ok/0 pending. > > > > > > I suppose that is more correct, and doing this will also address the issue > > > about serviceDetails.php not showing pending services. > > > > Ok, so I made some changes to get this to work, and I'm now noticing that > > it seems nagios isn't doing host checks on some of my servers. Have you > > noticed that? > > Makes sense to me. I think this is what the current cgi's do (?) I recall the hosts being marked as UP with '(Host assumed to be up)' in the status field after some service checks had returned okay. - Matt |
|
From: Ben <be...@si...> - 2005-01-25 18:08:21
|
On further research, it turns out that this is becuase nagios explicitly does not do regular host checks when you set the host checking mode to smart. So now I'm torn: while I like seeing that nagios has checked the hosts explicitly, this is not how nagios works by default. It seems that the web interface should reflect what nagios thinks... that is, if it beileves the host is up, regardless of if it's been checked, we should display it as being up. On Fri, 21 Jan 2005, Ben wrote: > On Tue, 18 Jan 2005, Ben wrote: > > > > The issue I see with how it currently works is that if you clear out the > > > db and wipe the nagios retention.dat, when you go to start nagios up > > > from this 'fresh' state the module doesn't insert all the host/services > > > on startup. So instead of seeing '800 pending checks' after refreshing > > > the mat view you see 5 hosts up/20 service ok/0 pending. > > > > I suppose that is more correct, and doing this will also address the issue > > about serviceDetails.php not showing pending services. > > Ok, so I made some changes to get this to work, and I'm now noticing that > it seems nagios isn't doing host checks on some of my servers. Have you > noticed that? > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting > Tool for open source databases. Create drag-&-drop reports. Save time > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. > Download a FREE copy at http://www.intelliview.com/go/osdn_nl > _______________________________________________ > Nagios-db-devel mailing list > Nag...@li... > https://lists.sourceforge.net/lists/listinfo/nagios-db-devel > |
|
From: Matthew K. <mk...@ma...> - 2005-01-24 22:53:19
|
On Mon, 2005-01-24 at 21:42, Tim Verhoeven wrote: > The second issue are the paths used by the html code. They seems to start > with /neb/. Since I just made a alias in my httpd.conf to what comes out > of CVS this doesn't really work. So my I offer 2 suggestions to fix this ? > > First is to make the prefix a config option. This addes some more php code > inbetween the html code but keeps the absolute paths. > Second is to change all path to the relative system. (That is what I did > as a quick fix to get it working) The problem is ofcourse that it is not a > clear system when you have many levels. > > I'm more than happy to implement either solution, or let me know if I mist > another solution. I'll be sending up some big changes to the UI soon (taking a bit longer than expected) and will be sure to include the path option. As to that sql error, I'll take a look this evening if Ben hasn't gotten to it already. -- Matthew Kent <mk...@ma...> http://magoazul.com |
|
From: Tim V. <dj...@ro...> - 2005-01-24 21:42:58
|
Gents,
I've finaly got my NEB module working, so I had a chance to play with the
UI. It looks very nice and seems to be a good base to add things I need
for our environment. So once again thanks for great work you already have
done.
But ofcourse being me I had to run into some sort of trouble :-) The first
thing is this SQL error with the availability reports. (I'm using pgsql)
Critical error follows:
select coalesce(hostgroup.alias,'[no group]') as
hostgroup,shgs.hostname,soft_state,round((duration::float/totaltime)::numeric,5)
as percent from hostgroup,summarize_grouped_host_states_by_hostgroup(
null,null,'{18}') shgs where shgs.groupid = hostgroup.id and
shgs.configured = TRUE order by name,hostname [nativecode=ERROR: missing
.. at end of SQL expression]
The error (between the [] brackets) is always the same but ofcourse the
actual select statement changes a bit for the 4 different availability
reports.
Since I'm not a hero with SQL and don't know pgsql at all I'm a bit lost
here. Any ideas ?
The second issue are the paths used by the html code. They seems to start
with /neb/. Since I just made a alias in my httpd.conf to what comes out
of CVS this doesn't really work. So my I offer 2 suggestions to fix this ?
First is to make the prefix a config option. This addes some more php code
inbetween the html code but keeps the absolute paths.
Second is to change all path to the relative system. (That is what I did
as a quick fix to get it working) The problem is ofcourse that it is not a
clear system when you have many levels.
I'm more than happy to implement either solution, or let me know if I mist
another solution.
Kind regards,
Tim
--
Tim Verhoeven - dj...@ro... - 0479 / 88 11 83
/* This is total bullshit: */
linux-2.6.6/drivers/video/sis/init301.c
|
|
From: Ben <be...@si...> - 2005-01-24 16:46:45
|
Doh! That's a good catch. And your cosmetic changes didn't both me, so it's all checked into cvs now. On Jan 24, 2005, at 7:41 AM, Tim Verhoeven wrote: > On Thu, 20 Jan 2005, Ben wrote: > >> Okay, well, there's a new postgres inserter.c checked into cvs. I now >> check the query result to see if it succeeded, and if not, log it. >> I'm not >> at all clear why PQclear() would be crashing, but perhaps the added >> logging will show something. >> >> I also started compiling with -Wall, which caught some printf >> sloppiness, >> but that shouldn't have done anything bad. > > Hi Ben, > > Since I've been playing with a copy of the inserter code to test my > things and because of your new inserter code in CVS, I've went to try > your code again so all my changes were out. > > And the first problem I've run into getting inserter going again was > the querify function again. Somehow it always fails to add ' and the > null char at the end. So I focused a bit on debugging this. Well the > fix was pretty simple and the big benefit was that all of a sudden > everything started working. No more segfaults. > > Attached is a diff to the CVS version with changes. The fix is to give > PQescapeString the length of the from string and not the to string. A > second change I made is to add 3 instead of 2 to the length of the to > string. This since we are adding 2 ' characters and you already have > to do +1 according to the pgsql docs. > > All the rest of the changes are just some costmetic changes to the log > messages. I find it cleaner this way. Feel free to discard them :-) > > One more thing is the pgsql connection parameters. These are at the > moment hardcoded. I've seen in the nagios docs that you can also give > parameters to NEB modules. It this something on your todo ? Or else > I'm interrested to have a look at that. > > Now I start testing the UI :-) > > Regards, > Tim > > -- > Tim Verhoeven - dj...@ro... - 0479 / 88 11 83 > > /* This is total bullshit: */ > linux-2.6.6/drivers/video/sis/init301.c > <inserter.c.diff> |
|
From: Tim V. <dj...@ro...> - 2005-01-24 15:41:50
|
On Thu, 20 Jan 2005, Ben wrote:
> Okay, well, there's a new postgres inserter.c checked into cvs. I now
> check the query result to see if it succeeded, and if not, log it. I'm not
> at all clear why PQclear() would be crashing, but perhaps the added
> logging will show something.
>
> I also started compiling with -Wall, which caught some printf sloppiness,
> but that shouldn't have done anything bad.
Hi Ben,
Since I've been playing with a copy of the inserter code to test my things
and because of your new inserter code in CVS, I've went to try your code
again so all my changes were out.
And the first problem I've run into getting inserter going again was the
querify function again. Somehow it always fails to add ' and the null char
at the end. So I focused a bit on debugging this. Well the fix was pretty
simple and the big benefit was that all of a sudden everything started
working. No more segfaults.
Attached is a diff to the CVS version with changes. The fix is to give
PQescapeString the length of the from string and not the to string. A
second change I made is to add 3 instead of 2 to the length of the to
string. This since we are adding 2 ' characters and you already have to do
+1 according to the pgsql docs.
All the rest of the changes are just some costmetic changes to the log
messages. I find it cleaner this way. Feel free to discard them :-)
One more thing is the pgsql connection parameters. These are at the moment
hardcoded. I've seen in the nagios docs that you can also give parameters
to NEB modules. It this something on your todo ? Or else I'm interrested
to have a look at that.
Now I start testing the UI :-)
Regards,
Tim
--
Tim Verhoeven - dj...@ro... - 0479 / 88 11 83
/* This is total bullshit: */
linux-2.6.6/drivers/video/sis/init301.c
|
|
From: Ben <be...@si...> - 2005-01-21 21:22:21
|
Well, I forget my rational at the time, but this was intentional. Maybe I was trying to lessen database load by keeping down the updates? Regardless, I think you are correct: current state should be displayed, as opposed to whatever things were like when the service/host first entered it's current state. On Fri, 21 Jan 2005, Matthew Kent wrote: > On Fri, 2005-01-21 at 20:32, Ben wrote: > > Well, as usual, blaming problems on something else publicly is a sure-fire > > way to figure out that it's really your fault. > > > > It appears that if a host is in a CRITICAL state since nagios has been > > started, then hostchecks still happen, but if they don't change the state, > > then NEB events are not fired. I've gotten around this by registering for > > host and service check events, as well as for status updates. Seems to be > > working better so far.... I'll watch how things progress over the next few > > hours. > > > > Great, I'll have to take a look at your changes when it's ready. > > So as for adding that extra plugin_output field I mentioned below, do > you agree with that logic? Or am I missing something obvious... seems to > me the UI should be displaying the most current check results. > > - Matt > > > On Fri, 21 Jan 2005, Matthew Kent wrote: > > > > > On Fri, 2005-01-21 at 19:37, Ben wrote: > > > > On Tue, 18 Jan 2005, Ben wrote: > > > > > > > > > > The issue I see with how it currently works is that if you clear out the > > > > > > db and wipe the nagios retention.dat, when you go to start nagios up > > > > > > from this 'fresh' state the module doesn't insert all the host/services > > > > > > on startup. So instead of seeing '800 pending checks' after refreshing > > > > > > the mat view you see 5 hosts up/20 service ok/0 pending. > > > > > > > > > > I suppose that is more correct, and doing this will also address the issue > > > > > about serviceDetails.php not showing pending services. > > > > > > > > Ok, so I made some changes to get this to work, and I'm now noticing that > > > > it seems nagios isn't doing host checks on some of my servers. Have you > > > > noticed that? > > > > > > Interesting, no I haven't noticed that. So they aren't showing up in the > > > nagios log either? > > > > > > What I did notice immediately after making that change was that host and service > > > check data in the UI was out of date. I made a note about it in the TODO. > > > > > > "need to define a plugin_output field for both host_check/service_check to be use > > > when querying host/service status. currently host_history/service_history is used > > > but these results are stale right after the initial check." > > > > > > -- > > > Matthew Kent <mk...@ma...> > > > http://magoazul.com > > > > > > > > > > > > ------------------------------------------------------- > > > This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting > > > Tool for open source databases. Create drag-&-drop reports. Save time > > > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. > > > Download a FREE copy at http://www.intelliview.com/go/osdn_nl > > > _______________________________________________ > > > Nagios-db-devel mailing list > > > Nag...@li... > > > https://lists.sourceforge.net/lists/listinfo/nagios-db-devel > > > > > > > > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting > > Tool for open source databases. Create drag-&-drop reports. Save time > > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. > > Download a FREE copy at http://www.intelliview.com/go/osdn_nl > > _______________________________________________ > > Nagios-db-devel mailing list > > Nag...@li... > > https://lists.sourceforge.net/lists/listinfo/nagios-db-devel > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting > Tool for open source databases. Create drag-&-drop reports. Save time > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. > Download a FREE copy at http://www.intelliview.com/go/osdn_nl > _______________________________________________ > Nagios-db-devel mailing list > Nag...@li... > https://lists.sourceforge.net/lists/listinfo/nagios-db-devel > |
|
From: Matthew K. <mk...@ma...> - 2005-01-21 20:49:31
|
On Fri, 2005-01-21 at 20:32, Ben wrote: > Well, as usual, blaming problems on something else publicly is a sure-fire > way to figure out that it's really your fault. > > It appears that if a host is in a CRITICAL state since nagios has been > started, then hostchecks still happen, but if they don't change the state, > then NEB events are not fired. I've gotten around this by registering for > host and service check events, as well as for status updates. Seems to be > working better so far.... I'll watch how things progress over the next few > hours. > Great, I'll have to take a look at your changes when it's ready. So as for adding that extra plugin_output field I mentioned below, do you agree with that logic? Or am I missing something obvious... seems to me the UI should be displaying the most current check results. - Matt > On Fri, 21 Jan 2005, Matthew Kent wrote: > > > On Fri, 2005-01-21 at 19:37, Ben wrote: > > > On Tue, 18 Jan 2005, Ben wrote: > > > > > > > > The issue I see with how it currently works is that if you clear out the > > > > > db and wipe the nagios retention.dat, when you go to start nagios up > > > > > from this 'fresh' state the module doesn't insert all the host/services > > > > > on startup. So instead of seeing '800 pending checks' after refreshing > > > > > the mat view you see 5 hosts up/20 service ok/0 pending. > > > > > > > > I suppose that is more correct, and doing this will also address the issue > > > > about serviceDetails.php not showing pending services. > > > > > > Ok, so I made some changes to get this to work, and I'm now noticing that > > > it seems nagios isn't doing host checks on some of my servers. Have you > > > noticed that? > > > > Interesting, no I haven't noticed that. So they aren't showing up in the > > nagios log either? > > > > What I did notice immediately after making that change was that host and service > > check data in the UI was out of date. I made a note about it in the TODO. > > > > "need to define a plugin_output field for both host_check/service_check to be use > > when querying host/service status. currently host_history/service_history is used > > but these results are stale right after the initial check." > > > > -- > > Matthew Kent <mk...@ma...> > > http://magoazul.com > > > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting > > Tool for open source databases. Create drag-&-drop reports. Save time > > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. > > Download a FREE copy at http://www.intelliview.com/go/osdn_nl > > _______________________________________________ > > Nagios-db-devel mailing list > > Nag...@li... > > https://lists.sourceforge.net/lists/listinfo/nagios-db-devel > > > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting > Tool for open source databases. Create drag-&-drop reports. Save time > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. > Download a FREE copy at http://www.intelliview.com/go/osdn_nl > _______________________________________________ > Nagios-db-devel mailing list > Nag...@li... > https://lists.sourceforge.net/lists/listinfo/nagios-db-devel |
|
From: Ben <be...@si...> - 2005-01-21 20:32:45
|
Well, as usual, blaming problems on something else publicly is a sure-fire way to figure out that it's really your fault. It appears that if a host is in a CRITICAL state since nagios has been started, then hostchecks still happen, but if they don't change the state, then NEB events are not fired. I've gotten around this by registering for host and service check events, as well as for status updates. Seems to be working better so far.... I'll watch how things progress over the next few hours. On Fri, 21 Jan 2005, Matthew Kent wrote: > On Fri, 2005-01-21 at 19:37, Ben wrote: > > On Tue, 18 Jan 2005, Ben wrote: > > > > > > The issue I see with how it currently works is that if you clear out the > > > > db and wipe the nagios retention.dat, when you go to start nagios up > > > > from this 'fresh' state the module doesn't insert all the host/services > > > > on startup. So instead of seeing '800 pending checks' after refreshing > > > > the mat view you see 5 hosts up/20 service ok/0 pending. > > > > > > I suppose that is more correct, and doing this will also address the issue > > > about serviceDetails.php not showing pending services. > > > > Ok, so I made some changes to get this to work, and I'm now noticing that > > it seems nagios isn't doing host checks on some of my servers. Have you > > noticed that? > > Interesting, no I haven't noticed that. So they aren't showing up in the > nagios log either? > > What I did notice immediately after making that change was that host and service > check data in the UI was out of date. I made a note about it in the TODO. > > "need to define a plugin_output field for both host_check/service_check to be use > when querying host/service status. currently host_history/service_history is used > but these results are stale right after the initial check." > > -- > Matthew Kent <mk...@ma...> > http://magoazul.com > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting > Tool for open source databases. Create drag-&-drop reports. Save time > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. > Download a FREE copy at http://www.intelliview.com/go/osdn_nl > _______________________________________________ > Nagios-db-devel mailing list > Nag...@li... > https://lists.sourceforge.net/lists/listinfo/nagios-db-devel > |
|
From: Matthew K. <mk...@ma...> - 2005-01-21 20:00:04
|
On Fri, 2005-01-21 at 19:37, Ben wrote: > On Tue, 18 Jan 2005, Ben wrote: > > > > The issue I see with how it currently works is that if you clear out the > > > db and wipe the nagios retention.dat, when you go to start nagios up > > > from this 'fresh' state the module doesn't insert all the host/services > > > on startup. So instead of seeing '800 pending checks' after refreshing > > > the mat view you see 5 hosts up/20 service ok/0 pending. > > > > I suppose that is more correct, and doing this will also address the issue > > about serviceDetails.php not showing pending services. > > Ok, so I made some changes to get this to work, and I'm now noticing that > it seems nagios isn't doing host checks on some of my servers. Have you > noticed that? Interesting, no I haven't noticed that. So they aren't showing up in the nagios log either? What I did notice immediately after making that change was that host and service check data in the UI was out of date. I made a note about it in the TODO. "need to define a plugin_output field for both host_check/service_check to be use when querying host/service status. currently host_history/service_history is used but these results are stale right after the initial check." -- Matthew Kent <mk...@ma...> http://magoazul.com |
|
From: Ben <be...@si...> - 2005-01-21 19:37:18
|
On Tue, 18 Jan 2005, Ben wrote: > > The issue I see with how it currently works is that if you clear out the > > db and wipe the nagios retention.dat, when you go to start nagios up > > from this 'fresh' state the module doesn't insert all the host/services > > on startup. So instead of seeing '800 pending checks' after refreshing > > the mat view you see 5 hosts up/20 service ok/0 pending. > > I suppose that is more correct, and doing this will also address the issue > about serviceDetails.php not showing pending services. Ok, so I made some changes to get this to work, and I'm now noticing that it seems nagios isn't doing host checks on some of my servers. Have you noticed that? |
|
From: Ben <be...@si...> - 2005-01-20 20:55:54
|
I'll do it. On Thu, 20 Jan 2005, Matthew Kent wrote: > > > The issue I see with how it currently works is that if you clear out the > > > db and wipe the nagios retention.dat, when you go to start nagios up > > > from this 'fresh' state the module doesn't insert all the host/services > > > on startup. So instead of seeing '800 pending checks' after refreshing > > > the mat view you see 5 hosts up/20 service ok/0 pending. > > > > I suppose that is more correct, and doing this will also address the issue > > about serviceDetails.php not showing pending services. > > Sorry, need clarification here, do you want me to fix this up over the > weekend or would you rather do it? > -- > Matthew Kent <mk...@ma...> > http://magoazul.com > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting > Tool for open source databases. Create drag-&-drop reports. Save time > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. > Download a FREE copy at http://www.intelliview.com/go/osdn_nl > _______________________________________________ > Nagios-db-devel mailing list > Nag...@li... > https://lists.sourceforge.net/lists/listinfo/nagios-db-devel > |
|
From: Matthew K. <mk...@ma...> - 2005-01-20 19:41:14
|
> > The issue I see with how it currently works is that if you clear out the > > db and wipe the nagios retention.dat, when you go to start nagios up > > from this 'fresh' state the module doesn't insert all the host/services > > on startup. So instead of seeing '800 pending checks' after refreshing > > the mat view you see 5 hosts up/20 service ok/0 pending. > > I suppose that is more correct, and doing this will also address the issue > about serviceDetails.php not showing pending services. Sorry, need clarification here, do you want me to fix this up over the weekend or would you rather do it? -- Matthew Kent <mk...@ma...> http://magoazul.com |
