Re: [Nagios-db-devel] neb startup revisited
Status: Beta
Brought to you by:
bench23
From: Ben <be...@si...> - 2005-01-27 21:46:13
|
On Thu, 27 Jan 2005, Matthew Kent wrote: > > Frankly, I think it makes a lot more sense to label everything as pending > > until it's been checked. Weren't you the one that convinced me of that? :) > > > > My apologies, I wasn't thinking clearly as to what the effect would be > on the tac display. The current implementation is the most accurate. Eh, no worries. I'm just glad somebody agrees with me. :) > > I think a better idea would be to change configure_host() and > > configure_service() to take in all the data we have on the host/service > > before it gets checked, so that we can make our placeholder records more > > accurate. > > > > Sounds good. Is passing everything to configure_host/configure_service > instead of just throwing it at processStatus to save processing time or > just a logical seperation? Logical seperation. Basically, processStatus expects to see a nebstruct_host_status_data, which is currently just a wrapper for a host struct, but in the future may have additional data in it. Or maybe data in the host struct will be moved out of the host struct and into the message.... it would make sense to me for that to happen. Anyway, I think the seperation makes sense. It keeps is clearer, in my head at least. > Was thinking about that too, if you removed a host (and maybe went to > add it back later) you might be annoyed to find all the history had > disappeared. I'll remove this from the mysql module and put a note about > adding a db_cleanup.php down the line so users can do it themselves. Yeah, it wouldn't be a bad idea to give a way to remove historical data for unconfigured hosts and services. I expect it would fit nicely into the UI you're making. :) |