Re: [Nagios-db-devel] abstraction and mysql support added to ui

[Matthew K. <mk...@ma...>]

On Tue, 2005-01-18 at 19:31, Ben wrote:
> Nice work, I'm looking it over and have some first-glance questions.
> 
> 1. You've modified the host stored proc to say that if a host doesn't have 
> a host_check defined, then it's always up. First, I'm not sure this is 
> correct - if we can't check the host, how do we know it's up? At best, 
> it'd be pending. Second, I don't think the changes you've done to the 
> stored proc make the host "up".... actually, I think they keep it in a 
> pending state. :)
> 

Well nagios allows for an undefined host check_command and considers
them permanently up
(http://nagios.sourceforge.net/docs/2_0/xodtemplate.html#host)

I may have missed the corresponding queries for the tac display to
include it as up though. That change was made quickly so I could start
the postgres module without it dumping on a query error since the field
was marked not null.

Also a few changes that I made for the mysql queries didn't make it back
into postgres quite yet. Need to test them some more.

> 2. What's wrong with bounded time limits? For me, this is a critical 
> feature, so they must be supported.
> 

Sorry I must have been mistaken in my testing, postgres's reports work
fine! I'll test the mysql equivalent again and fix it up.

> 3. What are the inconsistancies between psql, mysql, and the cigs? Those
> are likely bugs and should probably have a high priority of getting
> squashed.
> 

Well the most noticeable item for postgres is in the tac overview,
pending passive checks are totalled properly but not displayed by
serviceDetails.php when you click the link. 

> I'll ask more questions as they come to me. :)
> 

Perfect thanks. Couple more things

Do you have some time or mind if I make changes to your module to
register hosts and services on startup like the mysql one does? 

The issue I see with how it currently works is that if you clear out the
db and wipe the nagios retention.dat, when you go to start nagios up
from this 'fresh' state the module doesn't insert all the host/services
on startup. So instead of seeing '800 pending checks' after refreshing
the mat view you see 5 hosts up/20 service ok/0 pending.

Lastly, I have a nice and simple caching template implementation that
I'll send up today or tomorrow so I can work on some mockups of the gui
over the weekend for comment.
-- 
Matthew Kent <mk...@ma...>
http://magoazul.com