Compile error in 128-36

[Ryan Parle]

I have just had a compile error which, to me looks like a slight error in the code of managementserver.cpp
Line 23 reads: #include "defines/otaupdate_defines"
I have attached the log from the arduino IDE as Error1.txt

I changed line 23 to: #include "defines/otaupdate_defines.h" and the compile proceeded past the point at which it failed before but eventually failed at the "linking everything together" stage, I have attached these logs as Error2.txt

[brownrb]

Hi Ryan

As I work through this, I will provide you with the fix information. I will generate a new firmware version once completed with the changes.

In the meantime

In managementserver.cpp
DELETE line23

[Ryan Parle]

Compile was successful with this change, although OTA service is not running when ElegantOTA is defined.
If i instead define the ArduinoOTA compile is successful and OTA service is running on device.

having read in more detail about the OTA options i've decided that i will use the ArduinoOTA instead of the ElegantOTA, but i'm happy to provide bug reports for ElegantOTA if you want more info.

[brownrb]

For elegantOTA
It runs under the management server
so the address is port 6060 (your ip will be different)

Program the controller with elegantota defined

Open a web browser
Type in path for management server

192.168.2.128:6060

You are prompted for management server authentication
admin
admin

And the admin1 page will be displayed

Next specify the elegantota

192.168.2.128:6060/update

An authentication box appears
Note: Looks the same as before, BUT, it is not
You are now seeing the authemtication required for elegantota
specified in /defines/ota_update_defines.h
Defaults are mysqmesp
So enter mysqmesp as authentication,
then the elegantota page is displayed

[Marco Formenton]

I think the problem with EleganOta is a missing .h in the define path.
I solved adding the .h

[brownrb]

Yes, you are correct
in managementserver.cpp

#if defined(ENABLEOTAUPDATE)
extern const char *OTAName;                         // the username and password for the ElegantOTA service
extern const char *OTAPassword;
#if (ENABLEOTAUPDATE == UseElegantOTA)
**#include <ElegantOTA.h>                             // include Elegant Over **The Air updates
#endif // #if (ENABLEOTAUPDATE == UseElegantOTA)
#endif // #if defined(ENABLEOTAUPDATE)

I have decided to hold back the next update with these fixes, and incorporate all those into the next major release, 129-xx, which is currently being coded.

Regards
Robert