The usage of String in the firmware

[stefano]

Hi brownrb, I have a question for you, I seen in the firmware that you use a lot of time String expecially where JSON string is builded, there's a reason why you choose this way?

Did you consider to use ArduinoJson library? this can help to avoid floating exception and ram fragmentation

Thanks

[brownrb]

Am already using the ArduinoJson library - so not sure why you mentioned that.

Very briefly, and I do not intend to take long on this,
Ram fragmentation is not an issue here, because the strings are not global and are local only, and created on the called functions stack, so there is no need for the code to allocate more when a + command for the string is executed. When the function exits, the code simply pops off the stack and returns to the calling function. This means there is no fragmentation taking place.

[stefano]

I asked you cause I got a problem with static gps and looking in the json answer construction I've seen you don't give to arduino library the variable but you build the string by your self, and for this I was courios.

Anyway I have a problem with gpsstatic:

The sqm+ reply

 { "sqm":15.48455, "lux":0.06912, "nelm":1.707, "ambient":19.880, "humidity":37.0, "dewpoint":4.793, "pressure":1003.61,
"irambient":20.030, "irobject":20.590, "cloudcover":100.00, "skystate":1, "raining":0, "rvout":0.00, "rainhour":0.00,
"rainday":0.00, "windspd":0.00, "beaufort":0, "winddir":0, "wcf":0.00, "gpsldate":"01/01/1900",
"gpsltime":"00:00:00","lat":00 00 00 N,"lon":000 00 00 W,"sat":0,"alt":0,"fix":0 }

my config is this:

#define USESTATICGPS 2

#if defined(USESTATICGPS)
// Set your static GPS coordinates here
String mystaticlongitude = "15 20 93 E";  
String mystaticlatitude  = "43 46 10 N";     

so this should be true:

#if defined(USESTATICGPS)
  mylatitude = mystaticlatitude;
  mylongitude = mystaticlongitude;
#else

But When I parse the json coming from esp I get error on:
"lat":00 00 00 N,"lon":000 00 00 W,
invalid number

What I'm missing??

[brownrb]

Hi Stefano
To your query

"lat":00 00 00 N,"lon":000 00 00 W,
should be
"lat":"00 00 00 N","lon":"000 00 00 W",
because the coordinates are strings containing digits AND hemisphere information (W and N)
But of course there is another issue in that the coordinates should be replaced by the static ones.

That all changes in the new firmware coming. All those things move to the file system, where you can change all of those details on the fly without having to change the firmware and then reprogram the controller. That is only one change of many.

There are issues with the current implementation on Sourceforge. Put simply - there are a few bugs. This has been literally replaced with new code.

FYI I have been on a coding binge over the last week - well into the night and early morning each day on this project., sometimes 12-16 hrs on the stretch. But I see daylight coming very soon.

What I can tell you is that new Firmware is coming very soon v124-0 as well as new apps etc, and I would think that will go a long way to fixing that and other issues.

[stefano]

no problem, I understand you, I do the same but for automation software...the time is too short when we are coding :) no problem i fix it by myself in the code, I don't need the gps cause i know where I'm

[brownrb]

Ok. Appreciate the question.

from feedback, a lot of users like to post to things like weather underground or on the Internet as part of thier observatory page, and a lot seem to use mySQMWEB on a Pi to do this. Having the ability to hide real locations or even use static ones is high on the list of "please implement".

Cheers
Robert
(back to more coding)

[stefano]

in my case I have already a pc 24h on, in my observatory, I'm making a python script to get weather data and send to a laravel based api in my hosting, and showing data via nuxt app.. I'll have a big headhake in the end but is just for learning