Bugs item #938458, was opened at 2004-04-20 09:59
Message generated for change (Comment added) made by redi
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=107869&aid=938458&group_id=7869
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Philipp Berndt (pberndt)
Assigned to: Jonathan Wakely (redi)
Summary: ColData::is_null() modifies object
Initial Comment:
In Version 1.9.3:
A method starting with "is" is commonly expected to be an accessor
for a boolean member, that is to be const and return bool.
Instead in ColData.h:
void is_null()
{
m_bNull = true;
}
Maybe this method with the funky name does what one would expect
from ColData::is_null():
inline const bool ism_bNull() const
{
return m_bNull;
}
----------------------------------------------------------------------
>Comment By: Jonathan Wakely (redi)
Date: 2005-09-03 17:35
Message:
Logged In: YES
user_id=426241
Fixed in CVS (and a release is imminent)
I removed the non-const is_null() and renamed ism_bNull() to
is_null().
----------------------------------------------------------------------
Comment By: Jonathan Wakely (redi)
Date: 2004-05-07 13:13
Message:
Logged In: YES
user_id=426241
I agree it's badly named, however, the fact that it returns
void and is non-const makes it somewhat clearer that it's
not a boolean accessor.
I'm not sure about changing those names (again).
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=107869&aid=938458&group_id=7869
|
