Re: [Mysqlcppapi-main] a patch - where to send?

[Radoslaw G. <rga...@ay...>]

Hi,

 Thank you for the quick response.

On Tuesday 08 March 2005 14:19, you wrote:
> Yes, or sending it to this list might get a quicker response.

 Considering the fact that "mysql_shutdown" is already done there is almost=
=20
nothing to change, just the file: mysqlcppapi/ColData.h
@@ -221,7 +221,7 @@
=20
=20
 template <class T_Str> template<class Type>=20
=2DType ColData_Generic<T_Str>::conv(Type dummy) const
+Type ColData_Generic<T_Str>::conv(Type /*dummy*/) const
 {
   std::string strbuf(buf);
   strip_all_blanks(strbuf);

> >  I would like to ask, if it was possible, for the more complex exceptio=
ns
> > scheme - for now I have to check the exception's description to check t=
he
> > reason (e.g. all "artificial deadlocks" of MySQL which, as they suggest,
> > should cause transactions retrial).
>
> That's a good idea, feel free to post suggestions to this list.

 The failure reasons I have to check by comparing strings:
 1.	mysqlcppapi::ex_BadQuery.what() =3D=3D "Duplicate entry"
	the_proposal: ex_DuplicateEntry

 2.	mysqlcppapi::ex_BadQuery.what() =3D=3D "mysql_real_connect() failed"
	the_proposal:ex_ConnectionFailure

 3.	mysqlcppapi::ex_BadQuery.what() =3D=3D ".*try restarting transaction.*"
	The suggestion to restart the transaction can happen in various situations=
, =20
so I check the existence of this phrase inside the exception description.
	the_proposal:	ex_InternalTimeout | ex_TransRestart
					e.g. ex_InternalDeadLock: public ex_InternalTimeout

 I also added files such as: AUTHOR, COPYING, etc. to the set of files bein=
g=20
installed - it is prepared for SuSE like directories scheme (packages'=20
documentation is placed in "/usr/share/doc/packages/<package>") - to make i=
t=20
in a traditional way ("/usr/share/package") just the line:
pkgdatadir              =3D $(datadir)/doc/packages/@PACKAGE@
has to be removed from the main Makefile.am

 I have the SPEC to build RPMs so if you were interested you can use it=20
(please check whether there is no LGPL license violation).

Attached:=20
=2D the patch against the version 1.9.3
=2D the spec file

=2D-=20

    Mit freundlichen Gr=FC=DFen
    Best regards
   =20
    //	Radoslaw Garbacz
    //  aycan Digitalsysteme GmbH
    //  Innere Aumuehlstrasse 5
    //  97076 Wuerzburg
    //  Germany
    //  phone: +49 931.270 40 90
    //  fax:   +49 931.270 40 91
    //  mailto:rga...@ay...
    //  http://www.aycan.de