I have recently added a new setup for Windows which hopefully will allow it to build without any patches. But like I have said repeatedly, I don't have a Windows box so I can't test it. That's where you come in, assuming that you are someone with the correct compiler and competence. You need to check out the current MySQLdb-1.2 branch and see if the build works. If you were using the command-line client, you would do this:
If you find that it still needs patching, add a patch to the Patch Tracker.
The sooner you test this, the sooner I can release 1.2.2b3, and then 1.2.2, and then we can have some lovely Windows builds and all live happily ever after.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I applied your patch plus two of the reconnect patches. I'll release 1.2.2b3 pretty soon; if you can test the Windows build first (against SVN branch/MySQLdb-1.2), that would be helpful.
(I closed out a bunch of bugs tonight and realized just now that I asked on some of them to test against the trunk which is wrong; they should test the 1.2 branch.)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Now that I have your attention...
I have recently added a new setup for Windows which hopefully will allow it to build without any patches. But like I have said repeatedly, I don't have a Windows box so I can't test it. That's where you come in, assuming that you are someone with the correct compiler and competence. You need to check out the current MySQLdb-1.2 branch and see if the build works. If you were using the command-line client, you would do this:
svn co https://mysql-python.svn.sourceforge.net/svnroot/mysql-python/branches/MySQLdb-1.2/MySQLdb
If you find that it still needs patching, add a patch to the Patch Tracker.
The sooner you test this, the sooner I can release 1.2.2b3, and then 1.2.2, and then we can have some lovely Windows builds and all live happily ever after.
I tested it successfully. I just had to make a small patch (in the tracker system) and I had an python 2.5 installer for windows.
See here for the patch http://sourceforge.net/tracker/index.php?func=detail&aid=1651584&group_id=22307&atid=374934
I applied your patch plus two of the reconnect patches. I'll release 1.2.2b3 pretty soon; if you can test the Windows build first (against SVN branch/MySQLdb-1.2), that would be helpful.
(I closed out a bunch of bugs tonight and realized just now that I asked on some of them to test against the trunk which is wrong; they should test the 1.2 branch.)
It would be great if the release 1.2.2 would contain the patch which makes the MYSQL_OPT_RECONNECT option available for MySQLdb.