I tested yesterday the new 316 firmware with indi (2.0.1). The focuser can not be connected Issue is present at the very beginning when driver is asking for firmware version.
311 version was working fine.
I have to test with the latest indi version, but there is no differences between the latest revision and mine, at least for the first handshake (firmware version ).
Digging into tcpip-server code i found that in many send_reply method that the token variable in the snprintf
was replaced by a _RTOKEN (for example line 283:
snprintf(buff, sizeof(buff), "%c%s%c", _RTOKEN, data_val, _EOC);
which was in the 311 firmware (line 268)
snprintf(buff, sizeof(buff), "%c%s%c", token, data_val, _EOFSTR);
that means that with 311 firmware the answer for example to a 4 command is something like
FMyFP2ESP32\r\n 311#
while with 316 the answer is somethink like
$MyFP2ESP32\r\n 316#
since indi (and i presume the android app too) is expecting a F as the first char of the reply..it doesn't work.
i will try to replace the _RTOKEN in the build_reply to see what happen
Regards
Joël
Last edit: Collet 2024-09-29
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I am posting a fix tommorrow, Would mot suggest doing that at present because that may break other things. I have to make sure that the changes have to work with a whole heap of other apps
Last edit: brownrb 2024-09-30
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Robert
I tested yesterday the new 316 firmware with indi (2.0.1). The focuser can not be connected Issue is present at the very beginning when driver is asking for firmware version.
311 version was working fine.
I have to test with the latest indi version, but there is no differences between the latest revision and mine, at least for the first handshake (firmware version ).
Digging into tcpip-server code i found that in many send_reply method that the token variable in the snprintf
was replaced by a _RTOKEN (for example line 283:
snprintf(buff, sizeof(buff), "%c%s%c", _RTOKEN, data_val, _EOC);
which was in the 311 firmware (line 268)
snprintf(buff, sizeof(buff), "%c%s%c", token, data_val, _EOFSTR);
that means that with 311 firmware the answer for example to a 4 command is something like
FMyFP2ESP32\r\n 311#
while with 316 the answer is somethink like
$MyFP2ESP32\r\n 316#
since indi (and i presume the android app too) is expecting a F as the first char of the reply..it doesn't work.
i will try to replace the _RTOKEN in the build_reply to see what happen
Regards
Joël
Last edit: Collet 2024-09-29
I am posting a fix tommorrow, Would mot suggest doing that at present because that may break other things. I have to make sure that the changes have to work with a whole heap of other apps
Last edit: brownrb 2024-09-30
Hi Robert
Sure we can wait
JoËl