From: Brook M. <br...@nm...> - 2021-06-18 22:08:05
|
I would like to offer a suggestion/patch for the mummer scripts/Makefile. Currently, you use the make variable BIN_DIR for two distinct purposes: - The location of various files within the source tree that you are manipulating with sed, and - The location of installed files that gets embedded within the scripts. If the files are moved, as they are by any packaging system, the embedded paths will be incorrect. As a result, it seems important to have separate make variables for the installed paths. The attached patch accomplishes this by adding make variables, for example, INSTALL_BIN_DIR, to use in the sed replacements. It should also achieve exactly the same thing as your current Makefile does, because the definitions of the new variables correspond to those of the variables they replace. Ideally these makefiles would use ${PREFIX} to create variables for installation purposes as many other projects do, but in the meantime this would be a helpful step forward. I hope you will consider committing this patch for the next release. Thank you very much. Cheers, Brook |