#33 [CRASH] LDAP module

[Michael]

I'm filing this in the "Main syncengine" category,
there is no for LDAP. There should, I guess.

Trying to sync to a LDAP server without evolution
support I get a crash. Using snapshot of Jan, 19. Below
is the patch which made it possible for me to proceed.
The reason for the crash seems to be rather obvious.

*** ldap.c 2003-12-03 15:31:43.000000000 +0100
--- ldap.c.NEW 2005-01-20 14:45:59.883199261 +0100
***************
*** 171,176 ****
--- 171,181 ----
}

ldapvals = ldap_get_values(conn->ld, res2,
"objectClasses");
+ if( !ldapvals ){
+ ldap_debug(conn, 0, "Cannot decode
objectclass entries(?)");
+ return 1;
+ }
+*** ldap.c 2003-12-03 15:31:43.000000000 +0100
--- ldap.c.NEW 2005-01-20 14:45:59.883199261 +0100
***************
*** 171,176 ****
--- 171,181 ----
}

ldapvals = ldap_get_values(conn->ld, res2,
"objectClasses");
+ if( !ldapvals ){
+ ldap_debug(conn, 0, "Cannot decode
objectclass entries(?)");
+ return 1;
+ }
+

while (ldapvals[i]) {

while (ldapvals[i]) {

[Palumbo Daniele]

Logged In: YES
user_id=222909

i haven't tried the patch yet, anyway this is ldap.c.patch
use it in multisync source dir, with patch -p0 < ldap.patch

<pre>
--- plugins/ldap_plugin/src/ldap.c.orig 2005-02-09
10:21:53.000000000 +0100
+++ plugins/ldap_plugin/src/ldap.c 2005-02-09
10:22:55.000000000 +0100
@@ -172,6 +172,11 @@

ldapvals = ldap_get_values(conn->ld, res2,
"objectClasses");

+ if( !ldapvals ) {
+ ldap_debug(conn, 0, "Cannot decode
objectclass entries(?)");
+ return 1;
+ }
+
while (ldapvals[i]) {
if (strstr(ldapvals[i], "evolutionPerson")) {
ldap_value_free(ldapvals);
</pre>

be care:
multisync use tabs, so this patch will never work as long as
you copy and paste from your browser.

download it:
http://www.retaggio.net/multisync.ldap.miko22.crash.patch