#379 Patch for ParseGathererCardLanguages

Bug
closed
patch (3)
5
2014-08-11
2014-08-09
No

Hi Alena,
this patch fixed a bug in ParseGathererCardLanguages#loadHtml while recalling this methode like from UpdateCardsFromWeb. landId will not be set to "0" again if no language was found and still holds the reference of the previous call.
BTW did you see my try to send a post to the forum? I am not sure if it works.
CU,
Björn

1 Attachments

Discussion

  • Bjoern Schmidt

    Bjoern Schmidt - 2014-08-09

    Yes I was logged in. If I push the "create topic" button I get the message "You do not have permission to post in any forums." thought that it was moderated and OK. If I use the function "Send Email to Create a New Topic" it seams that it do not reached anyone and also do not get an email error response.
    Never mind, I descript the bug some more in my request and talk about my plan to increase the update process speed (maybe I try to use the forum for this part later again if I still have questions or make a feature request patch if it is ready).

    You can see what this patch fixed if you include the following Syteme.err line in UpdateCardsFromWeb#updateStore (somewhere around line 112)

    ...
    int langId = langParser.getLangCardId();
    System.err.println("Loading card ["+i+"], original card id ["+cardId+"], language card id [" + langId + "]");
    if (langId != 0) {
    ...
    

    If you select all three check boxes, "Alara Reborn" as Set and "Chinese Simplified" as local and start with a clean workspace you get the following output:

    Loading card [0], original card id [179538], language card id [196420] 
    Loading card [1], original card id [220517], language card id [196420]    ?
    Loading card [2], original card id [179597], language card id [196404]
    Loading card [3], original card id [185054], language card id [196388] 
    Loading card [4], original card id [205317], language card id [196388]    ?
    Loading card [5], original card id [189652], language card id [197776]
    Loading card [6], original card id [180608], language card id [196389]
    ...
    

    As you can see there are some duplicated langId cards (marked with '?') from a previous call.

    The patch fix this behavior and shows this as output:

    Loading card [0], original card id [179538], language card id [196420]
    Loading card [1], original card id [220517], language card id [0]
    Loading card [2], original card id [179597], language card id [196404]
    Loading card [3], original card id [185054], language card id [196388]
    Loading card [4], original card id [205317], language card id [0]
    Loading card [5], original card id [189652], language card id [197776]
    Loading card [6], original card id [180608], language card id [196389]
    ...
    
     
  • Bjoern Schmidt

    Bjoern Schmidt - 2014-08-09

    ... and let me know if you start with i18n stuff as descripted in the todo list. I am from germany and can do the german translation.

     
  • Alena Laskavaia

    Alena Laskavaia - 2014-08-11

    I added test and pushed this too

     
  • Alena Laskavaia

    Alena Laskavaia - 2014-08-11
    • status: open --> closed
     
  • Alena Laskavaia

    Alena Laskavaia - 2014-08-11

    Thank you

     


Anonymous

Cancel  Add attachments





Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks