Check return codes everywhere

Brought to you by: robodan

#2 Check return codes everywhere

Status: open-later

Owner: nobody

Labels: None

Priority: 1

Updated: 2007-07-03

Created: 2007-02-22

Creator: Markus Elfring

Private: No

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "fprintf" in functions like "generateMessage" and "mysslerr"?
http://mstone.svn.sourceforge.net/viewvc/mstone/trunk/mstone/src/generate.c?revision=7&view=markup
http://mstone.svn.sourceforge.net/viewvc/mstone/trunk/mstone/src/socket.c?revision=7&view=markup

Discussion

Dan Christian - 2007-07-03

status: open --> open-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Christian - 2007-07-03

Logged In: YES
user_id=865423
Originator: NO

This isn't a bug report, it's a question... It's true that return codes aren't used consistently or everywhere. It works fine for me in practice.

I'm not going to make arbitrary clean up until I am actively working with a section of code (so it can be fully tested).

If a specific problem is showing up, please file that as a bug.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Christian - 2007-07-03

status: open-works-for-me --> closed-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Elfring - 2007-07-03

Logged In: YES
user_id=572001
Originator: YES

I suggest to avoid unchecked function calls.
Would you like to detect every error situation as early as possible?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Elfring - 2007-07-03

status: closed-works-for-me --> open-later
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Christian - 2007-07-03

priority: 5 --> 1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Christian - 2007-07-03

Logged In: YES
user_id=865423
Originator: NO

What errors have you encountered?
I need a way to reproduce the problem.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Markus Elfring - 2007-07-03

Logged In: YES
user_id=572001
Originator: YES

Do you care for failed output and log messages?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.