mshell-users

[mShell-users] Patches for 1.1?

[Chris S. <ir0...@gm...>]

Hey Julien,

I've got a patch for the bug I logged for 1.1.  I looked for the 1.1
source in CVS but couldn't find it.  Should I just patch against the
src tarball?

Chris

--
Chris Sutcliffe
http://ir0nh34d.blogspot.com
http://emergedesktop.org

Re: [mShell-users] Patches for 1.1?

[Julien L. <ju...@fa...>]

Hello,

On 07/04/2006 21:11, Chris Sutcliffe wrote:
> I've got a patch for the bug I logged for 1.1.  I looked for the 1.1
> source in CVS but couldn't find it.  Should I just patch against the
> src tarball?

There's a new module called 'mShellEx' for the experimental build 
because I didn't want to start mangling the whole CVS. SF currently has 
problems with CVS (it was down for a couple of days) and hasn't yet put 
the sync back in CVS and WebCVS.

I noticed that bug only yesterday as it had never occurred before on my 
computer, and I'm interested in seeing where it comes from. You can send 
a patch against src tarball or CVS module.

Thanks a lot,
Julien

Re: [mShell-users] Patches for 1.1?

[Chris S. <ir0...@gm...>]

Hey,

> There's a new module called 'mShellEx' for the experimental build
> because I didn't want to start mangling the whole CVS. SF currently has
> problems with CVS (it was down for a couple of days) and hasn't yet put
> the sync back in CVS and WebCVS.

I'll snag it later on today from CVS.

> I noticed that bug only yesterday as it had never occurred before on my
> computer, and I'm interested in seeing where it comes from. You can send
> a patch against src tarball or CVS module.


Here's the scoop, in you code you have:

    132       ShowWindowAsync (lpProp->hTerminal, SW_SHOWNOACTIVATE);
    133       SetParent (lpProp->hTerminal, lpProp->hMdiChild);
    134       SetWindowLongPtr (lpProp->hTerminal, GWL_STYLE, WS_CHILD);
    135       SetWindowLongPtr (lpProp->hTerminal, GWL_EXSTYLE,
WS_EX_NOACTIVATE);

I moved the ShowWindow until after you capture the terminal window, as
I think it was related to a timing problem:

    133       SetParent (lpProp->hTerminal, lpProp->hMdiChild);
    134       SetWindowLongPtr (lpProp->hTerminal, GWL_STYLE, WS_CHILD);
    135       SetWindowLongPtr (lpProp->hTerminal, GWL_EXSTYLE,
WS_EX_NOACTIVATE);
    136       ShowWindow (lpProp->hTerminal, SW_SHOWNOACTIVATE);

It's not much of patch in terms of size, but if you would like me to
supply it in patch format, please let me know.

Cheers!

Chris

--
Chris Sutcliffe
http://ir0nh34d.blogspot.com
http://emergedesktop.org

Re: [mShell-users] Patches for 1.1?

[Julien L. <ju...@fa...>]

On 08/04/2006 18:03, Chris Sutcliffe wrote:
> Hey,
> 
> Here's the scoop, in you code you have:
> 
>     132       ShowWindowAsync (lpProp->hTerminal, SW_SHOWNOACTIVATE);
>     133       SetParent (lpProp->hTerminal, lpProp->hMdiChild);
>     134       SetWindowLongPtr (lpProp->hTerminal, GWL_STYLE, WS_CHILD);
>     135       SetWindowLongPtr (lpProp->hTerminal, GWL_EXSTYLE,
> WS_EX_NOACTIVATE);
> 
> I moved the ShowWindow until after you capture the terminal window, as
> I think it was related to a timing problem:
> 
>     133       SetParent (lpProp->hTerminal, lpProp->hMdiChild);
>     134       SetWindowLongPtr (lpProp->hTerminal, GWL_STYLE, WS_CHILD);
>     135       SetWindowLongPtr (lpProp->hTerminal, GWL_EXSTYLE,
> WS_EX_NOACTIVATE);
>     136       ShowWindow (lpProp->hTerminal, SW_SHOWNOACTIVATE);
> 
> It's not much of patch in terms of size, but if you would like me to
> supply it in patch format, please let me know.
> 

I've committed the change and gave you credits in the ChangeLog.
If the problem still arises, I think I'll have to add signal events in 
the rxvt source code, but I'm not fond of that.

Thanks,
Julien

Re: [mShell-users] Patches for 1.1?

[Chris S. <ir0...@gm...>]

Hey Julien,

> I've committed the change and gave you credits in the ChangeLog.
> If the problem still arises, I think I'll have to add signal events in
> the rxvt source code, but I'm not fond of that.

I can't check out mShellEx:

$ cvs -d:pserver:ano...@cv...:/cvsroot/mshell co mShellEx
cvs server: cannot find module `mShellEx' - ignored
cvs [checkout aborted]: cannot expand modules

I take it this related to the anonymous CVS issue you mentioned earlier...

Chris

--
Chris Sutcliffe
http://ir0nh34d.blogspot.com
http://emergedesktop.org

Re: [mShell-users] Patches for 1.1?

[Julien L. <ju...@fa...>]

On 11/04/2006 23:18, Chris Sutcliffe wrote:
> 
> I can't check out mShellEx:
> 
> $ cvs -d:pserver:ano...@cv...:/cvsroot/mshell co mShellEx
> cvs server: cannot find module `mShellEx' - ignored
> cvs [checkout aborted]: cannot expand modules

I have the same error when trying to check it out as pserver. With :ext: 
it works.

> I take it this related to the anonymous CVS issue you mentioned earlier...

Probably, since mShellEx doesn't even show up in WebCVS. I'll post a 
support request to the SF team to see if the CVS issue is fully fixed 
and keep you informed.