Re: [mShell-users] Patches for 1.1?

[Julien L. <ju...@fa...>]

On 08/04/2006 18:03, Chris Sutcliffe wrote:
> Hey,
> 
> Here's the scoop, in you code you have:
> 
>     132       ShowWindowAsync (lpProp->hTerminal, SW_SHOWNOACTIVATE);
>     133       SetParent (lpProp->hTerminal, lpProp->hMdiChild);
>     134       SetWindowLongPtr (lpProp->hTerminal, GWL_STYLE, WS_CHILD);
>     135       SetWindowLongPtr (lpProp->hTerminal, GWL_EXSTYLE,
> WS_EX_NOACTIVATE);
> 
> I moved the ShowWindow until after you capture the terminal window, as
> I think it was related to a timing problem:
> 
>     133       SetParent (lpProp->hTerminal, lpProp->hMdiChild);
>     134       SetWindowLongPtr (lpProp->hTerminal, GWL_STYLE, WS_CHILD);
>     135       SetWindowLongPtr (lpProp->hTerminal, GWL_EXSTYLE,
> WS_EX_NOACTIVATE);
>     136       ShowWindow (lpProp->hTerminal, SW_SHOWNOACTIVATE);
> 
> It's not much of patch in terms of size, but if you would like me to
> supply it in patch format, please let me know.
> 

I've committed the change and gave you credits in the ChangeLog.
If the problem still arises, I think I'll have to add signal events in 
the rxvt source code, but I'm not fond of that.

Thanks,
Julien