Re: [mShell-users] Patches for 1.1?

[Chris S. <ir0...@gm...>]

Hey,

> There's a new module called 'mShellEx' for the experimental build
> because I didn't want to start mangling the whole CVS. SF currently has
> problems with CVS (it was down for a couple of days) and hasn't yet put
> the sync back in CVS and WebCVS.

I'll snag it later on today from CVS.

> I noticed that bug only yesterday as it had never occurred before on my
> computer, and I'm interested in seeing where it comes from. You can send
> a patch against src tarball or CVS module.


Here's the scoop, in you code you have:

    132       ShowWindowAsync (lpProp->hTerminal, SW_SHOWNOACTIVATE);
    133       SetParent (lpProp->hTerminal, lpProp->hMdiChild);
    134       SetWindowLongPtr (lpProp->hTerminal, GWL_STYLE, WS_CHILD);
    135       SetWindowLongPtr (lpProp->hTerminal, GWL_EXSTYLE,
WS_EX_NOACTIVATE);

I moved the ShowWindow until after you capture the terminal window, as
I think it was related to a timing problem:

    133       SetParent (lpProp->hTerminal, lpProp->hMdiChild);
    134       SetWindowLongPtr (lpProp->hTerminal, GWL_STYLE, WS_CHILD);
    135       SetWindowLongPtr (lpProp->hTerminal, GWL_EXSTYLE,
WS_EX_NOACTIVATE);
    136       ShowWindow (lpProp->hTerminal, SW_SHOWNOACTIVATE);

It's not much of patch in terms of size, but if you would like me to
supply it in patch format, please let me know.

Cheers!

Chris

--
Chris Sutcliffe
http://ir0nh34d.blogspot.com
http://emergedesktop.org