#356 Can't reject approval bookings

open
nobody
None
1
2014-08-23
2013-06-11
Anonymous
No

Greetings from germany,

"approve" of a booking works fine, but "reject" or "more info" seems not to work correctly.

If i click on "reject" - no action - only a new site opens (/mrbs/view_entry.php?id=xxx) and show me the details of this booking (where i can change, delete, copy or export the entry) - the same like clicking on a booking as a user.

If i click on "more info" - the same like clicking on "reject" - a new site opens (/mrbs/view_entry.php?id=xxx) and show me the details of this booking (where i can change, delete, copy or export the entry) - the same like clicking on a booking as a user.

At the web i found this description, how the "reject" and "more info" button should work:
"Clicking on the Reject button will delete the entry in MRBS and send a rejection email to the originator. The admin will be presented with a screen so that they can insert their reason for rejection in the email.
Clicking on the More Info button will allow the administrator to send an email to the user asking for more information about the booking before an approve/reject decision can be made."

What i can do, to make the buttons work correctly ?

Thanks,
Mario

PS: Sorry for my bad english ;)

Discussion

  • Campbell Morrison

    Which version of MRBS are you using?

    Campbell

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-06-11

    The latest official version from the mrbs-homepage: 1.4.9

     
  • Campbell Morrison

    Sorry, this is a bug in 1.4.9. It works correctly in the latest code in the trunk if you want to download that from SVN.

    Campbell

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-06-12

    Ok, thanks - i'll try it !

    Do i have to completely reinstall mrbs or should i only overwrite the files with the new one from svn ?
    It's my first time of using svn...

     
    Last edit: Anonymous 2013-06-12
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-06-13

    I've updated to the newest SVN-Version (overwriting the files and updating the database), but the problem is the same...
    Click on "reject" does nothing than showing the booking information and "more info" also shows the booking information...
    The two buttons dont work correctly.

     
    Last edit: Anonymous 2013-06-13
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-06-20

    hallo again,

    is there a chance to get these buttons working ?
    or is there an older version, where the buttons work ?

     
  • Campbell Morrison

    I'm not quite sure what the problem is because I tested it myself and I can see the problem in 1.4.9 but it was OK in the trunk. Can you tell me (a) are you pressing Reject from the pending.php page or the view_entry.php page? and (b) what browser and version are you using?

    Thanks,

    Campbell

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-06-20

    a) from the pending.php - pressing "reject" loads the view_entry.php
    b) tested with google chrome 27 and internet explorer 8

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-07-16

    any new ideas, how to solve this problem ?
    could anybody test this and confirm the bug ?

     
  • Campbell Morrison

    I think the most likely explanation is that somehow you still have some old files that haven't been updated. I've just tested using the recently released 1.4.10 and everything works correctly - ie I cannot reproduce the bug (though I could with 1.4.9).

    Could you try installing 1.4.10 - ideally as a completely separate, new installation - and see if you have the problem.

    Thanks,

    Campbell

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-07-17

    Ok, i'll try the new version.

    Thanks,
    Mario

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-08-01

    I'm on 1.4.10, exact same issue.

     
  • Dalton

    Dalton - 2013-08-02

    Hi that last post was me. Tried to solve it on my own and i couldn't.

    The HTML for the "Reject" button is exactly the same as the "More Info" button. (<form action="view_entry.php?id-...) clearly it should be something else. I can't find where in the php files it needs to change nor do I know exactly what I would need to change it to.

     
  • Campbell Morrison

    I've just tried this and can't reproduce it - everything seems to work correctly. Have you got a clean 1.4.10 installation with all the files uploaded? Note that although the

    <form ...>
    

    lines are the same there are some hidden inputs in the HTML which specify the action.

    Campbell

     
    Last edit: Campbell Morrison 2013-08-05
  • Dalton

    Dalton - 2013-08-23

    Hi,

    Thanks for the response. I just tried again but it is now working fine >_< thanks anyways...

    I think it may have been that I didn't have email notifications set up the first time. Maybe that's your problem as well Mario?

    Dalton

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-08-29

    Hello,

    I also solved the problem with a clean installation of version 1.4.10
    Thanks alot for your help, Campbell !

    Greetings from germany
    Mario

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-09-12

    Hello,

    i must reactivate this topic :(
    after some testing, i've found out, that the reject button only works correct, if the first area in the list of areas has marked "Require bookings to be approved".
    if any other area has marked this entry, but not the first area, than the reject button dont work correct.

    Greetings, Mario

     
  • Campbell Morrison

    I'm struggling to reproduce this one. Can you tell me:

    (a) which version of MRBS you are using?
    (b) when you say the first area, do you mean the area with id=1, or do you mean the first in the drop-down list
    (c) have you set $approval_enabled in the config file?
    (d) when you say that the reject button does not work correctly, what exactly happens?
    (e) are you using the Reject button in view_entry.php or pending.php or both?

    Campbell

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-09-13

    Hello Campbell,

    (a) 1.4.10 - fresh install
    (b) the area with id=1 (but this is also the first in drop-down list)
    (c) the $approval_enabled entry does not exist in config.inc.php or systemdefaults.inc.php
    but i've inserted it with $approval_enabled = TRUE; but nothing happened
    (d) see the attachments
    (e) pending.php

    Mario

     
    Last edit: Anonymous 2013-09-13
  • Campbell Morrison

    Thanks for persevering with this one - I can now reproduce it and have fixed it in the trunk in Rev 2760. If you want to patch a 1.4.10 system then add the following lines to view_entry.php at line 124:

    $room = $row['room_id'];
    $area = $row['area_id'];
    

    ie just after the line

    $row = mrbsGetBookingInfo($id, $series);
    

    Campbell

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2013-09-13

    It seems to work ! :)
    I'll check this next week in the livesystem.

    thank you very much !

    Mario

     


Anonymous

Cancel  Add attachments





Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks