#259 After changing area in edit_entry.php, no room is selected

Minor
closed
None
1
2015-03-06
2013-02-01
Anonymous
No

After changing area in edit_entry.php, no room is selected, but it is still possible to save the booking. The action takes you back to the week/day view but no booking is actually saved.

This can be both confusing and misleading. I think that either the first room in the area should be selected, or edit_entry_handler should output an error so that the user knows he had done something wrong.

Discussion

  • Campbell Morrison

    Fixed in Rev 2671.

    Campbell

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous

    Anonymous - 2013-02-01

    That was quick!

    Still, a user can (un)intentionally deselect all rooms and "save" the booking.

    What do you think about the edit_entry_handler reporting this as an error, or at least making the field mandatory, such as is case with the brief description?

     
  • Campbell Morrison

    Good idea. And I'll also make the JavaScript/browser validation check as well.

    Campbell

     
  • Campbell Morrison

    Added in Rev 2673.

    Campbell

     
  • Campbell Morrison

    Added a further fix in Rev 2946. Fixed bug causing an HTML5 validation error when $auth['only_admin_can_select_multiroom'] = TRUE; ("required" is not necessary when "multiple" is not set).

     
  • John Beranek

    John Beranek - 2015-03-06
    • status: open --> closed
    • assigned_to: Campbell Morrison
     
  • John Beranek

    John Beranek - 2015-03-06

    Fixes available in a released version of MRBS (well, apart from the last one)

     

Anonymous
Anonymous

Cancel  Add attachments