Menu

Minor bug of displaying certains songs

Couin
2016-03-19
2016-03-29
  • Couin

    Couin - 2016-03-19

    Hi,

    A minor bug of displaying some songs in the player (not in the playlist) :
    For exemple, a song named 400 Hz - I've got the music in me, is displayed Hz - I've got the music in me
    But a song named 2 Pac California love is displayed well.
    After some tests, it seems that if the song name begins with at lest two numbers, , the numbers does not apperas on the player.

    Any idea ?
    Thanks :)

     
  • Couin

    Couin - 2016-03-19

    Hi ,

    I found a workaround, perhaps not the best but it seems to run.
    Just replace
    while((a[0]>='0' && a[0]<='9') || a[0]==' ') // skip numbers (tracknum) and spaces
    for
    while(a[0]==' ') // skip spaces
    in CHKENTRY.C at line 614.

    It runs in both cases of option 256 of desktop modes.

    See ya :)
    Couin

     

    Last edit: Couin 2016-03-19
  • Mpxplay

    Mpxplay - 2016-03-21

    There is a process at the ID3 tag handling, to convert file name parts to ID3 infos (if the file has no ID3 infos inside), including the track number at the begin of the filename. (NN. Artist - Title.mp3)
    It works properly at the 99.99% of the filenames, but there are some cases where this process fails (the result is false).
    I plan to do some fine tuning in this routine, but it has no high priority, and probably that case still stays incorrect.

    Create correct ID3 infos manually in this case (press F4, fill form, save datas).

     
  • Couin

    Couin - 2016-03-23

    Hi :)

    Yes, I supposed from the code that there was a convertion of filename to ID3, detecting if there is a track number at begin (at end too, if, I understood well).
    As well as I want to design the software especially for an mp3 reader for car, I don't need ID3 tags so none of any track has ID3.
    I just want that the 2x16 LCD (because there won't have no PC monitor) displays the filename (I have to find how to remove the extension).

    Thanks for your help and great software :)

     

    Last edit: Couin 2016-03-29
  • Couin

    Couin - 2016-03-29

    :) Found how to remove file extension from LCD :D
    If you are interrested, even if it's not the cleaner solution and you of course find it easier than me lol

    static char *create_item_filename(struct mainvars *mvp)
    {
     struct playlist_entry_info *pei=mvp->psie->editorhighline;
     char *fname=pds_getfilename_from_fullname(pei->filename),*ext,dest[255];;
     int i=0,j=0,k=0;
     if((pei->entrytype&(DFTM_DFT|DFTM_DRIVE))==(DFTM_DFT|DFTM_DRIVE))
      return pei->filename;
    
     ext=pds_strrchr(fname,'.'); // cut file extension
      if(!ext)
         j=0;
     else { 
           for(j=0;ext[j]!='\0';j++){
           }
     }
    
       for(i=0;fname[i]!='\0';i++){
           }
    
        k=i-j;
    
        strncpy(dest, fname, k); 
        dest[k] = '\0';
    return dest;
    }
    

    Of course, same mod with p_filename item :)
    See ya :)

     

    Last edit: Couin 2016-03-29

Log in to post a comment.