Menu

#86 FilterCriteria not being read in properly

closed-fixed
Jon Iles
None
5
2009-05-19
2009-05-14
No

For filter critiera (atleast in MPP12) there is a distinction between the two variety of 'AND' (0x19 and 0x1B) and the two variety of 'OR' (0x1A and 0x1C).

MSP allows the criteria to be grouped into blocks. 0x19 and 0x1A are used within a block. 0x1B and 0x1C are used between blocks. The following two filters are possible (and different):

(1) A and (B or NOT B)
==> A (0x1B) B (0x1A) NOT B

(2) A and B or NOT B
==> A (0x19) B (0x1A) NOT B

In MS Project filter (2) will always evaluate to true. Filter (1) is equivalent to just checking whether criteria A is true.

Currently MPXJ does not deal with 0x1B or 0x1C correctly. (It uses their in block varients)

Discussion

  • James Styles

    James Styles - 2009-05-14

    Unit test showing the bug. Uses attatched MPP file.

     
  • James Styles

    James Styles - 2009-05-14

    MPP file containing a filter that isn't read correctly.

     
  • James Styles

    James Styles - 2009-05-14

    quick hack of a fix

     
  • James Styles

    James Styles - 2009-05-14

    quick hack of a fix

     
  • James Styles

    James Styles - 2009-05-14

    quick hack of a fix

     
  • James Styles

    James Styles - 2009-05-14

    Added a unit test for the bug and a quick change that fixes it.

     
  • Jon Iles

    Jon Iles - 2009-05-19
    • assigned_to: nobody --> joniles
     
  • Jon Iles

    Jon Iles - 2009-05-19
    • status: open --> closed-fixed
     
  • Jon Iles

    Jon Iles - 2009-05-19

    Hi,

    I've integrated your suggested changes into the code now in CVS. Thanks for the contribution!

    Jon

     

Log in to post a comment.