#273 PrimaveraPMFileWriter throws Exception at write(..)

[Raimund Neumüller]

PrimaveraPMFileWriter throws exception in getDuration (environment: .NET / Visual Studio 2012)
MPXJ version 5.15

Example: I modified the sample "MpxjConvert"

        AbstractProjectReader reader = new net.sf.mpxj.primavera.PrimaveraXERFileReader();
        ProjectFile projectFile = reader.read(inputFile);
        net.sf.mpxj.primavera.PrimaveraPMFileWriter writer = new net.sf.mpxj.primavera.PrimaveraPMFileWriter();
        writer.write(projectFile, outputFile);

File created is empty, because in writer.write occurs an exception. it seems that in PrimaveraPMFileWriter.getDuration some object is null:

    ex.ToString()   "System.NullReferenceException: Object reference not set to an instance of an object.\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.getDuration(Duration )\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.writeActivity(Task )\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.writeTask(Task )\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.writeTasks()\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.write(ProjectFile projectFile, OutputStream stream)\r\n   at net.sf.mpxj.writer.AbstractProjectWriter.write(ProjectFile projectFile, String fileName)\r\n   at MpxjQuery.MpxjQuery.LoadTestExport(Int32 iterations) in d:\\Local\\3rdParty\\mpxj\\src.net\\MpxjQuery\\MpxjQuery.cs:line 115\r\n   at MpxjQuery.MpxjQuery.Main(String[] args) in d:\\Local\\3rdParty\\mpxj\\src.net\\MpxjQuery\\MpxjQuery.cs:line 19"   string
    [System.NullReferenceException] = {"Object reference not set to an instance of an object."}     
    Source = "mpxj-for-csharp"      
    StackTrace = "   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.getDuration(Duration )\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.writeActivity(Task )\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.writeTask(Task )\r\n   at net.sf.mpxj.primavera.Primaver...
    TargetSite = {java.lang.Double getDuration(net.sf.mpxj.Duration)}

I also tried to manually create a Task and set all fields that seems to be connected with Duration, but still the exception occurs in write

            durationUnit = TimeUnit.HOURS;
            targetTask.Duration = Duration.getInstance(dDuration, durationUnit);
            targetTask.ActualDuration = Duration.getInstance(dDuration, durationUnit);
            targetTask.Work = Duration.getInstance(dDuration, durationUnit);
            targetTask.DurationVariance = Duration.getInstance(0, durationUnit);
            targetTask.DurationText = targetTask.Duration.toString();
            targetTask.ActualWork = Duration.getInstance(dDuration, durationUnit);

Which property should be set as well? or maybe the File writer should not crash if any property is null, just take a default value (0) ?

[Jon Iles]

Hi,

can you provide the example XER file you used with your modified version of MpxjConvert so I can try to reproduce the issue?

Thanks

Jon

[Raimund Neumüller]

Hi Jon,

I send you the XER file I tried it with.

But it not depends on the input file, I also tried a different example where I create 1 task and export it, again with Ms Project Writer it works, but with Primavera Writer it crashes because some “Duration” field is not set. Maybe I use the wrong constructor or I need a factory method?

class MpxjQuery
{
    /// <summary>
    /// Main entry point.
    /// </summary>
    /// <param name="args">command line arguments</param>
    static void Main(string[] args)
    {
        try
        {
            LoadTestExport(1);
            //query(@"C:\Users\neumuell\Documents\Sample Xer 01.xer");
            Console.ReadLine();
            return;

            if (args.Length != 1)
            {
                System.Console.WriteLine("Usage: MpxQuery <input file name>");
            }
            else
            {
                query(args[0]);

                Console.ReadLine();
            }
        }

        catch (Exception ex)
        {
            System.Console.WriteLine(ex.StackTrace);
        }

    }

    // [rne] 18.05.2015
    private static void LoadTestExport(int iterations)
    {
        System.Console.WriteLine("GetProjectWriter ...");

        string outputFile = @"C:\Users\neumuell\Documents\test2_mpxj_primavera_PM.xml";
        ProjectFile targetFile = new ProjectFile();

        DateTime dtBefore, dtAfter;
        dtBefore = DateTime.Now;
        AbstractProjectWriter writer = null;
        //writer = ProjectWriterUtility.getProjectWriter(outputFile) as AbstractProjectWriter;
        writer = new net.sf.mpxj.primavera.PrimaveraPMFileWriter();

        dtAfter = DateTime.Now;
        System.Console.WriteLine("Time (s): " + dtAfter.Subtract(dtBefore).TotalSeconds);
        System.Console.WriteLine("Building structure ...");
        dtBefore = DateTime.Now;

        DateTime dtStart;
        DateTime dtFinish;
        double dDuration;
        TimeUnit durationUnit;

        dtStart = DateTime.Now.Date;
        dtFinish = dtStart.AddDays(1);
        Random random = new Random();
        Task previousTask = null;

        for (int i = 1; i <= iterations; i++)
        {
            Task targetTask = targetFile.AddTask();
            //string strTask = "Task: " + task.Name + " ID=" + task.ID + " Unique ID=" + task.UniqueID + " RemaType=" + (remaType != null ? remaType : "<null>") + " SystemUID=" + (systemUID != null ? systemUID : "<null>") + " (Start Date=" + startDate + " Finish Date=" + finishDate + " Duration=" + duration + " Outline Level=" + task.OutlineLevel + "), predecessors: " + (task.Predecessors != null ? task.Predecessors.ToString() : "") + ", successors: " + (task.Successors != null ? task.Successors.ToString() : "");

            targetTask.Name = i.ToString();
            targetTask.ID = java.lang.Integer.getInteger("", i);
            targetTask.UniqueID = java.lang.Integer.getInteger("", i);
            //targetTask.OutlineLevel = task.OutlineLevel;

            targetTask.Start = dtStart.ToJavaDate();
            targetTask.Finish = dtFinish.ToJavaDate();

            dDuration = 8;
            durationUnit = TimeUnit.HOURS;
            targetTask.Duration = Duration.getInstance(dDuration, durationUnit);

            targetTask.Set(TaskField.TEXT1, "REMATASK");
            targetTask.Set(TaskField.TEXT2, "AB" + i.ToString("00000"));

            targetTask.ActualDuration = Duration.getInstance(dDuration, durationUnit);
            targetTask.Work = Duration.getInstance(dDuration, durationUnit);
            targetTask.DurationVariance = Duration.getInstance(0, durationUnit);
            targetTask.DurationText = targetTask.Duration.toString();
            targetTask.ActualWork = Duration.getInstance(dDuration, durationUnit);
            //Duration dTest = targetTask.GetDuration(1);
            double dTest = targetTask.Duration.Duration;

            // test dependencies
            if (previousTask != null)
            {
                targetTask.AddPredecessor(previousTask, RelationType.FINISH_START, Duration.getInstance(0, TimeUnit.HOURS));
            }

            previousTask = targetTask;

            //dtStart = new DateTime(2015, random.Next(1, 12), random.Next(1, 28));
            //dtFinish = dtStart.AddDays(1);
        }

        dtAfter = DateTime.Now;
        System.Console.WriteLine("Time (s): " + dtAfter.Subtract(dtBefore).TotalSeconds);
        System.Console.WriteLine("Writing file ...");
        dtBefore = DateTime.Now;
        writer.write(targetFile, outputFile);
        dtAfter = DateTime.Now;
        System.Console.WriteLine("Time (s): " + dtAfter.Subtract(dtBefore).TotalSeconds);
        System.Console.WriteLine("Done");
    }

From: Jon Iles [mailto:joniles@users.sf.net]
Sent: Sonntag, 30. August 2015 04:11
To: [mpxj:bugs]
Subject: [mpxj:bugs] #273 PrimaveraPMFileWriter throws Exception at write(..)

Hi,

can you provide the example XER file you used with your modified version of MpxjConvert so I can try to reproduce the issue?

Thanks

Jon

---

[bugs:#273]http://sourceforge.net/p/mpxj/bugs/273/ PrimaveraPMFileWriter throws Exception at write(..)

Status: open
Group: v1.0_(example)
Labels: Primavera
Created: Wed Aug 26, 2015 02:48 PM UTC by Raimund Neumüller
Last Updated: Wed Aug 26, 2015 02:48 PM UTC
Owner: Jon Iles
Attachments:

• primavera_writer_exception.pnghttps://sourceforge.net/p/mpxj/bugs/273/attachment/primavera_writer_exception.png (113.2 kB; image/png)

PrimaveraPMFileWriter throws exception in getDuration (environment: .NET / Visual Studio 2012)
MPXJ version 5.15

Example: I modified the sample "MpxjConvert"

    AbstractProjectReader reader = new net.sf.mpxj.primavera.PrimaveraXERFileReader();

    ProjectFile projectFile = reader.read(inputFile);

    net.sf.mpxj.primavera.PrimaveraPMFileWriter writer = new net.sf.mpxj.primavera.PrimaveraPMFileWriter();

    writer.write(projectFile, outputFile);

File created is empty, because in writer.write occurs an exception. it seems that in PrimaveraPMFileWriter.getDuration some object is null:

ex.ToString()   "System.NullReferenceException: Object reference not set to an instance of an object.\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.getDuration(Duration )\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.writeActivity(Task )\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.writeTask(Task )\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.writeTasks()\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.write(ProjectFile projectFile, OutputStream stream)\r\n   at net.sf.mpxj.writer.AbstractProjectWriter.write(ProjectFile projectFile, String fileName)\r\n   at MpxjQuery.MpxjQuery.LoadTestExport(Int32 iterations) in d:\\Local\\3rdParty\\mpxj\\src.net\\MpxjQuery\\MpxjQuery.cs:line 115\r\n   at MpxjQuery.MpxjQuery.Main(String[] args) in d:\\Local\\3rdParty\\mpxj\\src.net\\MpxjQuery\\MpxjQuery.cs:line 19"   string

[System.NullReferenceException] = {"Object reference not set to an instance of an object."}

Source = "mpxj-for-csharp"

StackTrace = "   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.getDuration(Duration )\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.writeActivity(Task )\r\n   at net.sf.mpxj.primavera.PrimaveraPMFileWriter.writeTask(Task )\r\n   at net.sf.mpxj.primavera.Primaver...

TargetSite = {java.lang.Double getDuration(net.sf.mpxj.Duration)}

I also tried to manually create a Task and set all fields that seems to be connected with Duration, but still the exception occurs in write

        durationUnit = TimeUnit.HOURS;

        targetTask.Duration = Duration.getInstance(dDuration, durationUnit);

        targetTask.ActualDuration = Duration.getInstance(dDuration, durationUnit);

        targetTask.Work = Duration.getInstance(dDuration, durationUnit);

        targetTask.DurationVariance = Duration.getInstance(0, durationUnit);

        targetTask.DurationText = targetTask.Duration.toString();

        targetTask.ActualWork = Duration.getInstance(dDuration, durationUnit);

Which property should be set as well? or maybe the File writer should not crash if any property is null, just take a default value (0) ?

---

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/mpxj/bugs/273/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

---

Siemens Industry Software GmbH; Sitz der Gesellschaft: Wolfgang-Pauli-Strasse 2, A-4020 Linz, Österreich
Firmenbuchnummer: FN 214676 a; Firmenbuchgericht: Handelsgericht Linz

[Raimund Neumüller]

Hello Jon,
here is the sample xer

But it not depends on the input file, I also tried a different example where I create 1 task and export it, again with Ms Project Writer it works, but with Primavera Writer it crashes because some “Duration” field is not set. Maybe I use the wrong constructor or I need a factory method?

class MpxjQuery
{
    /// <summary>
    /// Main entry point.
    /// </summary>
    /// <param name="args">command line arguments</param>
    static void Main(string[] args)
    {
        try
        {
            LoadTestExport(1);
            //query(@"C:\Users\neumuell\Documents\Sample Xer 01.xer");
            Console.ReadLine();
            return;

            if (args.Length != 1)
            {
                System.Console.WriteLine("Usage: MpxQuery <input file name>");
            }
            else
            {
                query(args[0]);

                Console.ReadLine();
            }
        }

        catch (Exception ex)
        {
            System.Console.WriteLine(ex.StackTrace);
        }

    }

    // [rne] 18.05.2015
    private static void LoadTestExport(int iterations)
    {
        System.Console.WriteLine("GetProjectWriter ...");

        string outputFile = @"C:\Users\neumuell\Documents\test2_mpxj_primavera_PM.xml";
        ProjectFile targetFile = new ProjectFile();

        DateTime dtBefore, dtAfter;
        dtBefore = DateTime.Now;
        AbstractProjectWriter writer = null;
        //writer = ProjectWriterUtility.getProjectWriter(outputFile) as AbstractProjectWriter;
        writer = new net.sf.mpxj.primavera.PrimaveraPMFileWriter();

        dtAfter = DateTime.Now;
        System.Console.WriteLine("Time (s): " + dtAfter.Subtract(dtBefore).TotalSeconds);
        System.Console.WriteLine("Building structure ...");
        dtBefore = DateTime.Now;

        DateTime dtStart;
        DateTime dtFinish;
        double dDuration;
        TimeUnit durationUnit;

        dtStart = DateTime.Now.Date;
        dtFinish = dtStart.AddDays(1);
        Random random = new Random();
        Task previousTask = null;

        for (int i = 1; i <= iterations; i++)
        {
            Task targetTask = targetFile.AddTask();
            //string strTask = "Task: " + task.Name + " ID=" + task.ID + " Unique ID=" + task.UniqueID + " RemaType=" + (remaType != null ? remaType : "<null>") + " SystemUID=" + (systemUID != null ? systemUID : "<null>") + " (Start Date=" + startDate + " Finish Date=" + finishDate + " Duration=" + duration + " Outline Level=" + task.OutlineLevel + "), predecessors: " + (task.Predecessors != null ? task.Predecessors.ToString() : "") + ", successors: " + (task.Successors != null ? task.Successors.ToString() : "");

            targetTask.Name = i.ToString();
            targetTask.ID = java.lang.Integer.getInteger("", i);
            targetTask.UniqueID = java.lang.Integer.getInteger("", i);
            //targetTask.OutlineLevel = task.OutlineLevel;

            targetTask.Start = dtStart.ToJavaDate();
            targetTask.Finish = dtFinish.ToJavaDate();

            dDuration = 8;
            durationUnit = TimeUnit.HOURS;
            targetTask.Duration = Duration.getInstance(dDuration, durationUnit);

            targetTask.Set(TaskField.TEXT1, "REMATASK");
            targetTask.Set(TaskField.TEXT2, "AB" + i.ToString("00000"));

            targetTask.ActualDuration = Duration.getInstance(dDuration, durationUnit);
            targetTask.Work = Duration.getInstance(dDuration, durationUnit);
            targetTask.DurationVariance = Duration.getInstance(0, durationUnit);
            targetTask.DurationText = targetTask.Duration.toString();
            targetTask.ActualWork = Duration.getInstance(dDuration, durationUnit);
            //Duration dTest = targetTask.GetDuration(1);
            double dTest = targetTask.Duration.Duration;

            // test dependencies
            if (previousTask != null)
            {
                targetTask.AddPredecessor(previousTask, RelationType.FINISH_START, Duration.getInstance(0, TimeUnit.HOURS));
            }

            previousTask = targetTask;

            //dtStart = new DateTime(2015, random.Next(1, 12), random.Next(1, 28));
            //dtFinish = dtStart.AddDays(1);
        }

        dtAfter = DateTime.Now;
        System.Console.WriteLine("Time (s): " + dtAfter.Subtract(dtBefore).TotalSeconds);
        System.Console.WriteLine("Writing file ...");
        dtBefore = DateTime.Now;
        writer.write(targetFile, outputFile);
        dtAfter = DateTime.Now;
        System.Console.WriteLine("Time (s): " + dtAfter.Subtract(dtBefore).TotalSeconds);
        System.Console.WriteLine("Done");
    }

[Raimund Neumüller]

Hello Jon,

we tried it out in Java with our example with 1 Task, and my collegue modified PrimaveraPMFileWriter so, that it returns a default value (0.0) if a duration is null. But we don’t know if this always delivers a correct output for Primavera.
With our modification we could generate a primavera xml (see attachment)

PrimaveraPMFileWriter.java
Function getDuration:

/**

• Retrieve a duration in the form required by Primavera.
  *
• @param duration Duration instance

• @return formatted duration
  */
  private Double getDuration(Duration duration) {

  // kgo add null pointer check
  if (duration == null) {
  return 0.0;
  }
  // end kgo

  if (duration.getUnits() != TimeUnit.HOURS) {
  duration = duration.convertUnits(TimeUnit.HOURS, m_projectFile.getProjectProperties());
  }

  return Double.valueOf(duration.getDuration());
  }

[Raimund Neumüller]

I found out that "RemainingDuration" was the missing value in the task which caused the null pointer exception.. obviously it was not set during the import of my XER file
If I set something in RemainingDuration, for example:
.NET : targetTask.RemainingDuration = targetTask.Work;
Java: targetTask.setRemainingDuration(targetTask.getDuration());

then the Primavera Writer runs through and export works
Maybe there should be a default value set for RemainingDuration?

[Jon Iles]

This issue is fixed by the code now in git.