#224 [4.4.0] setMilestone() issue

[Arcady Zherdev]

MPXJ ver.4.4.0 incorrectly processes the attached file.
It mistakenly considers all its tasks as milestones.

I've made debugging and it looks like for attached file MS used another file format yet it still declared as MSProject 14.
I've made pretty simple patch and it looks working now. I've modified MPP14Reader class processTaskData() method this way:

        // HACK: if we have following bytes less than zero
        // then M$ uses another format version
        if (metaData[9] < 0 && metaData[10] < 0) {
            task.setMilestone((metaData[10] & 2) != 0);
        } else {
            task.setMilestone((metaData[8] & 0x20) != 0);
        }

[Tiberiu]

The provided fix indeed solves the milestone problem.

Tibi

[Alex]

Likewise - all the tasks are also have Roll-up flag set to True.
The following change to the above code fixes that too:

 // HACK: if we have following bytes less than zero then MS uses another format version
     if (metaData[9] < 0 && metaData[10] < 0) {
         task.setMilestone((metaData[10] & 2) != 0);
         task.setRollup((metaData[12] & 0x08) != 0);
     } else {
         task.setMilestone((metaData[8] & 0x20) != 0);
         task.setRollup((metaData[10] & 0x08) != 0);
     }

[Jon Iles]

This issue is now fixed by the latest code in Git - note the change in version control system!