mpls-linux-general

[mpls-linux-general] Maybe I can try

[<m9...@cn...>]

Hi James,

I think if I can I will try to make these changes.

But the code for me is big, and there are some data structure I don't =
understand, for example "struct interface" and "struct ldp_interface".

What data structures I should dig and understand when I am tracing the =
source code?

Does the labelspace finally write to the kernel somewhere?

Thanks

Timothy
2005.03.29

----- Original Message -----=20
From: "James R. Leu" <jl...@mi...>
To: "Timothy(???x)" <m9...@cn...>
Cc: <mpl...@li...>
Sent: Saturday, March 26, 2005 12:41 AM
Subject: Re: [mpls-linux-general] May I ask you a questions about =
labelspace

Very good point.  The ldpd labelspace CLI is cruft leftover from
quagga-ldp.  It should be removed.

The correct place to configure labelspace is in zebra.  Ofcourse we
need make sure that setting a labelspace in zebra causes the right mesg
to be sent to ldpd.

Would you like to try making these changes and send me a patch?

On Fri, Mar 25, 2005 at 02:47:37PM +0800, Timothy\(???x\) wrote:
> Hi James,
>=20
> May I ask you a questions about labelspace?
>=20
> What's the different between we config labelspace through zebra CLI =
and ldpd CLI? I mean it seems I can config the labelspace through zebra =
CLI and through ldpd CLI? But there should be something different? I am =
not so sure, please correct me, thanks.
>=20
>=20
> Best Regards
>=20
> Timothy
> 2005.03.25
--=20
James R. Leu
jl...@mi...

Re: [mpls-linux-general] Maybe I can try

[James R. L. <jl...@mi...>]

On Tue, Mar 29, 2005 at 09:19:11PM +0800, Timothy\(???x\) wrote:
> Hi James,
>=20
> I think if I can I will try to make these changes.
>=20
> But the code for me is big, and there are some data structure I don't und=
erstand, for example "struct interface" and "struct ldp_interface".
>=20
> What data structures I should dig and understand when I am tracing the so=
urce code?
>=20
> Does the labelspace finally write to the kernel somewhere?

Yes.  The zebra daemon does that.  I would start by looking at the code
in zebra.  Specifically mpls_vty.c and mpls_lib.c

When the user sets the labelspace via the zebra CLI it sends a message to
the ldpd daemon informing it about the new labelspace.  ldpd should not
be allowed to set the labelspace, it should only accept labelspace messages
from zebra.

Try digging around a little.  If you have difficulty making progress
let me know and I'll provide more specific code references.

>=20
> Thanks
>=20
> Timothy
> 2005.03.29
>=20
> ----- Original Message -----=20
> From: "James R. Leu" <jl...@mi...>
> To: "Timothy(???x)" <m9...@cn...>
> Cc: <mpl...@li...>
> Sent: Saturday, March 26, 2005 12:41 AM
> Subject: Re: [mpls-linux-general] May I ask you a questions about labelsp=
ace
>=20
> Very good point.  The ldpd labelspace CLI is cruft leftover from
> quagga-ldp.  It should be removed.
>=20
> The correct place to configure labelspace is in zebra.  Ofcourse we
> need make sure that setting a labelspace in zebra causes the right mesg
> to be sent to ldpd.
>=20
> Would you like to try making these changes and send me a patch?
>=20
> On Fri, Mar 25, 2005 at 02:47:37PM +0800, Timothy\(???x\) wrote:
> > Hi James,
> >=20
> > May I ask you a questions about labelspace?
> >=20
> > What's the different between we config labelspace through zebra CLI and=
 ldpd CLI? I mean it seems I can config the labelspace through zebra CLI an=
d through ldpd CLI? But there should be something different? I am not so su=
re, please correct me, thanks.
> >=20
> >=20
> > Best Regards
> >=20
> > Timothy
> > 2005.03.25
> --=20
> James R. Leu
> jl...@mi...

--=20
James R. Leu
jl...@mi...