mpls-linux-devel

[mpls-linux-devel] Hi all

[Ramon C. <cas...@in...>]

I've started some changes, but the current version does not compile:
net/ipv4/fib_semantics.c: In function `fib_nh_match':
net/ipv4/fib_semantics.c:351: error: `nhl' undeclared (first use in this 
function)
net/ipv4/fib_semantics.c:351: error: (Each undeclared identifier is 
reported only once
net/ipv4/fib_semantics.c:351: error: for each function it appears in.)
make[2]: *** [net/ipv4/fib_semantics.o] Error 1
make[1]: *** [net/ipv4] Error 2

Looks like a trivial fix:
#ifdef CONFIG_NET_MPLS
                        gw = fib_get_attr32(RTNH_DATA(nhl), attrlen, 
RTA_MPLS_FEC);
                        if (gw && gw != nh->nh_mpls_fec)
                                return 1;
#endif

but I wonder Jamal, did you compile it before sending the patch ? :)

regards,
R.



// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// Ramon Casellas - GET/ENST/INFRES/RHD/A508 - cas...@in...
// Tel: +33 (0)1 45 81 75 88                 Fax: +33 (0)1 45 81 71 58
// 37/39 rue Dareau 75014 Paris   --    http://perso.enst.fr/~casellas

Re: [mpls-linux-devel] Hi all

[Jamal H. S. <ha...@zn...>]

Hi guys,

didnt mean to desert you - things have been extremely hectic. Still are
(both at work and home). So i hope you wont mind me being intermittent.
I will try my best to respond when i believe its high priority like in
this case.

Scary - It compiles just fine for me.

Substitute that nhl to be nhp - its what it should be.

------
[root@jzny 261-mod]# gcc -v
Reading specs from /usr/lib/gcc-lib/i386-conectiva-linux/3.2.2/specs
Configured with: /usr/src/rpm/BUILD/gcc-3.2.2/configure --prefix=/usr
--bindir=/usr/bin --libdir=/usr/lib --mandir=/usr/share/man
--infodir=/usr/share/info --datadir=/usr/share --enable-shared
--enable-threads=posix --enable-haifa --enable-libgcj
--enable-languages=c,c++,f77,objc,java --with-system-zlib
--with-gxx_include_dir=/usr/include/c++/3.2.2
--host=i386-conectiva-linux
Thread model: posix
gcc version 3.2.2
---------

I susbtituted that nhl with nhx and it still compiled.
Now i am thinking that the code is not being hit; so i substitute with:

-----
..
..
#ifdef CONFIG_NET_MPLS
#error  "testing CONFIG_NET_MPLS"
                        //gw = fib_get_attr32(RTNH_DATA(nhx), attrlen,
RTA_MPLS_FEC);
                        //if (gw && gw != nh->nh_mpls_fec)
                        //      return 1;
#end
...
...
----------

and the compile doesnt bail out.
Why did yours work?
Can you replace with the above #error and see if still compiles?

cheers,
jamal

On Mon, 2004-02-23 at 05:25, Ramon Casellas wrote:
> I've started some changes, but the current version does not compile:
> net/ipv4/fib_semantics.c: In function `fib_nh_match':
> net/ipv4/fib_semantics.c:351: error: `nhl' undeclared (first use in this 
> function)
> net/ipv4/fib_semantics.c:351: error: (Each undeclared identifier is 
> reported only once
> net/ipv4/fib_semantics.c:351: error: for each function it appears in.)
> make[2]: *** [net/ipv4/fib_semantics.o] Error 1
> make[1]: *** [net/ipv4] Error 2
> 
> Looks like a trivial fix:
> #ifdef CONFIG_NET_MPLS
>                         gw = fib_get_attr32(RTNH_DATA(nhl), attrlen, 
> RTA_MPLS_FEC);
>                         if (gw && gw != nh->nh_mpls_fec)
>                                 return 1;
> #endif
> 
> but I wonder Jamal, did you compile it before sending the patch ? :)
> 
> regards,
> R.
> 
> 
> 
> // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> // Ramon Casellas - GET/ENST/INFRES/RHD/A508 - cas...@in...
> // Tel: +33 (0)1 45 81 75 88                 Fax: +33 (0)1 45 81 71 58
> // 37/39 rue Dareau 75014 Paris   --    http://perso.enst.fr/~casellas
> 
> 
> -------------------------------------------------------
> SF.Net is sponsored by: Speed Start Your Linux Apps Now.
> Build and deploy apps & Web services for Linux with
> a free DVD software kit from IBM. Click Now!
> http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
> _______________________________________________
> mpls-linux-devel mailing list
> mpl...@li...
> https://lists.sourceforge.net/lists/listinfo/mpls-linux-devel

Re: [mpls-linux-devel] Hi all

[Ramon C. <cas...@in...>]

On 23 Feb 2004, Jamal Hadi Salim wrote:

> didnt mean to desert you - things have been extremely hectic. Still are
> (both at work and home). So i hope you wont mind me being intermittent.
> I will try my best to respond when i believe its high priority like in
> this case.

I understand... I will also have some other projects that may impact my
productivity :)


>
> Scary - It compiles just fine for me.

Uhm...


> Substitute that nhl to be nhp - its what it should be.

Well, I _know_ that :)



> ------
> [root@jzny 261-mod]# gcc -v

gandalf casellas$ gcc -v
Reading specs from /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.3/specs
Configured with: /var/tmp/portage/gcc-3.3.3/work/gcc-3.3.3/configure
--prefix=/usr --bindir=/usr/i686-pc-linux-gnu/gcc-bin/3.3
--includedir=/usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.3/include
--datadir=/usr/share/gcc-data/i686-pc-linux-gnu/3.3
--mandir=/usr/share/gcc-data/i686-pc-linux-gnu/3.3/man
--infodir=/usr/share/gcc-data/i686-pc-linux-gnu/3.3/info --enable-shared
--host=i686-pc-linux-gnu --target=i686-pc-linux-gnu --with-system-zlib
--enable-languages=c,c++,f77,objc,java --enable-threads=posix
--enable-long-long --disable-checking --enable-cstdio=stdio
--enable-clocale=generic --enable-__cxa_atexit
--enable-version-specific-runtime-libs
--with-gxx-include-dir=/usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.3/include/g++-v3
--with-local-prefix=/usr/local --enable-shared --enable-nls
--without-included-gettext --x-includes=/usr/X11R6/include
--x-libraries=/usr/X11R6/lib --enable-interpreter --enable-java-awt=xlib
--with-x --disable-multilib
Thread model: posix
gcc version 3.3.3 20040217


>
> I susbtituted that nhl with nhx and it still compiled.

gandalf mpls-kernel-davem# grep -bn MPLS .config
583:12615:CONFIG_IP_MPLS=y
603:12997:CONFIG_INET6_MPLS=m
706:15439:CONFIG_NET_MPLS=y


> ...
> Why did yours work?

What happens in your tree if you put a #error directive in other parts of
the file/other files? I'm afraid that you just did not compile MPLS
support in...




> Can you replace with the above #error and see if still compiles?

  CC      net/ipv4/fib_semantics.o
net/ipv4/fib_semantics.c:351:2: #error "I bet this month salary that this
message is displayed"
make[2]: *** [net/ipv4/fib_semantics.o] Error 1
make[1]: *** [net/ipv4] Error 2
make: *** [net] Error 2


Well, what did you expect ? :))



Update:
******
Nahhh, I bet 'today salary' that you do not have CONFIG_IP_ROUTE_MULTIPATH
.that would explain it... :)


Other things that I will cleanup (as soon as James server is online)
net/mpls/mpls_fib.c: In function `mpls_ilm_lookup':
net/mpls/mpls_fib.c:212: warning: ISO C90 forbids mixed declarations and
code
net/mpls/mpls_fib.c: In function `lt_fill_ilm':
net/mpls/mpls_fib.c:340: warning: implicit declaration of function
`gen_copy_stats'
net/mpls/mpls_fib.c: In function `mpls_get_ilm':
net/mpls/mpls_fib.c:446: warning: unused variable `lt'
net/mpls/mpls_fib.c:447: warning: unused variable `i'
net/netlink/af_netlink.c: In function `netlink_proto_init':
net/netlink/af_netlink.c:1136: warning: implicit declaration of function
`l2cnetlink_init'



Regards,
R.

Re: [mpls-linux-devel] Hi all

[Jamal H. S. <ha...@zn...>]

On Mon, 2004-02-23 at 07:43, Ramon Casellas wrote:

[..]

> 
> Update:
> ******
> Nahhh, I bet 'today salary' that you do not have CONFIG_IP_ROUTE_MULTIPATH
> .that would explain it... :)

Ok you can have this months salary because this is the main reason
it wasnt compiling ;->
Note, I did not test multi path.

> Other things that I will cleanup (as soon as James server is online)
> net/mpls/mpls_fib.c: In function `mpls_ilm_lookup':
> net/mpls/mpls_fib.c:212: warning: ISO C90 forbids mixed declarations and
> code
> net/mpls/mpls_fib.c: In function `lt_fill_ilm':
> net/mpls/mpls_fib.c:340: warning: implicit declaration of function
> `gen_copy_stats'
> net/mpls/mpls_fib.c: In function `mpls_get_ilm':
> net/mpls/mpls_fib.c:446: warning: unused variable `lt'
> net/mpls/mpls_fib.c:447: warning: unused variable `i'
> net/netlink/af_netlink.c: In function `netlink_proto_init':
> net/netlink/af_netlink.c:1136: warning: implicit declaration of function
> `l2cnetlink_init'
> 

Sounds reasonable. Did you end up changing the fecid variable as well?
It seems to me a global search and replace on the patch itself would be
the best option. Then you apply the patch.

cheers,
jamal

Re: [mpls-linux-devel] Hi all

[Ramon C. <cas...@in...>]

On 23 Feb 2004, Jamal Hadi Salim wrote:

> On Mon, 2004-02-23 at 07:43, Ramon Casellas wrote:
>
> [..]


> Sounds reasonable. Did you end up changing the fecid variable as well?

Yes it's almost done. I'll submit the changeset today.


> It seems to me a global search and replace on the patch itself would be
> the best option. Then you apply the patch.

Umm, since the code is now in James' p4 repo. (not that there have been a
lot of changes, though) I think I'll stick to p4

Thanks,

R.