Re: [mpls-linux-general] bug report

[James R. L. <jl...@mi...>]

Hello,

Good stuff.  I'll look into these corner cases next week.
Thanks for looking at my code!

On Fri, Sep 16, 2005 at 06:15:28PM +0800, nethorse wrote:
> Hi James R. Leu,
>=20
> I am digging your mpls-linux project, and learn a lot from your codes. Th=
ank you for your hard work.
>=20
> I have two question:
>      (1) When set labelsapce=3D-1, dev->mpls_ptr is destroyed, ilm and nh=
lfe are kept.
>       When set labelsapce!=3D-1, dev->mpls_ptr is created again, but ilm-=
>dev_entry,nhlfe->dev_entry =20
>       are not inserted into mpls_ptr->list_in, mpls_ptr->list_out
>=20
>      (2)
>     static int mpls_release_netdev_in_ilm (struct net_device *dev);
>     static int mpls_release_netdev_in_nhlfe (struct net_device *dev);
>     =20
>      In above two functions, only instrs are freed, ilm and nhlfe are kep=
t, and=20
>      mpls_nhlfe_list,mpls_ilm_list, mpls_nhlfe_tree,mpls_ilm_tree are not=
 changed.
>     I think  memory maybe leak when netdev is registered again.=20
>=20
> Maybe I misread your codes, can you give me a explaination?
>=20
> Best regards!
>=20
> Zheng xijin=20
> from China   =20
> ??????????????????????????????????????????=17?^????X???'???u??M?????u????=
fz{\??ezx=1E?=08??Zr=17??g??x??iI??z???	???b??+~?????u?????y?h?)??o???&j???=
*.?????'J?????=3D#?X??=17?z?)?????i??????y?+???z??z?'?j??=1A???????????????=
??????????????????????????{??=07?z??????x%??f?[??)???=1E?????b??????q???=07=
???a??l?????l??.?????=1E?w??X??????b?????l?X??=1F?zw?

--=20
James R. Leu
jl...@mi...