Re: [mpls-linux-general] Iptables Extension to MPLS-LINUX

[Olivier D. <Oli...@rd...>]

Hi Vincent,

Vincent Jardin wrote:
> 
> 1/ bug in ip_output.c:ip_output()
> 
> #ifdef CONFIG_MPLS_INGRESS_POLICING
>         if (skb->mpls_index)
>                 return mpls_output(skb);
> #endif
> 
> should be after
> 
> #ifdef CONFIG_IP_ROUTE_NAT
>         struct rtable *rt = (struct rtable*)skb->dst;
> #endif
> 

Ok we see the error.

> 2/ bug in libipt_MPLS.c
> static void
> save(const struct ipt_ip *ip, const struct ipt_entry_target *target)
> {
>         const struct ipt_mpls_target_info *mplsinfo =
>                 (const struct ipt_mpls_target_info *)target->data;
> 
>         printf("--set-mpls 0x%lx ", mplsinfo->index);
> }
> It should be --set-index
> Moreover, there is the same error in your README, set-index should be used
> instead of set-mpls. Or you should update libipt_MPLS.c and replace the
> parsing of all the set-index with set-mpls. Otherwise it is not consistent.

The error is in the README file. All the code are consisent : We use
--set-mpls
> 
> 3/ it does not work with my testbed. I am still workin on it ;-(
> 
> Vincent
> 
> PS:
> int ip_output(struct sk_buff *skb)
> {
> 
> #ifdef CONFIG_IP_ROUTE_NAT
>         struct rtable *rt = (struct rtable*)skb->dst;
> #endif
> 
> /* OD & AD : call mpls_output routine if mpls_index has been set in PREROUTING
>  * or LOCAL_OUT hook both by netfilter or tc ingress.
>  */
> #ifdef CONFIG_MPLS_INGRESS_POLICING
>         if (skb->mpls_index)
>                 return mpls_output(skb);
> #endif
> 
>         IP_INC_STATS(IpOutRequests);
> 
> PPS: Please, could you post a more recent diff ?

We have used a Mandrake kernel source with mpls patch and not a full
clean linux kernel. This explain why there is some hunk. For the error
on the patch for the route.c file, you just need to add a blank line
after the last line (i.e. after the line 256). We made another patch
ASAP, but we found a bug in the code, so we have to correct them before.

> PPPS: I am sorry if this mail is delayed, we have some routing loops in our
> local network ;-(
> 

Olivier & Alexandre

-- 
 FTR&D/DAC/CPN
 Technopole Anticipa     | mailto:Oli...@fr...
 2, Avenue Pierre Marzin | Phone:  +(33) 2 96 05 28 80
 F-22307 LANNION         | Fax:    +(33) 2 96 05 18 52