Re: [mpls-linux-general] Iptables Extension to MPLS-LINUX

[Vincent J. <ja...@en...>]

1/ bug in ip_output.c:ip_output()

#ifdef CONFIG_MPLS_INGRESS_POLICING
        if (skb->mpls_index)
                return mpls_output(skb);
#endif

should be after 

#ifdef CONFIG_IP_ROUTE_NAT
        struct rtable *rt = (struct rtable*)skb->dst;
#endif

2/ bug in libipt_MPLS.c
static void
save(const struct ipt_ip *ip, const struct ipt_entry_target *target)
{
        const struct ipt_mpls_target_info *mplsinfo =
                (const struct ipt_mpls_target_info *)target->data;
 
        printf("--set-mpls 0x%lx ", mplsinfo->index);
} 
It should be --set-index
Moreover, there is the same error in your README, set-index should be used 
instead of set-mpls. Or you should update libipt_MPLS.c and replace the 
parsing of all the set-index with set-mpls. Otherwise it is not consistent.

3/ it does not work with my testbed. I am still workin on it ;-(

Vincent

PS:
int ip_output(struct sk_buff *skb)
{
 
#ifdef CONFIG_IP_ROUTE_NAT
        struct rtable *rt = (struct rtable*)skb->dst;
#endif
 
/* OD & AD : call mpls_output routine if mpls_index has been set in PREROUTING
 * or LOCAL_OUT hook both by netfilter or tc ingress.
 */
#ifdef CONFIG_MPLS_INGRESS_POLICING
        if (skb->mpls_index)
                return mpls_output(skb);
#endif
 
        IP_INC_STATS(IpOutRequests);

PPS: Please, could you post a more recent diff ?
PPPS: I am sorry if this mail is delayed, we have some routing loops in our 
local network ;-(

Le Lundi  2 Juillet 2001 10:39, Olivier Dugeon a écrit :
> Hi Vincent,
>
> Vincent Jardin wrote:
> > I just see a tiny bug in your README:
> >
> > You wrote:
> > ...
> > LER A:
> > ------
> >
> > LER A acts as usual with binding a fec to the outgoing label and
> > doesn't use iptables.
> >
> > # Add a route to LER B
> > #
> > route add -host 10.1.0.1 gw 10.1.0.2
> > ...
> > It should be
> > route add -host 10.2.1.2 gw 10.1.0.2
> > Otherwise you cannot add the LER A's FEC:
> > mplsadm -v -A -B -O gen:16:eth0:ipv4:10.1.0.2 -f 10.2.1.2/32
>
> Exact. we have modify the README. We found another tiny bug about the
> route.
>
> We wrote :
>
> The hosts are MPLS unaware. They just need to add an
> explicit route to the other Host like this :
>
> # on Host A
> route add -net 10.2.1.0/24 gw 10.1.1.2
>                                      ^
> # on Host B
> route add -net 10.1.1.0/24 gw 10.2.1.2
>                                      ^
> It should be
>
> # on Host A
> route add -net 10.2.1.0/24 gw 10.1.1.1
>                                      ^
> # on Host B
> route add -net 10.1.1.0/24 gw 10.2.1.1
>                                      ^
>
> Olivier & Alexandre