Re: [mpls-linux-devel] BUG fixes

[Jorge B. [DTI2] <jo...@dt...>]

El 22/08/2011 13:55, Igor Maravić escribió:
> I'm sending you patch for bug fixes, against kernel that was patched
> with linux-kernel-v2.6.35.13-mpls1.980.patch
> <http://sourceforge.net/projects/mpls-linux/files/mpls-linux/Patches/linux-kernel-v2.6.35.13-mpls1.980.patch/download>.

	I am busy this week, but please take a look at the code in the net-next repo
that Renato pushed to sourceforge because the things you mention are already
changed there. You need the iproute2 changes from the master-mpls-net-next
branch too.

	Regars,
		Jorge
> 
> Also I have some other remarks and suggestions.
> 
> 1. Name for the iptables targets should be written in uppercase, to be
> consistent with other iptables targets.  Because of that I think that you should
> rename file xt_mpls.c and xt_mpls.h to xt_MPLS.c and xt_MPLS.h.
> Also you should change target names to uppercase (ipt_mpls and ip6t_mpls
> to ipt_MPLS and ip6t_MPLS). Also, I would exclude .table="mangle" in struct
> xt_target so this
> target could work on all tables, not just mangle table.
> 
> 2.In kernel 2.6.38.8. struct dst_ops should be intialized with
> function dst_entries_init and destroyed with dst_entries_destroy. That is
> important because mpls_dst_ops (in mpls_dst.c), 
> ilm_dst_ops (in mpls_ilm.c) and nhlfe_dst_ops (in mpls_nhlfe.c) should be
> initialized in init functions and destroyed in exit functions.
> 
> 3.I think that definition of building mpls6 module in Makefile in /net/ipv6,
> should be like this:
> 
> obj-$(CONFIG_INET6_MPLS) += mpls6.o
> 
> instead of 
> 
> obj-$(CONFIG_INET6_MPLS) += mpls6.o ipv6.o
> 
> 
> BR
> Igor Maravić


-- 
==============================================================
Jorge Boncompte - Ingenieria y Gestion de RED
DTI2 - Desarrollo de la Tecnologia de las Comunicaciones
--------------------------------------------------------------
C/ Abogado Enriquez Barrios, 5   14004 CORDOBA (SPAIN)
Tlf: +34 957 761395 / FAX: +34 957 450380
==============================================================
- There is only so much duct tape you can put on something
  before it just becomes a giant ball of duct tape.
==============================================================