Re: [mpls-linux-devel] Quagga-MPLS patch

[Vasu D. <vd...@gm...>]

Hi James,

Did you get a chance to look over my code.

Thanks,
-Vasu

On Thu, Jun 11, 2009 at 12:46 PM, Vasu Dasari <vd...@gm...> wrote:

> Thanks James. As you pointed out, I did not include ldp_debug.[ch]. I am
> including the same in this attachment.
>
> -Vasu
>
>
> On Wed, Jun 10, 2009 at 10:22 PM, James R. Leu <jl...@mi...>wrote:
>
>> I've pull the patches into my local tree.  I'm in the midst of reviewing
>> and commit chunks that go together.  My initial response is wow.
>> You had to do a lot of work to just to implement the memory tracking.
>> Impressive!
>>
>> I will let you and mailing list know when I have them all committed.
>>
>> On Wed, Jun 10, 2009 at 02:10:55PM -0400, Vasu Dasari wrote:
>> > Hi James,
>> > I am including two patch files, for ldp-portable and quagga-mpls. These
>> > patch files are generated using git format-patch.
>> >
>> > -Vasu
>> >
>> > On Tue, Jun 9, 2009 at 1:39 PM, James R. Leu <jl...@mi...>
>> wrote:
>> >
>> > > Hello Vasu,
>> > >
>> > > It is great to hear that you've made changed to quagga-mpls.  Please
>> > > share your patch and I will do my best to get it integrated into the
>> > > tree as soon as I can.
>> > >
>> > > Ideally I'd like the patch as it comes from git format-patch, but
>> honestly
>> > > I'll take it in any form you have :-)
>> > >
>> > > If you're going to construct the diff by hand please use the diff
>> > > options -uNrb
>> > >
>> > > Please post it to the list as a gzip compressed attachment.
>> > >
>> > > On Tue, Jun 09, 2009 at 12:52:33PM -0400, Vasu Dasari wrote:
>> > > > Hi James,
>> > > > MPL-Linux and Quagga MPLS are quite useful projects both for
>> learning and
>> > > > fills a void in MPLS area open source community. I have been playing
>> with
>> > > > them for couple of months.
>> > > >
>> > > > My platform is Fedora core 10 and MPLS kernel is the one available
>> from
>> > > your
>> > > > site,  2.6.26.6,
>> > > >
>> > > > While working on Quagga-MPLS I had to fix some issues and made
>> couple of
>> > > > enhancements.
>> > > >
>> > > > 1. Netlink was not functional with Quagga-MPLS code as AF_MPLS was
>> 29
>> > > where
>> > > > as, it is defined as 28 in kernel.
>> > > > 2. An issue preventing the code from running as an LSR is
>> identified, and
>> > > > fixed.
>> > > > 3. When we have multiple routes to same destination or route,
>> FEX<->NH
>> > > > mapping was not properly setup. Fixed this.
>> > > > 4. Ran Valgrind on LDP, and found couple of vangrind bugs.
>> > > > 5.Memory management as per Quagga framework be classifying, FEC,
>> NH,etc
>> > > to
>> > > > their own separate buckets.
>> > > > 6. Added debug LDP database to dump state of LDP database as per
>> > > ldp_global
>> > > > structure.
>> > > >
>> > > > So thought I could contribute my code, to the group,
>> > > >
>> > > > Please let me know if you want to look at my code, and let me know
>> how
>> > > can I
>> > > > contribute.
>> > > >
>> > > > Thanks,
>> > > > -Vasu
>> > >
>> > > >
>> > >
>> ------------------------------------------------------------------------------
>> > > > Crystal Reports - New Free Runtime and 30 Day Trial
>> > > > Check out the new simplified licensing option that enables unlimited
>> > > > royalty-free distribution of the report engine for externally facing
>> > > > server and web deployment.
>> > > > http://p.sf.net/sfu/businessobjects
>> > > > _______________________________________________
>> > > > mpls-linux-devel mailing list
>> > > > mpl...@li...
>> > > > https://lists.sourceforge.net/lists/listinfo/mpls-linux-devel
>> > >
>> > >
>> > > --
>> > > James R. Leu
>> > > jl...@mi...
>> > >
>>
>>
>>
>>
>> --
>> James R. Leu
>> jl...@mi...
>>
>
>