Re: [mpls-linux-devel] [PATCH] Vtysh and "mpls ip" command

[Hasso T. <ha...@es...>]

James R. Leu wrote:
> On Thu, Jun 23, 2005 at 08:56:05PM +0300, Hasso Tepper wrote:
> > As I prefer always to use vtysh, I made the "mpls ip" command work under
> > it. LDP_IF_NODE commands should work as well now. This rises the question
> > though.
> 
> Thank you very much for taking the time to fix this.  I have tried
> multiple time to figure it out why it didn't work.  This is a huge
> help for my testing.  I have applied that patch to my tree.

NP. This is part of Quagga I know really well. That's how I started hacking
on it ;).

> > Why is ldp_interface_config_write() if 0'd out? Not yet ready code? Or
> > commented out because you have some better ideas regarding cli structure
> > of this part, James? Can I help with something regarding this?
> 
> When I re-implemented ldpd using the MPLS framework I if 0'd out
> all of the code that I had some doubts on.  Basicly trimming the amount
> of stuff I had to get working.  Now that things are stabalizing
> with respect to ldpd, I will probably go back and start enabling all
> of the 'bells and whistles'.

OK. Then logic will stay. Then some further fixes are needed to handle
configuration in LDP_IF_NODE. I'm going to fix this, just one comment.
I looked at this commented out ldp_interface_config_write() and if I'm
not mistaken you indented LDP_IF_NODE further from INTERFACE_NODE. I
don't think that it's very good idea. Although I agree that making it
somewhat separate is very good idea. I'd recommend doing it like family
nodes in bgp configuration. Ie it will look like something like this in
vtysh:

interface eth0
 description ldp interface
 ip address 192.168.1.1/24
 ip ospf authentication message-digest
 ip ospf message-digest-key 1 md5 foo
!
 mpls ip
 distribution-mode dod
 keepalive-interval 10
!
interface eth1
 description ...
...

What do you think?

-- 
Hasso Tepper
Elion Enterprises Ltd.
WAN administrator