[mpls-linux-devel] Current state of dst stacking on davem implementation
Status: Beta
Brought to you by:
jleu
From: James R. L. <jl...@mi...> - 2004-03-01 05:15:08
|
I've attached a patch against the head of line of the p4 depot for the davem implementation. I tested the output path and it correctly generates MPLS packets. I was unable to figure out the correct combination of l2c commands on the input side. So I gave up testing the input path for tonight. I thought I'd send out what I have so you can look it over and get an understanding of where I'm heading with this change. Of course you could always look at the latest changes to my implementation and you'd probably get an even better idea ;-) Items left to be resolved: -correct l2c command line for input definition? (are we open for discussing changes?) -correct model for refcnting nhlfe's. I have an idea: -'imagined' refcnt for holding nhlfe in hash table, no actual inc or dec when adding/deleting to hash table. This way a simple check for refcnt != 0 will tell if some other layer is using the nhlfe (ILM, IPv4 rt_cache/route table, IPv6 route table, etc). Deletes are denied until refcnt == 0, at which time a dst_free is executed. -question: OK to let a dst_entry have refcnt of 0? Do I need to handle any special cases in the dst_ops to account for the refcnt != 0 cases? -I have this implemented on my code and am doing long term testing (>24hrs) to see if anything weird happens to ths refcnting. BTW I had to use '-p6' to apply the patch -- James R. Leu jl...@mi... |