Re: [mpls-linux-devel] Hi all

[Jamal H. S. <ha...@zn...>]

Hi guys,

didnt mean to desert you - things have been extremely hectic. Still are
(both at work and home). So i hope you wont mind me being intermittent.
I will try my best to respond when i believe its high priority like in
this case.

Scary - It compiles just fine for me.

Substitute that nhl to be nhp - its what it should be.

------
[root@jzny 261-mod]# gcc -v
Reading specs from /usr/lib/gcc-lib/i386-conectiva-linux/3.2.2/specs
Configured with: /usr/src/rpm/BUILD/gcc-3.2.2/configure --prefix=/usr
--bindir=/usr/bin --libdir=/usr/lib --mandir=/usr/share/man
--infodir=/usr/share/info --datadir=/usr/share --enable-shared
--enable-threads=posix --enable-haifa --enable-libgcj
--enable-languages=c,c++,f77,objc,java --with-system-zlib
--with-gxx_include_dir=/usr/include/c++/3.2.2
--host=i386-conectiva-linux
Thread model: posix
gcc version 3.2.2
---------

I susbtituted that nhl with nhx and it still compiled.
Now i am thinking that the code is not being hit; so i substitute with:

-----
..
..
#ifdef CONFIG_NET_MPLS
#error  "testing CONFIG_NET_MPLS"
                        //gw = fib_get_attr32(RTNH_DATA(nhx), attrlen,
RTA_MPLS_FEC);
                        //if (gw && gw != nh->nh_mpls_fec)
                        //      return 1;
#end
...
...
----------

and the compile doesnt bail out.
Why did yours work?
Can you replace with the above #error and see if still compiles?

cheers,
jamal

On Mon, 2004-02-23 at 05:25, Ramon Casellas wrote:
> I've started some changes, but the current version does not compile:
> net/ipv4/fib_semantics.c: In function `fib_nh_match':
> net/ipv4/fib_semantics.c:351: error: `nhl' undeclared (first use in this 
> function)
> net/ipv4/fib_semantics.c:351: error: (Each undeclared identifier is 
> reported only once
> net/ipv4/fib_semantics.c:351: error: for each function it appears in.)
> make[2]: *** [net/ipv4/fib_semantics.o] Error 1
> make[1]: *** [net/ipv4] Error 2
> 
> Looks like a trivial fix:
> #ifdef CONFIG_NET_MPLS
>                         gw = fib_get_attr32(RTNH_DATA(nhl), attrlen, 
> RTA_MPLS_FEC);
>                         if (gw && gw != nh->nh_mpls_fec)
>                                 return 1;
> #endif
> 
> but I wonder Jamal, did you compile it before sending the patch ? :)
> 
> regards,
> R.
> 
> 
> 
> // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> // Ramon Casellas - GET/ENST/INFRES/RHD/A508 - cas...@in...
> // Tel: +33 (0)1 45 81 75 88                 Fax: +33 (0)1 45 81 71 58
> // 37/39 rue Dareau 75014 Paris   --    http://perso.enst.fr/~casellas
> 
> 
> -------------------------------------------------------
> SF.Net is sponsored by: Speed Start Your Linux Apps Now.
> Build and deploy apps & Web services for Linux with
> a free DVD software kit from IBM. Click Now!
> http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
> _______________________________________________
> mpls-linux-devel mailing list
> mpl...@li...
> https://lists.sourceforge.net/lists/listinfo/mpls-linux-devel