[mpls-linux-devel] DaveM - mpls_nhlfe_hash_code()

[James R. L. <jl...@mi...>]

I see a minor flaw we need to fix in the DaveM code.

If I read the code correctly, the hash for the NHLFE is
calculated using the out-going label and the out-going ifindex.
If this is the case, then we get an unresolvable collision when 2
or more peers off of the same interface allocate the same label
(which is perfectly valid).  Either we can add the nexthop address
as part of the search criteria (yuck!) or just aknowledge that
NHLFE's have a unique index which is not detemined by the contents of
it.  The second fits well with the LSR MIB in which the out-segments
have an arbitrary unique index.

What do you guys think?

-- 
James R. Leu
jl...@mi...