Re: [mpls-linux-devel] Re: 2.6 Spec: Random comments.

[Ramon C. <cas...@in...>]

On 13 Feb 2004, Jamal Hadi Salim wrote:

> you are sure you dont want nh somewhere in there?
> since this is a reference to the NHlfe;
> heck why dont we just call it nhlfe_id ? ;->


nhlfe_id is fine for me.


> Refer to my earlier email for the suggestions i made.

Agreed.


>
> > comment: I *do* think that mpls_tunnel.c from James impl can directly be
> > used and it's very convenient. Just %s/moi/fwd_id/g
>
> What is the mpls_tunnel.c for? Is it a netdevice? What is it used for?


Yes. It is a virtual netdevice that is allocated upon request and
basically holds a MOI (the equivalent of a nhlfe_id). User sees it as a
unidirectional netdevice (ifconfig, etc),

Take a look at the file if you happen to find some spare time (Indeed, it
can be improved and the sysfs integration was a little hairy) but I think
it is very convenient and extensively used when RSVP-TE sets up LSPs.

regards,
Ramon