[mpls-linux-devel] Question: Why do we need mpls_tunnel_list ?

[Ramon C. <cas...@in...>]

Hi,

I've been thinking about this, and I don't see why do we need to
keep a separate list of mpls tunnels. Assume we remove it

Disadvantages:

* To identify the list of mpls tunnels we need to check private flags
and/or if (dev->type == ARPHRD_MPLS_TUNNEL). We only need to do this from
process context, and, unless the user has hundreds of network devices,
overhead is small.


Advantages:

* The functions: mpls-tunnel_init mpls_tunnel_link mpls_tunnel_unlink
can be removed.

* We avoid synchronization issues with rtnl_lock and list lock, and we
avoid incoherences between the main dev_base list and our private list.

* Avoid race conditions when removing the module.

* Code is cleaner and easier to understand.

Comments? I am all for a removal...

R.