Re: [mpls-linux-devel] neigh_table_find removed in 2.6.2

[James R. L. <jl...@mi...>]

I implemented neigh_table_find.  True their is no refcnting of anything
it was a quick hack.  There is no easy way to implement a MPLS neighbour
table without completly duplicating the IPv4 or IPv6 neighbours.  A hh_cache
will never work because the contents of the MPLS header is not the
same for every packet that traverses an LSP (TLL and EXP), so the only
info we would get from MPLS neighbour table is the exact information that
we get from the IPv[4|6] tables.  I see nothing to gain by implementing
a MPLS neighbour table.  I think the correct path is to add refcnting
to neigh_table.

Won't other protocols needs this as well?  Think of IPv6 routes that point
to IPv4 nexthops or vice versa.

On Fri, Feb 06, 2004 at 02:46:16PM +0100, Ramon Casellas wrote:
> 
> 
> Hi,
> 
> Little question here: neigh_table_find has been removed in 2.6.2
> 
> The original goal was to manage mpls_dsts but reusing the AF_INET
> AF_INET6 neighbour tables (lookup a neighbour and hold it in the mpls_dst)
> 
> The problem is that now I don't see how we can do this... We should not 
> access the neigh_tables list & lock directly. Maybe we should manage our 
> own neighbours and a AF_MPLS neighbour table... I'm starting to think that 
> this is the best approach, since we can even cache hh objects with 
> ETH_P_MPLS_UC....
> 
> Thoughts? Maybe we should start bugging ne...@os... for comments. 
> 
> Regards,
> R.
> 
> 
> 
> RFC: 
>         /* Set next hop MPLS attr */
>         memcpy(&md->md_nh,nh,sizeof(struct sockaddr));
> 
>         /*
>          * Lookup for the next hop (neighbour) in the AF_INET/AF_INET6
>          * neighbour table. (neigh_table_find removed in 2.6.2)
>          */
> 
> 	tbl = neigh_table_find (....)
> 
>         /*
>          * AF_INET neighbour keys are their addr.
>          * Look for the neighbour (create if needed)
>          * (neigh_lookup & neigh_create hold a ref)
>          */
>         md->u.dst.neighbour = __neigh_lookup(tbl, data, dev, 1);
> 
> 
> // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> // Ramon Casellas - GET/ENST/INFRES/RHD/A508 - cas...@in...
> 
> 
> -------------------------------------------------------
> The SF.Net email is sponsored by EclipseCon 2004
> Premiere Conference on Open Tools Development and Integration
> See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
> http://www.eclipsecon.org/osdn
> _______________________________________________
> mpls-linux-devel mailing list
> mpl...@li...
> https://lists.sourceforge.net/lists/listinfo/mpls-linux-devel

-- 
James R. Leu
jl...@mi...