Thread: [Mplayerplug-in-devel] Patch for mozilla-mplayer / mplayerplug-in to support JACK
Brought to you by:
kdekorte
From: Max-Gerd R. <m.r...@gm...> - 2006-01-31 08:51:35
Attachments:
mplayerplug-in-3.17_jack.patch
|
Hi, attached is a patch to make the plug-in to support Jack as audio output driver. I seem to remember that this has been working before. In my opinion it is a bad design to have a separate list of actually selectable audio output drivers in the user interface part. It should list all output drivers (for the video drivers as well) that the plug-in actually includes, and this list shouldn't be maintained manually for the user interface. Doesn't it even allow to select e.g. ALSA if it is not built with ALSA support? How does gmplayer do this? Otherwise a nice plug-in. Thanks for your work. Bye, Max -- Max-Gerd Retzlaff <m.r...@gm...> http://blog.matroid.org For your amusement: My brother sent me a postcard the other day with this big satellite photo of the entire earth on it. On the back it said: "Wish you were here". -- Steven Wright |
From: Kevin D. <kde...@ya...> - 2006-01-31 14:32:52
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Max-Gerd Retzlaff wrote: > Hi, > > attached is a patch to make the plug-in to support Jack as audio > output driver. I seem to remember that this has been working > before. In my opinion it is a bad design to have a separate list > of actually selectable audio output drivers in the user interface > part. It should list all output drivers (for the video drivers as > well) that the plug-in actually includes, and this list shouldn't be > maintained manually for the user interface. Doesn't it even allow to > select e.g. ALSA if it is not built with ALSA support? How does > gmplayer do this? > > Otherwise a nice plug-in. Thanks for your work. > > Bye, > Max Thanks for the patch Max, but this fix is already in CVS (3.20pre1). I agree that hard coding in the options is not a great choice, but the only other way to do this would be to run mplayer with the -ao help and -vo help options to get a listing of the supported outputs and even then, that is not a great option. So for now I'll stick with this method. For the vo output option only xv,gl and x11 work properly when embedding on a page. That is why I limit those. Also, you can type into those selection dialogs so if what you want in not there, just type it in. Kevin - -- Get my public GnuPG key from http://keyserver.veridis.com:11371/export?id=7574690260641978351 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFD33USaR60qN0tF+8RAhOFAJ9aN0bejWaK0T3cH5nZTSZuqxh+3ACeJ/zK lxQTMWwLSr5LctgXSikKuUc= =Kxmm -----END PGP SIGNATURE----- |