Thread: Re: [Mplayerplug-in-devel] Beat up on CVS time (Page 2)
Brought to you by:
kdekorte
From: Kevin D. <kde...@ya...> - 2005-07-31 19:23:10
|
On Sunday 31 July 2005 12:55 pm, Michael Rasmussen wrote: > On 2005-07-31 18:08:08, Kevin DeKorte wrote: > > Michael, > > > > Well I added some code to CVS to tell us the error. So I guess you'll > > have to > > get it and see... > > It does not change anything - it reads the file first time, but > changing something and the file is deleted. I have been trying varius > setups and it seems that writing just dos not happen. I activated debug > in the config file but no log showed up anyware. Tried directing > logging to tmp but the same thing happend. I am only able to see debug > output is I start firefox from a terminal. > > Output: > config /home/mir/.mplayer/mplayerplug-in.conf > tmp /tmp/confXt7zDta > write new config file > Unable to rename the file /tmp/confXt7zDta to > /home/mir/.mplayer/mplayerplug-in.conf > Error code: 18 - Invalid cross-device link > > running as root though is alright: > config /root/.mplayer/mplayerplug-in.conf > tmp /tmp/confXUN5FpL > write new config file > > I think I know the reason: > In Unix link and unlink is not allow across file systems. In my case > home is mounted via nfs, but it also would be the same if home was on a > different file system than /usr/bin/ where firefox is installed. > Therefore, in my case, root is allow to link and unlink since /root is > on the same file system as /usr/bin. I thought this might be a problem, but I thought rename would solve this=20 issue.=20 I have this change commited to CVS... Index: Source/plugin-ui.cpp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvsroot/mplayerplug-in/mplayerplug-in/Source/plugin-ui.cpp,v retrieving revision 1.130 retrieving revision 1.131 diff -u -r1.130 -r1.131 =2D-- Source/plugin-ui.cpp 31 Jul 2005 16:05:43 -0000 1.130 +++ Source/plugin-ui.cpp 31 Jul 2005 19:20:25 -0000 1.131 @@ -1641,7 +1641,8 @@ snprintf(config_name, 1000, "%s", getenv("HOME")); strlcat(config_name, "/.mplayer/mplayerplug-in.conf", 1000); =2D snprintf(tmp_name, 1000, "%s", tempnam("/tmp", "confXXXXXX")); + snprintf(tmp_name, 1000, "%s", getenv("HOME")); + strlcat(tmp_name, "/.mplayer/mplayerplug-in.conf.tmp", 1000); if (DEBUG) { printf("config %s\n", config_name); Kevin =2D-=20 Get my public GnuPG key from http://keyserver.veridis.com:11371/export?id=3D7574690260641978351 |
From: Michael R. <mi...@mi...> - 2005-07-31 21:20:25
|
On 2005-07-31 21:23:02, Kevin DeKorte wrote: >=20 > I thought this might be a problem, but I thought rename would solve > this > issue. >=20 > I have this change commited to CVS... >=20 Same story:-\ --=20 Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael <at> rasmussen <dot> cc http://keyserver.veridis.com:11371/pks/lookup?op=3Dget&search=3D0xD3C9A00E mir <at> datanom <dot> net http://keyserver.veridis.com:11371/pks/lookup?op=3Dget&search=3D0xE501F51C mir <at> miras <dot> org http://keyserver.veridis.com:11371/pks/lookup?op=3Dget&search=3D0xE3E80917 -------------------------------------------------------------- Debian Hint #3: You can use 'apt-cache search <words>' to search for =20 words in the descriptions of all available packages. |
From: Michael R. <mi...@mi...> - 2005-08-01 01:21:43
|
Hi Kevin, On 2005-07-31 21:23:02, Kevin DeKorte wrote: >=20 > I thought this might be a problem, but I thought rename would solve > this > issue. >=20 As reported in the last mail it did not do any good. So instead of =20 having others solve my problems I solved it myself:-) Patch for plugin-ui.cpp: --- plugin-ui.cpp 2005-08-01 00:03:31.540847840 +0200 +++ plugin-ui.cpp-new 2005-07-31 23:54:00.676743857 +0200 @@ -1676,6 +1676,21 @@ ret =3D rename(tmp_name, config_name); if (ret =3D=3D -1) { ret =3D errno; + if (ret =3D=3D 18) { + /* Dealing with a link to another file system */ + input =3D fopen(tmp_name, "r"); + output =3D fopen(config_name, "w"); + if (input !=3D NULL && output !=3D NULL) { + if (DEBUG) + printf("update existing config on and =20 external file system\n"); + while (fgets(buffer, sizeof(buffer), =20 input) !=3D NULL) { + fprintf(output, "%s", buffer); + } + fclose(input); + fclose(output); + unlink(tmp_name); + } + } if (DEBUG) { printf("Unable to rename the file %s to =20 %s\n",tmp_name,config_name); printf("Error code: %i - =20 %s\n",ret,strerror(ret)); @@ -1700,6 +1715,21 @@ ret =3D rename(tmp_name, config_name); if (ret =3D=3D -1) { ret =3D errno; + if (ret =3D=3D 18) { + /* Dealing with a link to another file system */ + input =3D fopen(tmp_name, "r"); + output =3D fopen(config_name, "w"); + if (input !=3D NULL && output !=3D NULL) { + if (DEBUG) + printf("update existing config on =20 and external file system\n"); + while (fgets(buffer, sizeof(buffer), =20 input) !=3D NULL) { + fprintf(output, "%s", buffer); + } + fclose(input); + fclose(output); + unlink(tmp_name); + } + } if (DEBUG) { printf("Unable to rename the file %s to =20 %s\n",tmp_name,config_name); printf("Error code: %i - =20 %s\n",ret,strerror(ret)); A suggestion: To keep things simple I think all reading of config files =20 should be done the way I have handle the problem with home on another =20 file system as it seems this way is more robust? Language Files: The reason way they are not installed if you run make install as root =20 is simple. The Makefile in po needs $DESTDIR "if [ "$(DESTDIR)" then" =20 so install.sh NEW MAKEFILE: LANGUAGES=3Dde dk es fr it ja ko pl pt_BR nl ru MOFILES=3Dde.mo dk.mo es.mo fr.mo it.mo ja.mo ko.mo pl.mo pt_BR.mo nl.mo =20 ru.mo PACKAGE=3Dmplayerplug-in .SUFFIXES: .SUFFIXES: .po .mo .pot .PHONY: all install uninstall clean distclean $(LANGUAGES) .po.mo: msgfmt -o $@ $< all: $(MOFILES) install: $(MOFILES) if [ "$(DESTDIR)" ]; then \ $(INSTALL) -d -m0755 $(DESTDIR)$(LOCALEDIR); \ LOCALEDIR=3D$(DESTDIR)/$(LOCALEDIR); \ fi; \ for lang in $(LANGUAGES); do \ dir=3D$(LOCALEDIR)/$$lang/; \ if test ! -x "$$dir"; then \ mkdir $$dir; chmod 755 $$dir; \ fi; \ dir=3D$(LOCALEDIR)/$$lang/LC_MESSAGES; \ if test ! -x "$$dir"; then \ mkdir $$dir; chmod 755 $$dir; \ fi; \ if test -r $$lang.mo; then \ install -m644 $$lang.mo $$dir/$(PACKAGE).mo; \ fi; \ done; \ uninstall: @$(MAKE) check for cat in $(MOFILES); do \ cat=3D`basename $$cat`; \ lang=3D`echo $$cat | sed 's/\$(CATOBJEXT)$$//'`; \ rm -f $(LOCALEDIR)/$$lang/LC_MESSAGES/$(PACKAGE).mo; \ done clean: rm -f core core.* *.old.po *.mo *.pot sjiscorr distclean: clean $(PACKAGE).pot: ../Source/*.cpp xgettext --default-domain=3D$(PACKAGE) --add-comments --keyword=3D_ =20 --keyword=3DN_ ../Source/*.cpp -o $(PACKAGE).pot $(LANGUAGES): @$(MAKE) $(PACKAGE).pot if test ! -f $@.po.orig; then cp $@.po $@.po.orig; fi mv $@.po $@.po.old if msgmerge $@.po.old $(PACKAGE).pot -o $@.po; then \ rm -f $@.po.old; \ else \ echo "msgmerge for $@.po failed!"; mv $@.po.old $@.po; \ fi A last remark: The language file for danish must be called da.po as the =20 $LANG is set to da when danish should be enabled. As of now the =20 language is not activated since it is placed in folder called =20 $LOCALEDIR/LC_MESSAGES/dk/ where it should be $LOCALEDIR/LC_MESSAGES/da/ PS. The po folder is not opdated from cvs? --=20 Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael <at> rasmussen <dot> cc http://keyserver.veridis.com:11371/pks/lookup?op=3Dget&search=3D0xD3C9A00E mir <at> datanom <dot> net http://keyserver.veridis.com:11371/pks/lookup?op=3Dget&search=3D0xE501F51C mir <at> miras <dot> org http://keyserver.veridis.com:11371/pks/lookup?op=3Dget&search=3D0xE3E80917 -------------------------------------------------------------- Forrest Gump: "They sending me to Vietnam - it's this whole other country" |
From: Kevin D. <kde...@ya...> - 2005-08-01 01:59:10
|
On Sunday 31 July 2005 05:42 pm, Michael Rasmussen wrote: > Hi Kevin, > > On 2005-07-31 21:23:02, Kevin DeKorte wrote: > > I thought this might be a problem, but I thought rename would solve > > this > > issue. > > As reported in the last mail it did not do any good. So instead of > having others solve my problems I solved it myself:-) > > > A suggestion: To keep things simple I think all writing of config files > should be done the way I have handle the problem with home on another > file system as it seems this way is more robust? > Michael, Why is this patch needed... current cvs does this. create $HOME/.mplayer/mplayerplug-in.conf.tmp read from $HOME/.mplayer/mplayerplug-in.conf write to $HOME/.mplayer/mplayerplug-in.conf.tmp delete $HOME/.mplayer/mplayerplug-in.conf rename $HOME/.mplayer/mplayerplug-in.conf.tmp to=20 $HOME/.mplayer/mplayerplug-in.conf There is no reason your patch should be necessary since we are no longer=20 crossing filesystems. So I am going to put your patch on hold until you can= =20 give me a reason why current CVS that does the above will not work with the= =20 debug and error log.=20 Kevin =2D-=20 Get my public GnuPG key from http://keyserver.veridis.com:11371/export?id=3D7574690260641978351 |
From: Michael R. <mi...@mi...> - 2005-08-01 10:51:07
|
On 2005-08-01 03:58:57, Kevin DeKorte wrote: >=20 > Why is this patch needed... current cvs does this. >=20 > create $HOME/.mplayer/mplayerplug-in.conf.tmp > read from $HOME/.mplayer/mplayerplug-in.conf > write to $HOME/.mplayer/mplayerplug-in.conf.tmp > delete $HOME/.mplayer/mplayerplug-in.conf > rename $HOME/.mplayer/mplayerplug-in.conf.tmp to > $HOME/.mplayer/mplayerplug-in.conf >=20 Sorry, I must have missed your mail. Sourgeforge's mail server was =20 acting wierd this night, why I also made 3 identical mails. Also cvs =20 was not updated why I was not informed of your changes. I have made a new cvs update now and your changes works so disregard my =20 patch. --=20 Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael <at> rasmussen <dot> cc http://keyserver.veridis.com:11371/pks/lookup?op=3Dget&search=3D0xD3C9A00E mir <at> datanom <dot> net http://keyserver.veridis.com:11371/pks/lookup?op=3Dget&search=3D0xE501F51C mir <at> miras <dot> org http://keyserver.veridis.com:11371/pks/lookup?op=3Dget&search=3D0xE3E80917 -------------------------------------------------------------- Debian Hint #6: There is no hint #6. |
From: Kevin D. <kde...@ya...> - 2005-08-01 02:19:24
|
> Language Files: > The reason way they are not installed if you run make install as root > is simple. The Makefile in po needs $DESTDIR "if [ "$(DESTDIR)" then" > so install.sh But I do see why the install is failing... so I have fixed that part. CVS is down right now so I can't commit the changes. Kevin > > NEW MAKEFILE: > LANGUAGES=3Dde dk es fr it ja ko pl pt_BR nl ru > MOFILES=3Dde.mo dk.mo es.mo fr.mo it.mo ja.mo ko.mo pl.mo pt_BR.mo nl.mo > ru.mo > > PACKAGE=3Dmplayerplug-in > > .SUFFIXES: > .SUFFIXES: .po .mo .pot > .PHONY: all install uninstall clean distclean $(LANGUAGES) > > .po.mo: > msgfmt -o $@ $< > > all: $(MOFILES) > > install: $(MOFILES) > if [ "$(DESTDIR)" ]; then \ > $(INSTALL) -d -m0755 $(DESTDIR)$(LOCALEDIR); \ > LOCALEDIR=3D$(DESTDIR)/$(LOCALEDIR); \ > fi; \ > for lang in $(LANGUAGES); do \ > dir=3D$(LOCALEDIR)/$$lang/; \ > if test ! -x "$$dir"; then \ > mkdir $$dir; chmod 755 $$dir; \ > fi; \ > dir=3D$(LOCALEDIR)/$$lang/LC_MESSAGES; \ > if test ! -x "$$dir"; then \ > mkdir $$dir; chmod 755 $$dir; \ > fi; \ > if test -r $$lang.mo; then \ > install -m644 $$lang.mo $$dir/$(PACKAGE).mo; \ > fi; \ > done; \ > > uninstall: > @$(MAKE) check > for cat in $(MOFILES); do \ > cat=3D`basename $$cat`; \ > lang=3D`echo $$cat | sed 's/\$(CATOBJEXT)$$//'`; \ > rm -f $(LOCALEDIR)/$$lang/LC_MESSAGES/$(PACKAGE).mo; \ > done > > clean: > rm -f core core.* *.old.po *.mo *.pot sjiscorr > > distclean: clean > > $(PACKAGE).pot: ../Source/*.cpp > xgettext --default-domain=3D$(PACKAGE) --add-comments --keyword=3D_ > -- > keyword=3DN_ ../Source/*.cpp -o $(PACKAGE).pot > > $(LANGUAGES): > @$(MAKE) $(PACKAGE).pot > if test ! -f $@.po.orig; then cp $@.po $@.po.orig; fi > mv $@.po $@.po.old > if msgmerge $@.po.old $(PACKAGE).pot -o $@.po; then \ > rm -f $@.po.old; \ > else \ > echo "msgmerge for $@.po failed!"; mv $@.po.old $@.po; \ > fi > > A last remark: The language file for danish must be called da.po as the > $LANG is set to da when danish should be enabled. As of now the > language is not activated since it is placed in folder called > $LOCALEDIR/LC_MESSAGES/dk/ where it should be $LOCALEDIR/LC_MESSAGES/da/ > > PS. The po folder is not opdated from cvs? =2D-=20 Get my public GnuPG key from http://keyserver.veridis.com:11371/export?id=3D7574690260641978351 |
From: Anders L. <li...@io...> - 2005-08-01 10:08:22
|
Hi søn, 31 07 2005 kl. 20:19 -0600, skrev Kevin DeKorte: > > Language Files: > > The reason way they are not installed if you run make install as root > > is simple. The Makefile in po needs $DESTDIR "if [ "$(DESTDIR)" then" > > so install.sh > > But I do see why the install is failing... so I have fixed that part. > > CVS is down right now so I can't commit the changes. > > Kevin > Yes, just saw your mails and I came to the same conclusion. I would say the languange files should be installed with a test condition that tests whether we are root/have privileges to make changes like if[`whoami` == 'root' ]; that similarly is used in install.sh. However the use of $DESTDIR to find and set LOCALEDIR and $(INSTALL) -d -m0755 $(DESTDIR)$(LOCALEDIR); should be left unchanged :) I think. Well, when the cvs is up again and committed I would check whether an ./uninstall.sh removes the language files again because I don't think they are removed as of now. Because i don't think ./uninstall.sh in mplayerplug-in calls mplayerplug-in/po/Makefile's uninstall - but I may be wrong ofcause so lets see if it is a problem. Someday when I have a better view of the code I would like to add some code to the configuration dialog and make an option to change mms:// URLs into http:// to make a workaround for the bug in mplayer regarding the problem of the MultiBitRate mms-streams from e.g. www.dr.dk 's mms:// URLs that they use for some of their recorded shows - their live channels are set to http://. I will hope you will commit it Kevin if the code works. Else I guess I will have to look into the much larger code base of mplayer to locate the bug - That would be looking for a needle in a haystack for me. :D Well, I will be back later today or tomorrow with an update to the Danish language file addressing the configuration dialog. Chauw Anders > > > > > NEW MAKEFILE: > > LANGUAGES=de dk es fr it ja ko pl pt_BR nl ru > > MOFILES=de.mo dk.mo es.mo fr.mo it.mo ja.mo ko.mo pl.mo pt_BR.mo nl.mo > > ru.mo > > > > PACKAGE=mplayerplug-in > > > > .SUFFIXES: > > .SUFFIXES: .po .mo .pot > > .PHONY: all install uninstall clean distclean $(LANGUAGES) > > > > .po.mo: > > msgfmt -o $@ $< > > > > all: $(MOFILES) > > > > install: $(MOFILES) > > if [ "$(DESTDIR)" ]; then \ > > $(INSTALL) -d -m0755 $(DESTDIR)$(LOCALEDIR); \ > > LOCALEDIR=$(DESTDIR)/$(LOCALEDIR); \ > > fi; \ > > for lang in $(LANGUAGES); do \ > > dir=$(LOCALEDIR)/$$lang/; \ > > if test ! -x "$$dir"; then \ > > mkdir $$dir; chmod 755 $$dir; \ > > fi; \ > > dir=$(LOCALEDIR)/$$lang/LC_MESSAGES; \ > > if test ! -x "$$dir"; then \ > > mkdir $$dir; chmod 755 $$dir; \ > > fi; \ > > if test -r $$lang.mo; then \ > > install -m644 $$lang.mo $$dir/$(PACKAGE).mo; \ > > fi; \ > > done; \ > > > > uninstall: > > @$(MAKE) check > > for cat in $(MOFILES); do \ > > cat=`basename $$cat`; \ > > lang=`echo $$cat | sed 's/\$(CATOBJEXT)$$//'`; \ > > rm -f $(LOCALEDIR)/$$lang/LC_MESSAGES/$(PACKAGE).mo; \ > > done > > > > clean: > > rm -f core core.* *.old.po *.mo *.pot sjiscorr > > > > distclean: clean > > > > $(PACKAGE).pot: ../Source/*.cpp > > xgettext --default-domain=$(PACKAGE) --add-comments --keyword=_ > > -- > > keyword=N_ ../Source/*.cpp -o $(PACKAGE).pot > > > > $(LANGUAGES): > > @$(MAKE) $(PACKAGE).pot > > if test ! -f $@.po.orig; then cp $@.po $@.po.orig; fi > > mv $@.po $@.po.old > > if msgmerge $@.po.old $(PACKAGE).pot -o $@.po; then \ > > rm -f $@.po.old; \ > > else \ > > echo "msgmerge for $@.po failed!"; mv $@.po.old $@.po; \ > > fi > > > > A last remark: The language file for danish must be called da.po as the > > $LANG is set to da when danish should be enabled. As of now the > > language is not activated since it is placed in folder called > > $LOCALEDIR/LC_MESSAGES/dk/ where it should be $LOCALEDIR/LC_MESSAGES/da/ > > > > PS. The po folder is not opdated from cvs? > |
From: Anders L. <li...@io...> - 2005-08-01 11:27:24
Attachments:
menu_up_small.xpm
|
Hi Just before I leave. 1. Some people may not notice that there is a menu available when pressing the right mousekey. Should we give them a hint? What about making an icon next to the full screen icon like the one I have attached in this mail that brings the menu to the screen? 2. There is a bug in the button handling as of now. When you enter full screen mode and return to normal view the buttons disappear. Kind regards Anders Lind |
From: Kevin D. <kde...@ya...> - 2005-08-01 12:31:42
|
On Monday 01 August 2005 05:27 am, Anders Lind wrote: > Hi > > Just before I leave. > 1. Some people may not notice that there is a menu available when > pressing the right mousekey. Should we give them a hint? > > What about making an icon next to the full screen icon like the one I > have attached in this mail that brings the menu to the screen? > I'll think about out.... > 2. There is a bug in the button handling as of now. > > When you enter full screen mode and return to normal view the buttons > disappear. > Can't duplicate. > > Kind regards > > Anders Lind =2D-=20 Get my public GnuPG key from http://keyserver.veridis.com:11371/export?id=3D7574690260641978351 |
From: Anders L. <li...@io...> - 2005-08-01 13:37:14
|
Hi man, 01 08 2005 kl. 06:31 -0600, skrev Kevin DeKorte: > > 2. There is a bug in the button handling as of now. > > > > When you enter full screen mode and return to normal view the buttons > > disappear. > > > > Can't duplicate. > Hmmm. Strange. Try to play a stream. Try e.g.: http://www.radio2.dk/lytr2.htm and the link: 'Webradio i høj kvalitet - 96 Kb -lyt her' The same observation I have made on the www.dr.dk site. After you exit full screen mode, try press the Stop button, and then the Play button - the control elements disapper. Sometimes they disappear when you leave full screen mode, other times when you press Stop and other times again first when you press Play. But they always disapper at some point after full screen. Afterwards you can from the menu press Play and Pause and nothing happens. But when you press Stop, the elements return, but usually the audio is silenced permanently even though I hit the Play button or the menu and select Play. In this case one of the 2 mplayer processes vanishes! Try this clip as well, which is very funny indeed: http://www.coolbuddy.com/videos/video_clip.asp?id=53 But it will not play, however mplayer plays it fine: mplayer http://www.coolbuddy.com/videos/clips/Women_Drivers.wmv In this case it doesn't seem that a mplayer process is running at all. I'm not able to tell whether the 2 problems are related. (But didn't you, Kevin, and Michael talk about some Play and Stop issues the other day?) Kind regards Anders |
From: Kevin D. <kde...@ya...> - 2005-08-01 21:03:13
|
On Monday 01 August 2005 07:37 am, Anders Lind wrote: > Hi > > man, 01 08 2005 kl. 06:31 -0600, skrev Kevin DeKorte: > > > 2. There is a bug in the button handling as of now. > > > > > > When you enter full screen mode and return to normal view the buttons > > > disappear. > > > > Can't duplicate. > > Hmmm. Strange. Try to play a stream. > > Try e.g.: > http://www.radio2.dk/lytr2.htm > and the link: > 'Webradio i h=F8j kvalitet - 96 Kb -lyt her' > > The same observation I have made on the www.dr.dk site. > > After you exit full screen mode, try press the Stop button, and then the > Play button - the control elements disapper. > Sometimes they disappear when you leave full screen mode, other times > when you press Stop and other times again first when you press Play. But > they always disapper at some point after full screen. > > Afterwards you can from the menu press Play and Pause and nothing > happens. But when you press Stop, the elements return, but usually the > audio is silenced permanently even though I hit the Play button or the > menu and select Play. > Ah! a test case... having that, I was able to fix the bug. Change is commit= ted=20 to CVS. > In this case one of the 2 mplayer processes vanishes! > > > Try this clip as well, which is very funny indeed: > http://www.coolbuddy.com/videos/video_clip.asp?id=3D53 > > But it will not play, however mplayer plays it fine: > mplayer http://www.coolbuddy.com/videos/clips/Women_Drivers.wmv > > In this case it doesn't seem that a mplayer process is running at all. > This was a fun one, took me a few mins to figure out what was going on... H= ere=20 is the issue. The Embed tag used "src" and "filename" attributes and they were set to the= =20 exact same value. Due to some changes with the multiprotocol fixes, basical= ly=20 the file ended up being downloaded twice and the content written twice to t= he=20 same file. Resulting in a corrupted file. I fixed this, but the guy who set= up=20 the embed tag ought to be shot. Change committed to CVS > > I'm not able to tell whether the 2 problems are related. > (But didn't you, Kevin, and Michael talk about some Play and Stop issues > the other day?) Problems were not related to each other and I think you are referring to=20 Takis' issues.=20 > > Kind regards > > Anders Kevin =2D-=20 Get my public GnuPG key from http://keyserver.veridis.com:11371/export?id=3D7574690260641978351 |
From: Anders L. <li...@io...> - 2005-08-03 20:14:16
|
Hi In the changelog I saw you made some changes regarding mms. I don't know for sure if it relates, but now I'm not able to play the famous radio streams from http://www.dr.dk In the upper left corner there is a box with a string "HØR RADIO" please choose a random channel. mplayerplug-in does not play. Closing the pop-up browser window often makes the other browser windows crash. However mplayer plays the channels fine when I wget a direct link from http://www.dr.dk/netradio/netradiohelp_direkte.shtml either 20 Kbps, 32 Kbps, 64 Kbps and copy and paste the direct link to a prompt as an argument to mplayer. It is probably easier to see the problem by pressing one of the 20, 32 or 64 Kbps direct links in a browser and see mplayerplug-in stop. debug set to 2 doesn't show anything that catches my eye. I also tried user-agent=NSPlayer but that didn't give anything either. Other channels like http://www.radio2.dk/lytr2.htm plays fine. Whether there should be any button problems left I'll rather wait and see when the bug is found. But I can see the improvements on the Radio2 stream and they look good and work well :) Just saw you mail coming in. However cvs update doesn't show the changes yet. But I will look forward to see the changes. :) Cheers Anders man, 01 08 2005 kl. 15:37 +0200, skrev Anders Lind: > Hi > > man, 01 08 2005 kl. 06:31 -0600, skrev Kevin DeKorte: > > > 2. There is a bug in the button handling as of now. > > > > > > When you enter full screen mode and return to normal view the buttons > > > disappear. > > > > > > > Can't duplicate. > > > > Hmmm. Strange. Try to play a stream. > > Try e.g.: > http://www.radio2.dk/lytr2.htm > and the link: > 'Webradio i høj kvalitet - 96 Kb -lyt her' > > The same observation I have made on the www.dr.dk site. > > After you exit full screen mode, try press the Stop button, and then the > Play button - the control elements disapper. > Sometimes they disappear when you leave full screen mode, other times > when you press Stop and other times again first when you press Play. But > they always disapper at some point after full screen. > > Afterwards you can from the menu press Play and Pause and nothing > happens. But when you press Stop, the elements return, but usually the > audio is silenced permanently even though I hit the Play button or the > menu and select Play. > > In this case one of the 2 mplayer processes vanishes! > > > Try this clip as well, which is very funny indeed: > http://www.coolbuddy.com/videos/video_clip.asp?id=53 > > But it will not play, however mplayer plays it fine: > mplayer http://www.coolbuddy.com/videos/clips/Women_Drivers.wmv > > In this case it doesn't seem that a mplayer process is running at all. > > > I'm not able to tell whether the 2 problems are related. > (But didn't you, Kevin, and Michael talk about some Play and Stop issues > the other day?) > > Kind regards > > Anders > > > > ------------------------------------------------------- > SF.Net email is sponsored by: Discover Easy Linux Migration Strategies > from IBM. Find simple to follow Roadmaps, straightforward articles, > informative Webcasts and more! Get everything you need to get up to > speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click > _______________________________________________ > Mplayerplug-in-devel mailing list > Mpl...@li... > https://lists.sourceforge.net/lists/listinfo/mplayerplug-in-devel > |
From: Anders L. <ra...@mi...> - 2005-08-03 20:18:54
|
Hi In the changelog I saw you made some changes regarding mms. I don't know for sure if it relates, but now I'm not able to play the famous radio streams from http://www.dr.dk In the upper left corner there is a box with a string "HØR RADIO" please choose a random channel. mplayerplug-in does not play. Closing the pop-up browser window often makes the other browser windows crash. However mplayer plays the channels fine when I wget a direct link from http://www.dr.dk/netradio/netradiohelp_direkte.shtml either 20 Kbps, 32 Kbps, 64 Kbps and copy and paste the direct link to a prompt as an argument to mplayer. It is probably easier to see the problem by pressing one of the 20, 32 or 64 Kbps direct links in a browser and see mplayerplug-in stop. debug set to 2 doesn't show anything that catches my eye. I also tried user-agent=NSPlayer but that didn't give anything either. Other channels like http://www.radio2.dk/lytr2.htm plays fine. Whether there should be any button problems left I'll rather wait and see when the bug is found. But I can see the improvements on the Radio2 stream and they look good and work well :) Just saw you mail coming in. However cvs update doesn't show the changes yet. But I will look forward to see the changes. :) Cheers Anders man, 01 08 2005 kl. 15:37 +0200, skrev Anders Lind: > Hi > > man, 01 08 2005 kl. 06:31 -0600, skrev Kevin DeKorte: > > > 2. There is a bug in the button handling as of now. > > > > > > When you enter full screen mode and return to normal view the buttons > > > disappear. > > > > > > > Can't duplicate. > > > > Hmmm. Strange. Try to play a stream. > > Try e.g.: > http://www.radio2.dk/lytr2.htm > and the link: > 'Webradio i høj kvalitet - 96 Kb -lyt her' > > The same observation I have made on the www.dr.dk site. > > After you exit full screen mode, try press the Stop button, and then the > Play button - the control elements disapper. > Sometimes they disappear when you leave full screen mode, other times > when you press Stop and other times again first when you press Play. But > they always disapper at some point after full screen. > > Afterwards you can from the menu press Play and Pause and nothing > happens. But when you press Stop, the elements return, but usually the > audio is silenced permanently even though I hit the Play button or the > menu and select Play. > > In this case one of the 2 mplayer processes vanishes! > > > Try this clip as well, which is very funny indeed: > http://www.coolbuddy.com/videos/video_clip.asp?id=53 > > But it will not play, however mplayer plays it fine: > mplayer http://www.coolbuddy.com/videos/clips/Women_Drivers.wmv > > In this case it doesn't seem that a mplayer process is running at all. > > > I'm not able to tell whether the 2 problems are related. > (But didn't you, Kevin, and Michael talk about some Play and Stop issues > the other day?) > > Kind regards > > Anders > > > > ------------------------------------------------------- > SF.Net email is sponsored by: Discover Easy Linux Migration Strategies > from IBM. Find simple to follow Roadmaps, straightforward articles, > informative Webcasts and more! Get everything you need to get up to > speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click > _______________________________________________ > Mplayerplug-in-devel mailing list > Mpl...@li... > https://lists.sourceforge.net/lists/listinfo/mplayerplug-in-devel > |
From: Kevin D. <kde...@ya...> - 2005-08-03 22:41:15
|
On Wednesday 03 August 2005 02:14 pm, Anders Lind wrote: > Hi > > In the changelog I saw you made some changes regarding mms. I don't know > for sure if it relates, but now I'm not able to play the famous radio > streams from http://www.dr.dk > In the upper left corner there is a box with a string "H=D8R RADIO" please > choose a random channel. > mplayerplug-in does not play. Closing the pop-up browser window often > makes the other browser windows crash. > Well I fixed this, it was caused by the stupid asf format, change committed= to=20 CVS. I did not experience the browser crash either before or after the fix. They are one of those sites that has a playlist, that contains an external = and=20 an internal URL. Makes things tricky.=20 > Other channels like http://www.radio2.dk/lytr2.htm plays fine. > It still does after the fix too > Whether there should be any button problems left I'll rather wait and > see when the bug is found. But I can see the improvements on the Radio2 > stream and they look good and work well :) > > Just saw you mail coming in. However cvs update doesn't show the changes > yet. But I will look forward to see the changes. :) > > Cheers > > Anders =2D-=20 Get my public GnuPG key from http://keyserver.veridis.com:11371/export?id=3D7574690260641978351 |
From: Anders L. <li...@io...> - 2005-08-04 00:47:20
|
Hi First of all it looks nice the configuration window and the button layout. I tested with http://www.dr.dk 's online player. And use KDE and KDE starts firefox with 'firefox %u' Now back to the button problem. Test case 1: 1. Go to http://www.dr.dk 2. Select a channel e.g. DR Rock 3. Make it fill the cache. 4. Enter full screen mode 5. Press stop 6. Press play ---now notice the stream is not played back--- 7. Exit full screen mode. ---notice the button has now disappeared. But may come back after a little while, but in the state where the buttons show that stop is pressed down. 8. Hit play. And we play back again. 9. Now try to go through from step 4 again and down to step 7. 10. Try to hit stop, and immediately hit play. The buttons disapper. Now wait some time, well some time. :) --- I have an old AMD 900 Athlon, but it runs nicely all though :) a) My intuition tells me that the problems may occur because it takes to long a time to close down the stream we just heard. Perhaps firefox crashes because the stream has not been taken down by mplayerplug-in, mplayer or something else before the close down of the window having the mplayer/mplayerplug-in is finished with its transition from one state into another??? b) The problems only occur when I have been into full screen mode. Test case 2 - but with a much less irritating problem: 1. Go to http://www.dr.dk again 2. Select a channel 3. Make it fill the cache. 4. At some time when the stream plays press stop. 5. Relatively short thereafter less than 5 seconds later press play. The state will after a short while change from play to stop by it self. But you can press play again and then it will load and play the stream. Not a big problem - but thought I just describe it. Perhaps its because of the cache it fills or something else? But dont spend a lot of time on it :) Test case 3 - Stupid behaviour by user makes program crash :-) 1. Go to http://www.dr.dk again 2. Select a channel 3. Make it fill the cache. 4. Hit the menu select configure. 5. Hit the menu select configure. 6. Hit the menu select configure. --- You get the idea allready, don't you ;) 7. Now press OK in one of the windows and continue this procedure and see when you crash :) I make firefox crash each and every time while mplayer plays back in the back ground. I make it crash the second time I press OK - basically only one Configuration window should be allowed I guess :) Finally when I have seen firefox crash (besides test case 3) some but rather rare - it has always happened when I either go for closing the player window or select another channel. But most of the time it has been when I closed the player window. I guess you hate such descriptions as much as I do - because they are nearly as good as nothing. My guess all though is that it is related to the delay and what happens in the transition from one state to another (more or less obviously) e.g. from play to stop and what happens when the transition is interrupted in a vulneable moment. Well, test case 1 has vulneable moments because of the way streams and/or mplayer perhaps is handled during a close or start when interrupted by a foolish human as my self :) I'll send the new translation file when I have had some sleep - I need it :) Regards Anders PS Hope we have a release soon. Lets hope the other translations come in more rapidly now when the template is done. ons, 03 08 2005 kl. 16:41 -0600, skrev Kevin DeKorte: > On Wednesday 03 August 2005 02:14 pm, Anders Lind wrote: > > Hi > > > > In the changelog I saw you made some changes regarding mms. I don't know > > for sure if it relates, but now I'm not able to play the famous radio > > streams from http://www.dr.dk > > In the upper left corner there is a box with a string "HØR RADIO" please > > choose a random channel. > > mplayerplug-in does not play. Closing the pop-up browser window often > > makes the other browser windows crash. > > > > Well I fixed this, it was caused by the stupid asf format, change committed to > CVS. I did not experience the browser crash either before or after the fix. > > They are one of those sites that has a playlist, that contains an external and > an internal URL. Makes things tricky. > > > Other channels like http://www.radio2.dk/lytr2.htm plays fine. > > > > It still does after the fix too > > > Whether there should be any button problems left I'll rather wait and > > see when the bug is found. But I can see the improvements on the Radio2 > > stream and they look good and work well :) > > > > Just saw you mail coming in. However cvs update doesn't show the changes > > yet. But I will look forward to see the changes. :) > > > > Cheers > > > > Anders > |
From: Kevin D. <kde...@ya...> - 2005-08-04 02:21:14
|
On Wednesday 03 August 2005 06:47 pm, Anders Lind wrote: > Hi > > First of all it looks nice the configuration window and the button > layout. > > I tested with http://www.dr.dk 's online player. And use KDE and KDE > starts firefox with 'firefox %u' > > Now back to the button problem. > Test case 1: > 1. Go to http://www.dr.dk > 2. Select a channel e.g. DR Rock > 3. Make it fill the cache. > 4. Enter full screen mode > 5. Press stop > 6. Press play > ---now notice the stream is not played back--- > 7. Exit full screen mode. > ---notice the button has now disappeared. But may come back after a > little while, but in the state where the buttons show that stop is > pressed down. > 8. Hit play. And we play back again. > 9. Now try to go through from step 4 again and down to step 7. > 10. Try to hit stop, and immediately hit play. The buttons disapper. Now > wait some time, well some time. :) > --- I have an old AMD 900 Athlon, but it runs nicely all though :) > > a) My intuition tells me that the problems may occur because it takes to > long a time to close down the stream we just heard. Perhaps firefox > crashes because the stream has not been taken down by mplayerplug-in, > mplayer or something else before the close down of the window having the > mplayer/mplayerplug-in is finished with its transition from one state > into another??? > This problem is going to probably have to be fixed next time... not a high= =20 priority since we are playing an audio file full screen... Tempted to just= =20 hide/disable fullscreen when only audio is being played. > b) The problems only occur when I have been into full screen mode. > > > Test case 2 - but with a much less irritating problem: > 1. Go to http://www.dr.dk again > 2. Select a channel > 3. Make it fill the cache. > 4. At some time when the stream plays press stop. > 5. Relatively short thereafter less than 5 seconds later press play. The > state will after a short while change from play to stop by it self. But > you can press play again and then it will load and play the stream. Not > a big problem - but thought I just describe it. Perhaps its because of > the cache it fills or something else? But dont spend a lot of time on > it :) > Aware of this, working on a fix at the moment, also found a case where the= =20 buttons change and are at the wrong state (button stop is down and media is= =20 playing) > > Test case 3 - Stupid behaviour by user makes program crash :-) > 1. Go to http://www.dr.dk again > 2. Select a channel > 3. Make it fill the cache. > 4. Hit the menu select configure. > 5. Hit the menu select configure. > 6. Hit the menu select configure. > --- You get the idea allready, don't you ;) > 7. Now press OK in one of the windows and continue this procedure and > see when you crash :) I make firefox crash each and every time while > mplayer plays back in the back ground. I make it crash the second time I > press OK - basically only one Configuration window should be allowed I > guess :) > =46ixed.. committing to CVS here in a min. > > Finally when I have seen firefox crash (besides test case 3) some but > rather rare - it has always happened when I either go for closing the > player window or select another channel. But most of the time it has > been when I closed the player window. I guess you hate such descriptions > as much as I do - because they are nearly as good as nothing. > My guess all though is that it is related to the delay and what happens > in the transition from one state to another (more or less obviously) > e.g. from play to stop and what happens when the transition is > interrupted in a vulneable moment. Well, test case 1 has vulneable > moments because of the way streams and/or mplayer perhaps is handled > during a close or start when interrupted by a foolish human as my > self :) > Yes I absolutely hate them, because I can't duplicate them most of the time= =2E..=20 Need a clear sequence and a back trace if possible. I've been playing aroun= d=20 with dr.dk and have not seen a crash, does not mean it is perfect, but have= =20 not seen one. You also might try upgrading to a current mplayer. > I'll send the new translation file when I have had some sleep - I need > it :) > > > Regards > > Anders > > PS Hope we have a release soon. Lets hope the other translations come in > more rapidly now when the template is done. > I want to do a release, but you keep having problems... just holds it up. B= ut=20 better we find them in testing.=20 Kevin =2D-=20 Get my public GnuPG key from http://keyserver.veridis.com:11371/export?id=3D7574690260641978351 |
From: Kevin D. <kde...@ya...> - 2005-08-04 13:42:14
|
On Wednesday 03 August 2005 08:20 pm, Kevin DeKorte wrote: > On Wednesday 03 August 2005 06:47 pm, Anders Lind wrote: > > Hi > > > > First of all it looks nice the configuration window and the button > > layout. > > > > I tested with http://www.dr.dk 's online player. And use KDE and KDE > > starts firefox with 'firefox %u' > > > > Now back to the button problem. > > Test case 1: > > 1. Go to http://www.dr.dk > > 2. Select a channel e.g. DR Rock > > 3. Make it fill the cache. > > 4. Enter full screen mode > > 5. Press stop > > 6. Press play > > ---now notice the stream is not played back--- > > 7. Exit full screen mode. > > ---notice the button has now disappeared. But may come back after a > > little while, but in the state where the buttons show that stop is > > pressed down. > > 8. Hit play. And we play back again. > > 9. Now try to go through from step 4 again and down to step 7. > > 10. Try to hit stop, and immediately hit play. The buttons disapper. Now > > wait some time, well some time. :) > > --- I have an old AMD 900 Athlon, but it runs nicely all though :) > > > > a) My intuition tells me that the problems may occur because it takes to > > long a time to close down the stream we just heard. Perhaps firefox > > crashes because the stream has not been taken down by mplayerplug-in, > > mplayer or something else before the close down of the window having the > > mplayer/mplayerplug-in is finished with its transition from one state > > into another??? > Looks like I found the cause of this one... real simple fix. Problem 2 is t= he=20 same thing. I'll describe what happend at bottom of this email. > This problem is going to probably have to be fixed next time... not a high > priority since we are playing an audio file full screen... Tempted to just > hide/disable fullscreen when only audio is being played. > > > b) The problems only occur when I have been into full screen mode. > > > > > > Test case 2 - but with a much less irritating problem: > > 1. Go to http://www.dr.dk again > > 2. Select a channel > > 3. Make it fill the cache. > > 4. At some time when the stream plays press stop. > > 5. Relatively short thereafter less than 5 seconds later press play. The > > state will after a short while change from play to stop by it self. But > > you can press play again and then it will load and play the stream. Not > > a big problem - but thought I just describe it. Perhaps its because of > > the cache it fills or something else? But dont spend a lot of time on > > it :) > > Aware of this, working on a fix at the moment, also found a case where the > buttons change and are at the wrong state (button stop is down and media = is > playing) > > > Test case 3 - Stupid behaviour by user makes program crash :-) > > 1. Go to http://www.dr.dk again > > 2. Select a channel > > 3. Make it fill the cache. > > 4. Hit the menu select configure. > > 5. Hit the menu select configure. > > 6. Hit the menu select configure. > > --- You get the idea allready, don't you ;) > > 7. Now press OK in one of the windows and continue this procedure and > > see when you crash :) I make firefox crash each and every time while > > mplayer plays back in the back ground. I make it crash the second time I > > press OK - basically only one Configuration window should be allowed I > > guess :) > > Fixed.. committing to CVS here in a min. > > > Finally when I have seen firefox crash (besides test case 3) some but > > rather rare - it has always happened when I either go for closing the > > player window or select another channel. But most of the time it has > > been when I closed the player window. I guess you hate such descriptions > > as much as I do - because they are nearly as good as nothing. > > My guess all though is that it is related to the delay and what happens > > in the transition from one state to another (more or less obviously) > > e.g. from play to stop and what happens when the transition is > > interrupted in a vulneable moment. Well, test case 1 has vulneable > > moments because of the way streams and/or mplayer perhaps is handled > > during a close or start when interrupted by a foolish human as my > > self :) > > Yes I absolutely hate them, because I can't duplicate them most of the > time... Need a clear sequence and a back trace if possible. I've been > playing around with dr.dk and have not seen a crash, does not mean it is > perfect, but have not seen one. You also might try upgrading to a current > mplayer. > > > I'll send the new translation file when I have had some sleep - I need > > it :) > > > > > > Regards > > > > Anders > > > > PS Hope we have a release soon. Lets hope the other translations come in > > more rapidly now when the template is done. > > I want to do a release, but you keep having problems... just holds it up. > But better we find them in testing. > > Kevin With dr.dk here is what was going on. dr.dk sends an http url, that url whe= n=20 you access it gives you a playlist. The first item on the playlist is=20 basically the same url that gave you the playlist, but with some extra=20 parameters. This is determined to be a "mms" type of url. The second item o= n=20 the list is the same url at the first one in the list, but it has a=20 non-routable hostname (192.168.x.x) So it is also added to the list and is= =20 marked as mms (probably used internally at dr.dk) When you hit stop I used to have it seek to time 0. However, seeking on an = mms=20 stream will cause mplayer to hang. So I put in some code to just quit when = we=20 have an mms stream. However at this point the playlist code was coming into= =20 play and trying the next item on the list. So then it immediately starts=20 trying to play the non-routable address. Mplayer since it can't connect=20 hangs. It will eventually time out. But if you try and close mplayerplug-in= =20 in this state it may crash. So what I did to fix this is to mark all items = on=20 the playlist that are playable as "played" and then send the quit and=20 therefore the non-routeable address is never tried.=20 Kevin =2D-=20 Get my public GnuPG key from http://keyserver.veridis.com:11371/export?id=3D7574690260641978351 |