Re: [Mplayerplug-in-devel] "noembed" check missing since 1.0

[Kevin D. <kde...@ya...>]

Ken,

I have added the noembed option back into the code. It is in CVS
Actually the website should list which options have be depreciated.

Kevin

On Sunday 29 February 2004 05:27 pm, Ken Salerno wrote:
> I have a unique problem: I have an old ATI 3D Rage Pro, and to get a
> decent frame rate I have to use the xvidix vo driver when playing
> anything with mplayer.  This creates a problem because you can't embed
> xvidix output, it must be in its own mplayer window.
>
> mplayerplug-in 1.0 used to check to see if you had noembed=1 in your
> mplayerplug-in.conf file like so:
>
> "mplayerplug-in.c" line 1116 of 1249 --89%-- col 29
>
> if (This->noembed == 0) {
>         if (This->window != 0) {
>             sprintf(This->td->argv[i++], "-wid");
>             sprintf(This->td->argv[i++], "0x%x", This->window);
>         }
> }
>
> The option in question here is "-wid <window id>"  This cannot be present
> if "noembed=1" is in the conf file.  But now that mplayerplug-in 2.0 and
> beyond don't check for this option, I had to do the following:
>
> "plugin-threads.cpp" line 130 of 629 --20%-- col 37
>
>   if (instance->mode == NP_EMBED) {
>         if (instance->window != 0) {
> //-----------------------------------------------------------------
> //            snprintf(instance->td->argv[i++], 1024, "-wid");
> //-----------------------------------------------------------------
>             instance->player_window =
>                 XCreateSimpleWindow(instance->display, instance->window, 0,
>                                     0, instance->embed_width,
>                                     instance->embed_height, 0, 0, 0);
> //------------------------------------------------------------------
> //            snprintf(instance->td->argv[i++], 1024, "0x%x",
> //                     (int) instance->player_window);
> //------------------------------------------------------------------
>         }
>     }
>
>
> It's obviously not a high priority thing on your TODO list, I must be one
> of maybe 20 people who need mplayer to popup in its own window, but for
> the 3.0 release, it would be great if you can go through the
> mplayerplug-in.conf file and see which options that were being addressed
> in 1.0 are not being ignored since the move to C++.
>
> Great job so far.
>
> Thanks,
> Ken
>
>
> -------------------------------------------------------
> SF.Net is sponsored by: Speed Start Your Linux Apps Now.
> Build and deploy apps & Web services for Linux with
> a free DVD software kit from IBM. Click Now!
> http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
> _______________________________________________
> Mplayerplug-in-devel mailing list
> Mpl...@li...
> https://lists.sourceforge.net/lists/listinfo/mplayerplug-in-devel