[Mplayerplug-in-devel] Compilation error with 0.30 with GCC 2.96

[Olivier C. <cah...@ep...>]

Hi,

v.0.23 compiled and worked flawlessly on a Mandrake 8.2 (GCC 2.96), 
tested with mplayer 0.90rc2 and Mozilla 20030117 (compiled from CVS on 
the same box).

when compiling 0.30, I get the following

gcc -c -g -DXP_UNIX -Iinclude -ISource/_gen -I/usr/X11R6/include -I. 
-I/usr/include Source/mplayerplug-in.c
Source/mplayerplug-in.c: In function `Redraw':
Source/mplayerplug-in.c:560: parse error before `*'
Source/mplayerplug-in.c:562: `This' undeclared (first use in this function)
Source/mplayerplug-in.c:562: (Each undeclared identifier is reported 
only once
Source/mplayerplug-in.c:562: for each function it appears in.)
make: *** [mplayerplug-in.o] Error 1

The following patch fixes the issue:

-- Source/mplayerplug-in.c~    Sat Jan 18 16:21:40 2003
+++ Source/mplayerplug-in.c     Sat Jan 18 18:18:44 2003
@@ -538,7 +538,7 @@
  void Redraw(Widget w, NPP instance, XEvent *event)
  {

-
+       PluginInstance* This;
         GC gc;
          int pid,ret;
          pid_t child, child2, mp_pid, moz_pid;
@@ -557,7 +557,7 @@
         }
         printf("RED %i\n",instance);

-        PluginInstance* This = (PluginInstance*)instance->pdata;
+        This = (PluginInstance*)instance->pdata;

         if (This == NULL) {
                 if (DEBUG) fprintf(This->logfp,"Our This is null!\n");


Thanks for this plug-in, it's absolutely fantastic.

Olivier.